Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp361020imm; Wed, 29 Aug 2018 01:45:52 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbcCshqgJk53Ff8ZwjwxBOwXrM9AvCGk5+tyE0lhXJIVyHfTye3KUEBtPh4dmgtFjZcB1jN X-Received: by 2002:a17:902:7c96:: with SMTP id y22-v6mr193005pll.332.1535532352725; Wed, 29 Aug 2018 01:45:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535532352; cv=none; d=google.com; s=arc-20160816; b=ssIqKcXCcc/fR5ENJjhjPN9YVB6cBtsSyXSIUg8AD0/Bs3rMLFx2BlXQlHh75IxQOg Q4yVDBN+nC/w/Jhq/Onry6cNhYeJAnUhHKqsZKObfh2yDMY0obXY9a0y1RwJjgQ6AX6q +IljBnd317S6S6LOP7fjQSYqFpAqYruojkJV0eH7r5i4N53DB5XC1vPTFk2bD8yk4/qJ G8QdiyeZSwQ1fqvv2tzg2twrgPpP2AzZ7OJeIUPOnlIRDclDdPGNj82uCrgkOx7EsZz2 DYe5Dtmy4NtnQd4c+uEVB/fB4E2oTtAAARUTxWUhWDH7ViZmM0z5ixE3QmzaqQ3qoIII Be9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=oA8PfgkiINH1aXL06ayuqgK2j7s0blBWbeoaCHvSSCo=; b=kpXdzQh7r/Pv0HPu0xC4qFQ8nrdMWTay67vKBuOLKvDYbIV/Uj6rH97py1Vplz57Lx wSizsL+MS9+CNdG1n/bkF2JYKRG1Yn82guD9N8pDlAUGDlYa4b6mMmiOnPA7sTPzRQLz V0NyEOwejdNzPqeV5Fy0/BC+SKwtX/XOER87LMHNf9/H5LF0ZahXyeadJGSiWc5+tqMb QXwBfZmmtHTsk5hy70ww/i+YuWchy9gfZTUCviQ7BhpFcdvEDtx6S6/9rq5LrpJyJ87B 802bdJ8ER0DyY/Ug+pvVD8qs3WL2iOXWzjyQEEHjOjuJve+oqxoXLVxWcvEBfuo/xcwe PlqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v11-v6si3232262pfk.165.2018.08.29.01.45.37; Wed, 29 Aug 2018 01:45:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728154AbeH2Mjk (ORCPT + 99 others); Wed, 29 Aug 2018 08:39:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:41558 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727107AbeH2Mjk (ORCPT ); Wed, 29 Aug 2018 08:39:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 127AFAD2C; Wed, 29 Aug 2018 08:43:49 +0000 (UTC) Subject: Re: [PATCH] xen-blkback: Switch to closed state after releasing the backing device To: Valentin Vidic Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Konrad Rzeszutek Wilk , Jens Axboe , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20180829065214.23546-1-Valentin.Vidic@CARNet.hr> <1701ccef-3ebb-973b-de32-059a8816d31c@suse.com> <20180829082731.GX26705@gavran.carpriv.carnet.hr> From: Juergen Gross Openpgp: preference=signencrypt Autocrypt: addr=jgross@suse.com; prefer-encrypt=mutual; keydata= xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOB ycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJve dYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJ NwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvx XP3FAp2pkW0xqG7/377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEB AAHNHkp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmRlPsLAeQQTAQIAIwUCU4xw6wIbAwcL CQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJELDendYovxMvi4UH/Ri+OXlObzqMANruTd4N zmVBAZgx1VW6jLc8JZjQuJPSsd/a+bNr3BZeLV6lu4Pf1Yl2Log129EX1KWYiFFvPbIiq5M5 kOXTO8Eas4CaScCvAZ9jCMQCgK3pFqYgirwTgfwnPtxFxO/F3ZcS8jovza5khkSKL9JGq8Nk czDTruQ/oy0WUHdUr9uwEfiD9yPFOGqp4S6cISuzBMvaAiC5YGdUGXuPZKXLpnGSjkZswUzY d9BVSitRL5ldsQCg6GhDoEAeIhUC4SQnT9SOWkoDOSFRXZ+7+WIBGLiWMd+yKDdRG5RyP/8f 3tgGiB6cyuYfPDRGsELGjUaTUq3H2xZgIPfOwE0EU4xwFgEIAMsx+gDjgzAY4H1hPVXgoLK8 B93sTQFN9oC6tsb46VpxyLPfJ3T1A6Z6MVkLoCejKTJ3K9MUsBZhxIJ0hIyvzwI6aYJsnOew cCiCN7FeKJ/oA1RSUemPGUcIJwQuZlTOiY0OcQ5PFkV5YxMUX1F/aTYXROXgTmSaw0aC1Jpo w7Ss1mg4SIP/tR88/d1+HwkJDVW1RSxC1PWzGizwRv8eauImGdpNnseneO2BNWRXTJumAWDD pYxpGSsGHXuZXTPZqOOZpsHtInFyi5KRHSFyk2Xigzvh3b9WqhbgHHHE4PUVw0I5sIQt8hJq 5nH5dPqz4ITtCL9zjiJsExHuHKN3NZsAEQEAAcLAXwQYAQIACQUCU4xwFgIbDAAKCRCw3p3W KL8TL0P4B/9YWver5uD/y/m0KScK2f3Z3mXJhME23vGBbMNlfwbr+meDMrJZ950CuWWnQ+d+ Ahe0w1X7e3wuLVODzjcReQ/v7b4JD3wwHxe+88tgB9byc0NXzlPJWBaWV01yB2/uefVKryAf AHYEd0gCRhx7eESgNBe3+YqWAQawunMlycsqKa09dBDL1PFRosF708ic9346GLHRc6Vj5SRA UTHnQqLetIOXZm3a2eQ1gpQK9MmruO86Vo93p39bS1mqnLLspVrL4rhoyhsOyh0Hd28QCzpJ wKeHTd0MAWAirmewHXWPco8p1Wg+V+5xfZzuQY0f4tQxvOpXpt4gQ1817GQ5/Ed/wsDtBBgB CAAgFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAlrd8NACGwIAgQkQsN6d1ii/Ey92IAQZFggA HRYhBFMtsHpB9jjzHji4HoBcYbtP2GO+BQJa3fDQAAoJEIBcYbtP2GO+TYsA/30H/0V6cr/W V+J/FCayg6uNtm3MJLo4rE+o4sdpjjsGAQCooqffpgA+luTT13YZNV62hAnCLKXH9n3+ZAgJ RtAyDWk1B/0SMDVs1wxufMkKC3Q/1D3BYIvBlrTVKdBYXPxngcRoqV2J77lscEvkLNUGsu/z W2pf7+P3mWWlrPMJdlbax00vevyBeqtqNKjHstHatgMZ2W0CFC4hJ3YEetuRBURYPiGzuJXU pAd7a7BdsqWC4o+GTm5tnGrCyD+4gfDSpkOT53S/GNO07YkPkm/8J4OBoFfgSaCnQ1izwgJQ jIpcG2fPCI2/hxf2oqXPYbKr1v4Z1wthmoyUgGN0LPTIm+B5vdY82wI5qe9uN6UOGyTH2B3p hRQUWqCwu2sqkI3LLbTdrnyDZaixT2T0f4tyF5Lfs+Ha8xVMhIyzNb1byDI5FKCb Message-ID: Date: Wed, 29 Aug 2018 10:43:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180829082731.GX26705@gavran.carpriv.carnet.hr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/08/18 10:27, Valentin Vidic wrote: > On Wed, Aug 29, 2018 at 10:16:09AM +0200, Juergen Gross wrote: >> Did you test whether it is okay to not change state in case the device >> is still online? > > Not sure how to simulate that. Maybe using xl block-detach or something else? > I think this should be an action triggered by the frontend, not by dom0 (xen tools will always set "online" to 0 when removing a device, AFAIK). I'm not sure this is relevant, but I realized this behavior is changed by your patch. Juergen