Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp447712imm; Wed, 29 Aug 2018 04:09:57 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ3B1oDGP/Iz2jYh+YVCTaY3qPnMI6uApdKJ90sfdGYZHm5JMdsj1mix+kTZ5Qo1HGWe0cb X-Received: by 2002:a17:902:6681:: with SMTP id e1-v6mr5533352plk.109.1535540997354; Wed, 29 Aug 2018 04:09:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535540997; cv=none; d=google.com; s=arc-20160816; b=obgfZ7lZGoEdpj+1SiRprl+SVBjPpUohdv3CloQhmAxY/zwmndL5CPLfbJceHGZcp+ VP54Ik4ASUSJg+F3N0Ft2PavhcBWFBXDtzDj07kV7HTzzSrofrExhhGbyHbQolJ/3v60 IYV2U8vcrOB6mVNZwLlkosDuPScTXiyoLao9v48eWoqd21XNd8nuDa9L5WU6Wb4IEZ+e Km5UnQ7ST9n2QuQZQN0VhY3F7W6SDiEcgiUSWEgo//2rO5/VVzrItdjiQsi4eJ9C12o8 zPT00jUqTcNhIBelZgLMyiAy4DIvQ4aUJCOLnlpdXMSBfDvCNcV/QoMJA6FP1D6FHl2b YRdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=3qzgHUcozG7fwDGcplunc95cPwl7r/MPZwNStqtgWvE=; b=nYQkvVvH/w8O99OAPIRXxaTBBU8A8R3hD16eVS5Yxo3fnMgY4XUFKu7fdY+/kBxhiI 5IjcQ9D64k40M4lJE5yo5POJPIRMxqf+e4X9P6QELzBawPpt7DNhXuYPeOoF6VPLSQ1e HpelcSD2neR8ZKa9UNNQ1QA5Ve2Q4BvmiGQqOHIQt2GUT+9QXsJtQzRzcJtScjZCUilh GDGTNqjeQ/yEH0UqqQrydzlgMM5WmdNr6+bA+0G3mj8cfJKQTjVULZjD+ED3WSXVknQv /PdNz+SxLwOBKbprAZziEUk2IP/dXMpw9BVvtt7r0HXQFodQxbHjKo3jU9d01EgfglLZ h0JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ZMkjK7om; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u13-v6si3647412pgg.263.2018.08.29.04.09.42; Wed, 29 Aug 2018 04:09:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ZMkjK7om; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728366AbeH2PEe (ORCPT + 99 others); Wed, 29 Aug 2018 11:04:34 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:43214 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727099AbeH2PEe (ORCPT ); Wed, 29 Aug 2018 11:04:34 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w7TB4LYr193074; Wed, 29 Aug 2018 11:07:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=3qzgHUcozG7fwDGcplunc95cPwl7r/MPZwNStqtgWvE=; b=ZMkjK7omdUk+7hqzAkFeUrwTgGC37AyXHg34ToZLXn8pVy20i1tMpyu2aRcXj2nAsOgm aWrl5trBzk55V9ruEwYXX9m42Omz3UUkDpWZZ9FKMzz0NpV8y8GFu7P0NignYWfoKHrW VE8g/vrWoWH9fhdL0bNHbi5QzT4royJe1TGon/Zzng+7IMtCKPbde1h7KN1Eh5XuTPWq 7kxTwc1O9tAj1kcWQA3JKVUDoaqsfp5yi/j5Dkhi3xnrUTi5hBxuwezBhwf5zuJ5znxS 2jZn07RSX8qrkpzfV4vyJ8+Ygg4s677SwmKqfXj0rxkLkT24D+jQLI88znkhw2Jypdhd jQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2m2yrq905s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Aug 2018 11:07:52 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w7TB7pNY017742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Aug 2018 11:07:51 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w7TB7mcO001394; Wed, 29 Aug 2018 11:07:48 GMT Received: from mwanda (/197.232.248.111) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Aug 2018 04:07:48 -0700 Date: Wed, 29 Aug 2018 14:07:39 +0300 From: Dan Carpenter To: Ioana Radulescu Cc: netdev@vger.kernel.org, davem@davemloft.net, devel@driverdev.osuosl.org, andrew@lunn.ch, horia.geanta@nxp.com, madalin.bucur@nxp.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ioana.ciornei@nxp.com, laurentiu.tudor@nxp.com Subject: Re: [PATCH net-next v2 0/2] dpaa2-eth: Move DPAA2 Ethernet driver Message-ID: <20180829110739.3xzbdtelwjlhun2v@mwanda> References: <20180829094240.27242-1-ruxandra.radulescu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180829094240.27242-1-ruxandra.radulescu@nxp.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8999 signatures=668708 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=822 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808290122 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are a few static checker warnings for the driver but only the first one looks like a possibly real bug. drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1116 dpaa2_eth_stop() error: uninitialized symbol 'dpni_enabled'. drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c:1671 set_fq_affinity() warn: 'xps_mask' puts 1024 bytes on stack drivers/staging/fsl-dpaa2/ethsw/ethsw.c:742 port_vlans_add() error: uninitialized symbol 'err'. drivers/staging/fsl-dpaa2/ethsw/ethsw.c:886 port_vlans_del() error: uninitialized symbol 'err'. regards, dan carpenter