Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180825084417.13526-1-robert.jarzmik@free.fr>
In-Reply-To: <20180825084417.13526-1-robert.jarzmik@free.fr>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 29 Aug 2018 13:57:08 +0200
Message-ID: <CACRpkdbU=87WNn1jksJitVouOQuXJsukUqCXggnD6kUjyr7Zwg@mail.gmail.com>
Subject: Re: [PATCH] gpio: pxa: handle corner case of unprobed device
To:     Robert Jarzmik <robert.jarzmik@free.fr>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Aug 25, 2018 at 10:44 AM Robert Jarzmik <robert.jarzmik@free.fr> wrote:

> In the corner case where the gpio driver probe fails, for whatever
> reason, the suspend and resume handlers will still be called as they
> have to be registered as syscore operations. This applies as well when
> no probe was called while the driver has been built in the kernel.
>
> Nicolas tracked this in :
> https://bugzilla.kernel.org/show_bug.cgi?id=200905
>
> Therefore, add a failsafe in these function, and test if a proper probe
> succeeded and the driver is functional.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Reported-by: Nicolas Chauvet <kwizart@gmail.com>

Patch applied.

Yours,
Linus Walleij