Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp485735imm;
        Wed, 29 Aug 2018 05:06:22 -0700 (PDT)
X-Google-Smtp-Source: ANB0Vdaco9XLJ+g1OAc7G8wfzqGT5h8qSl8ZYk95G0lkkFxTeuTxfk9EOnIUhmQYwJrlSE3xyzMj
X-Received: by 2002:a17:902:bc4b:: with SMTP id t11-v6mr5639657plz.262.1535544382224;
        Wed, 29 Aug 2018 05:06:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1535544382; cv=none;
        d=google.com; s=arc-20160816;
        b=ZBhNrhRUKgs9Np3qrN+3UUPl7EI9l81Ezu5ZDvEtKZTmadYDwyyuhGIHIdoktMLkzL
         6Kxy5gplZVl31HF93DOYFQXpsLqMY1EBZK3dPVupQBSw2JJ1ZVpHrLfh/MapGsGNKNOk
         VMns4FihZfV0wd36BaZxXFMq6K2u/WvfSlOp6EmWdNhF8Cpz76/1o2+KEY/p5zs51IgW
         aKYPjqWdRLh0kXICVY8Uta9+CdM9HqYeqtRTxvMAn49Y6j3lf62miTbkGZXJH1DtdtlM
         o2O5CTF5bagM04iwvp8eG+nt1ZAelE8bigpyt5FYrCxrerf7hZdX7fY7eNv7LjRRP7ND
         qHzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature
         :arc-authentication-results;
        bh=yvWT9F3i/88z544uu3HaErLdy4sBRRKi67ZiOKyK7/A=;
        b=Crh7hCbT9Rb65OtZV5PSCM1/3b0xxRjlE6fLZTWzg1ynfxuH37m/k2hzEnnkQSkKFK
         FiFAcPahqnaRFQvItW2N3sniUxmhzYgLfOM78huYLUvU+7oTN0y5vq8uFO43MR8AThSn
         45cneONHTFQuongdi5WFeEPCrj0Dx8oN5YrK4qfBqNmpjCwjapWXq4OUowOCRxntbBPH
         PnwaEJIElSbIHVD9UVhETXsi/WhSYnDhbAJGYWlu1cVsUz7TuCVVblklRv8KZwGcfcwf
         WxM5OtE6wfgFBY7nZbl+hq73q14HctaRCZw6Pc+ucQKJpsPs+ggLnEYacXmvT7cr5OrI
         oWTQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=PPoLaN1r;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id h22-v6si3708965pfa.238.2018.08.29.05.06.06;
        Wed, 29 Aug 2018 05:06:22 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linaro.org header.s=google header.b=PPoLaN1r;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728027AbeH2QBS (ORCPT <rfc822;xqjcool@gmail.com> + 99 others);
        Wed, 29 Aug 2018 12:01:18 -0400
Received: from mail-io0-f194.google.com ([209.85.223.194]:38860 "EHLO
        mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727264AbeH2QBS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Aug 2018 12:01:18 -0400
Received: by mail-io0-f194.google.com with SMTP id y3-v6so4254691ioc.5
        for <linux-kernel@vger.kernel.org>; Wed, 29 Aug 2018 05:04:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=yvWT9F3i/88z544uu3HaErLdy4sBRRKi67ZiOKyK7/A=;
        b=PPoLaN1rdadkumr9ztKhg+95n1neGOl71FZk+usUiM3rwIMtv56dk3/dSKMIQoYKnf
         nCCz6WU44C1zwRdIijgGXj26uQt4H+yWJlo5swvmoVZm5wkOTkr5Pbd0Tvc8fsCNnqH3
         Ynu1NHLSWnCQmdHoNQjE3DtLUlAvhD6+xxJN8=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=yvWT9F3i/88z544uu3HaErLdy4sBRRKi67ZiOKyK7/A=;
        b=ULne6EI+JPI5ObE1N2pAmDQZ/MFXoQPy8l67/pLj4OaPeUCGdIqjrbmk8dd4MZh0xg
         gLy9DkDBnfXm4EUUSXWci1aDHzSxCiawOga+GY3nNy3vr9T/asGrGNy0wKBf1mZOyNpl
         Bh4WqwWDECpDCEHKdGqo7Xzlcti1q1sp4jT/ecNW6cB1eL9l6xmLZBJq2gKhtH3ZQbeO
         gXW9WTCLgAm5UmZkTC8AsDI7rs/lBrh1fLHmCu2e3++UUBuGKMn1sPH3GBwG1FkvuuvE
         sWsa+QSWq18ibSOLphPVvXa7wfc4E7/eJeS5cjfCktL71TdyXoEIXGhpPZPxzRAoLGPj
         TjnQ==
X-Gm-Message-State: APzg51DADOi4Hvyc53o0aDpcwfPcFLeEw8Gzf7ZAVmJ1kCMVnPuNzHNN
        tVa3uqDxX/nKqRj3IitKrCTh6F7vNAj9xzqmHYf7Aw==
X-Received: by 2002:a6b:c3c4:: with SMTP id t187-v6mr4776994iof.304.1535544282816;
 Wed, 29 Aug 2018 05:04:42 -0700 (PDT)
MIME-Version: 1.0
References: <1535488826-30200-1-git-send-email-khoroshilov@ispras.ru>
In-Reply-To: <1535488826-30200-1-git-send-email-khoroshilov@ispras.ru>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Wed, 29 Aug 2018 14:04:30 +0200
Message-ID: <CACRpkdZuA0S7CmHu07mHz545QfDsvN62VeoPcmEwpYGuCWu1WQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: dwapb: Fix error handling in dwapb_gpio_probe()
To:     Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc:     Hoan Tran <hotran@apm.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ldv-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 28, 2018 at 10:43 PM Alexey Khoroshilov
<khoroshilov@ispras.ru> wrote:

> If dwapb_gpio_add_port() fails in dwapb_gpio_probe(),
> gpio->clk is left undisabled.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Patch applied for fixes.

Yours,
Linus Walleij