Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 29 Aug 2018 14:38:35 +0200
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Emmanuel Vadot <manu@bidouilliste.com>
Cc:     Eduardo Valentin <edubezval@gmail.com>,
        Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org,
        "open list:THERMAL" <linux-pm@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Emmanuel Vadot <manu@freebsd.org>,
        Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for
 Allwinner Thermal Sensor Controller
Message-ID: <20180829123835.pe674l7kwwtq3nm5@flea>
References: <20180804070355.14857-1-manu@freebsd.org>
 <20180820111755.rzg7l2lznmbpuf2e@flea>
 <CAL_JsqLVQDRH1esAXghfQdxmp+iorWVCArM2qTwjbgmQzmhzQw@mail.gmail.com>
 <20180820140737.xmqhu5ndqzehvkql@flea>
 <20180820162715.49e6d8a469ece983f3c1d288@bidouilliste.com>
 <20180824145840.isdcg3fr6mw4ntzg@flea>
 <20180824215921.59d060b54eb3a1e7d1552bde@bidouilliste.com>
 <20180824230338.GA19399@localhost.localdomain>
 <20180825174352.68de8a2720f4c91b987be914@bidouilliste.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="q2hvfmvfl4mg43xk"
Content-Disposition: inline
In-Reply-To: <20180825174352.68de8a2720f4c91b987be914@bidouilliste.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--q2hvfmvfl4mg43xk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 25, 2018 at 05:43:52PM +0200, Emmanuel Vadot wrote:
>=20
>  Hi,
>=20
> On Fri, 24 Aug 2018 16:03:40 -0700
> Eduardo Valentin <edubezval@gmail.com> wrote:
>=20
> > On Fri, Aug 24, 2018 at 09:59:21PM +0200, Emmanuel Vadot wrote:
> > >=20
> > >  Hi,
> > >=20
> > > On Fri, 24 Aug 2018 16:58:40 +0200
> > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > >=20
> > > > Hi,
> > > >=20
> > > > On Mon, Aug 20, 2018 at 04:27:15PM +0200, Emmanuel Vadot wrote:
> > > > > On Mon, 20 Aug 2018 16:07:37 +0200
> > > > > Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > >=20
> > > > > > On Mon, Aug 20, 2018 at 07:41:22AM -0600, Rob Herring wrote:
> > > > > > > On Mon, Aug 20, 2018 at 5:17 AM Maxime Ripard <maxime.ripard@=
bootlin.com> wrote:
> > > > > > > >
> > > > > > > > On Sat, Aug 04, 2018 at 09:03:49AM +0200, Emmanuel Vadot wr=
ote:
> > > > > > > > > This patch adds documentation for Device-Tree bindings fo=
r the Allwinner
> > > > > > > > > Thermal Sensor Controller found on the H3, H5 and A64 SoCs
> > > > > > > > >
> > > > > > > > > Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> > > > > > > >
> > > > > > > > I'm not going to merge a binding for a device that doesn't =
have any
> > > > > > > > driver implemented at the moment in Linux.
> > > > > > >=20
> > > > > > > I'll take it then. Linux is not the only DT client.
> > > > > >=20
> > > > > > Then don't complain if we ever have to break the ABI. We never =
tested
> > > > > > that hardware, never had any code running on it, and it *will* =
cause
> > > > > > some issues. For example, the calibration data have never been =
used
> > > > > > and how they should be represented have never been described, s=
ince no
> > > > > > one ever actually tried to use it.
> > > > > >=20
> > > > > > And sure, Linux is not the only DT client. Just like FreeBSD is=
n't.
> > > > >=20
> > > > >  What kind of data would you need for me to make things better ?
> > > > >  We have the driver in FreeBSD for almost two years now, whne I s=
tarted
> > > > > to see how to upstream it I noticed a lot of problems and spent 4=
 or 5
> > > > > days to try on all the SoCs mentionned in the serie, the only SoC=
 I
> > > > > didn't include it the A83T as for some reason I couldn't make the
> > > > > driver work.
> > > >=20
> > > > Do you have a link to that driver?=20
> > >=20
> > >  https://github.com/freebsd/freebsd/blob/master/sys/arm/allwinner/aw_=
thermal.c
> > >=20
> > > > How and how much did you test it?
> > >=20
> > >  Using a cheap IR thermometer as it's all I can afford.
> > >  Then running multiples cpufreq-a53 process and comparing the result.
> > >  Did the same without using the calibration data, result where closer
> > > when I used them.
> > >=20
> > > > Are you using the calibration data stored in the SID?
> > >=20
> > >  Yes, which is why the serie contain the nvmem cell for the SID.
> > >=20
> > > >=20
> > > > > I just hope that you understand that we cannot wait for Linux to
> > > > > have a driver to have some bindings.
> > > >=20
> > > > Just like I'm sure you can understand that just merging the DT bits
> > > > without testing anything caused some troubles in the past, and I do=
n't
> > > > want to discover it in a year from now.
> > >=20
> > >  I do, I don't like wrong DT info as much as you do I think. I had
> > > the unfortunate event to find that the sun4i-a10-timer compatible used
> > > in every soc is plain wrong for !A10 and !A13, patches comming soon.
> > >  I want those bits merged but I also want that they reflect reality,
> > > this is not a hard driver to do, NetBSD also have one I think, maybe
> > > OpenBSD do to.
> >=20
> >=20
> > I would prefer to see a series of DT bindings + driver. Can you send
> > your next iteration with the driver so we can review both together?
>=20
>  You mean a link to the FreeBSD driver (and OpenBSD since they have one
> too) in the cover letter ?

That would definitely be valuable, yes, thanks!
Maxime

--=20
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--q2hvfmvfl4mg43xk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAluGk8oACgkQ0rTAlCFN
r3QJ/g//a4mp6I3H6oWNN8cchbSP736FQREIQNC7B5qaGY3V55L9H/kuPfkyO+38
MhXGqr23P0HXsqeC3zLqr2xYXTevb0+0vVJCEamGSWu2jIywPm0ycNIS/9cLKHCb
2mKs6IjwecjVxsBrjTqY4u2ddLC0c0qpRdLUEOcBD4GE6piFdARUb0nRjN6nM7Gn
i+1/XDtNDvLNQLAyd5KGsRvp8R+veCU7hBSeyr9U/yBejNjqi0SCZjnk7wi7hTZ1
elyvWIX/kBnBoO84Z1M+IYgSrTH+s274pf6H1ocY+TnS67+LWaSTlWEmsOwpSiod
LpxFAg/rhTMMaxJzDaddeupsULqBiP8+RyclYzNv2jZOO5D5tBRlvUcVGNnINutl
d5oO7Xy+Ao7JdmK/mn9FBBdA5Bl0r8OUUmbTsd69pw+8Tm41jtW/cNOI0x9Y6XD9
vS2U0r3Nthnb7FIdGzBVch6N9oVnRRK4GUhyAogA0/0bfITkwheDQHoSn68DDAS2
qY/hfdamCoZk9EvjoVo/Gydz2I+b+ncq881aBd6zcvRkhaAx409ITQ1JbE44oWGL
oL/nQjeUvDucStlZEBTHpr9eU0Mii/CfF3TGmS4fuqOi/UhOmtEaKF2v43Z9wm6m
01mQ9dyBCJkEUcaech7tlnZVK/ApBi0PLPWhHhIjMWtYbdgyHVc=
=4od8
-----END PGP SIGNATURE-----

--q2hvfmvfl4mg43xk--