Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S263572AbTKDAiI (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 3 Nov 2003 19:38:08 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263579AbTKDAiI
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 3 Nov 2003 19:38:08 -0500
Received: from palrel10.hp.com ([156.153.255.245]:61836 "EHLO palrel10.hp.com")
	by vger.kernel.org with ESMTP id S263572AbTKDAh6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Nov 2003 19:37:58 -0500
Date: Mon, 3 Nov 2003 16:37:56 -0800
To: Martin Diehl <lists@mdiehl.de>
Cc: Stian Jordet <liste@jordet.nu>, Andrew Morton <akpm@osdl.org>,
       "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: Oops at "NET: Registering protocol family 23" at boot with 2.6.0t9-bk
Message-ID: <20031104003756.GA5537@bougret.hpl.hp.com>
Reply-To: jt@hpl.hp.com
References: <1067705386.666.1.camel@chevrolet.hybel> <Pine.LNX.4.44.0311021020200.29973-100000@notebook.home.mdiehl.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44.0311021020200.29973-100000@notebook.home.mdiehl.de>
User-Agent: Mutt/1.3.28i
Organisation: HP Labs Palo Alto
Address: HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA.
E-mail: jt@hpl.hp.com
From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1873
Lines: 56

On Tue, Nov 04, 2003 at 12:27:00AM +0100, Martin Diehl wrote:
> On Sat, 1 Nov 2003, Stian Jordet wrote:
> 
> > NET: Registered protocol family 23
> > Unable to handle kernel NULL pointer dereference at virtual address 00000004
> > EIP is at dev_add_pack+0x4d/0xb0
> 
> which is at "next->prev = new" in __list_add_rcu()
> 
> > Call Trace:
> >  [<c05defad>] irda_init+0x3d/0x60
> >  [<c05c094c>] do_initcalls+0x2c/0xa0
> >  [<c01359af>] init_workqueues+0xf/0x24
> >  [<c01050f6>] init+0x56/0x180
> >  [<c01050a0>] init+0x0/0x180
> >  [<c01072b9>] kernel_thread_helper+0x5/0xc
>  
> Looks like irda_init is called before the ptype_base[] list heads are 
> initialized. I believe it was triggered by:
> 
> >>>>>>>>>>
> diff -Nru a/net/core/dev.c b/net/core/dev.c
> --- a/net/core/dev.c	Wed Oct 29 15:08:14 2003
> +++ b/net/core/dev.c	Wed Oct 29 15:08:14 2003
> @@ -3023,7 +3023,7 @@
>  	return rc;
>  }
>  
> -subsys_initcall(net_dev_init);
> +fs_initcall(net_dev_init);
> <<<<<<<<<<
>  
> from: cset-akpm@osdl.org|ChangeSet|20031029192849|64746.txt
> 
> As a workaround you might want to make the irda modular instead of 
> build-in. But I'm just wondering why other protocols shouldn't have the 
> same problem. Maybe they are not subsys_initcall like af_irda.
> 
> Martin

	Networking as a filesystem, that's new to me. And then, we
need irda up strictly before the drivers, so I would need to move irda
to fs_initcall(). Grrr....

	I'm in serious need of catching up. Martin, you sent me
previously two important crasher fixes, one for IrCOMM and one for
sir-dev. And I have my IrNET Oops fix. Anything else ?

	Regards,

	Jean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/