Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 29 Aug 2018 10:54:40 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Stephane Eranian <eranian@google.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC] perf script: callchain handling is not useful
Message-ID: <20180829135440.GA25381@kernel.org>
References: <CABPqkBTT-PSP+0sZc-EyrRtOLfLVPxOxwuDpxhGhGZLOe5L0CA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABPqkBTT-PSP+0sZc-EyrRtOLfLVPxOxwuDpxhGhGZLOe5L0CA@mail.gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Tue, Aug 28, 2018 at 07:41:31PM -0700, Stephane Eranian escreveu:
> Hi,
> 
> I am doing the following simple collection with callchain and load profiling:
> 
> $ perf record -g -d -e cpu/event=0xd0,umask=0x81/pp  my_test_program
> 
> But when I type:
> $ perf script -F ip,addr
> ffff9d4821346878
>         ffffffff9d58df25
>         ffffffff9d58e054
>         ffffffff9d5965bb
>         ffffffff9d640650
>         ffffffff9d697d06
>         ffffffff9d63ec60
>         ffffffff9d640322
>         ffffffff9d64070c
>         ffffffff9d455a60
>                   7030c7
> 
> ffff9d4638ba84a0
>         ffffffff9d5df447
>         ffffffff9d5eaf4a
>         ffffffff9d63e165
>         ffffffff9d63e439
>         ffffffff9d697d98
>         ffffffff9d63ec60
>         ffffffff9d640322
>         ffffffff9d64070c
>         ffffffff9d455a60
>                   7030c7
> I also see the callchain and it is not clear which is the IP. Further
> more parsing becomes more difficult because of multiple lines per
> sample. I understand that multiline is likely because of
> symbolization. But if I don't want symbolization, it should be
> possible to print all in one line.

Humm, to have this not break possibly existing scripts, perhaps we can
have something like:

  $ perf script -F ip,-callchain,addr

?

And if asked explicitely for the callchain, then it gets added in the
same line?

- Arnaldo


> The current output is not very useful. You expect perf script to give
> you one line per sample and only what you want. Callchain != IP.
> 
> I think the following should happen:
>   - do not print callchain when asked for the IP. Create a callchain filter.
>   - print callchain on the same line, much like what is done for brstack
> 
> It is not clear to me why callchain and ip were lumped together.
> Any opinion on my proposal?
> Thanks.