Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp575149imm; Wed, 29 Aug 2018 07:05:22 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbaLlANMWyhhpa1/6+etEIMYe4PjZNFtBAQuCxVtlVimmJZPClUYpK6Milue21A4a931pdD X-Received: by 2002:a63:e841:: with SMTP id a1-v6mr5823725pgk.126.1535551522325; Wed, 29 Aug 2018 07:05:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535551522; cv=none; d=google.com; s=arc-20160816; b=dniPAlZV7T7OLzeZM0/dB1Z+u4CSnaF6INdwmBgt6F3fV3mY6sr8E8WIFsGMhOAdQB lizT7fnYeoRmtC66NqKtq2fYxVVqoDW54EpgRawYEFn4041B3UM/WVBEW1oHoD7g5EfT 44B2nUUtHmjemxYYQ4Ji8VowoAHxj2PzT6pMTHl4NRlKDr1MfYlgL/BJdiaKzQdmRo7j 2uXYueYXpb0D7cVYadVOHKbMsMgNK1EN3CfvRlO3HiT452xxiQrx6V3Kj+SXQo89ZgAa 4QIv4wiIejSrmpKjo5Tib3UeomP24kMQSBY/dbcP1nWzVqpYICzvfdgQ2COT/2faq+oF yzbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=niFlAg978/cG3aKriwxHa3PJfLick0FP6+ZwOoBkEnc=; b=RdWG11r09tKaYhQvFd/jTe1/c+5F0wkikol3MBv3E2b+yK/aF8UTjAbJs6QCCMg5HJ H3/npV/IvQ8rR5wuZDauqMhwTwwbPv5HLm1bsd8B4e8i2qVjzsittkSS94gCZY43oBKf k2vE33bS8W7SttHgTng+G0C8US/ZkqKIGoIxO34ux2oavGEuupioDybCeDvYQ47AEKZj eotET6/x0LL+t+KJg7P5eX+iRP7GOYVBJIzFsDEAuSvnLpuCmnuxsabeJqmECXGWhfKf /wd3gLFAEbhGedMrBUTVogtdHxaw5wY5pLZzGifvztX9Aji79JifPRwbSLPDwUvMw2Tx KiQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PuDNub3B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5-v6si834714pgi.211.2018.08.29.07.05.06; Wed, 29 Aug 2018 07:05:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PuDNub3B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728399AbeH2SAw (ORCPT + 99 others); Wed, 29 Aug 2018 14:00:52 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:46200 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727642AbeH2SAv (ORCPT ); Wed, 29 Aug 2018 14:00:51 -0400 Received: by mail-io0-f196.google.com with SMTP id y12-v6so4556977ioj.13 for ; Wed, 29 Aug 2018 07:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=niFlAg978/cG3aKriwxHa3PJfLick0FP6+ZwOoBkEnc=; b=PuDNub3B78CmP/8LZvYVuN6OArQF4o/5PK77Dj8iTS5sABXLMC3p2WqX9dFal1cq4+ ALChYygGs5zg9+hlWgc+wH9C10MQfxjzMidy4fsYZ1cBeFcOOAuh5UNHbonDRJHeRdeq d3kMmoUQ3w2HVt9bvvzeR4tqGSGNYsBPOslTg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=niFlAg978/cG3aKriwxHa3PJfLick0FP6+ZwOoBkEnc=; b=JqnHX3GPucqVC99GfhBQQzku+xXfkMrwwmaPq2kI34rgVY4BYC3J7v1+kaxJL/xXPV An2osxhIRZjdWRFYwtF5E6wWodypWwTwXDr3H+TLbtMFn+4IIqSewfHRCzVNNvjmeeS1 TkxDmTW4rVx8EmIKlIF5nPeSR9bXJPdRCxrR4ajOaPoJ6nlDAeyKBhrTXGGwQ43/f0ua UtE+4nzxJfIa3eni+lsNiXLJLrTj13QaREJBHCIN7QNKh/YYRCTWogbja+Zy4pzeXK7+ owH252ABxBy4aoIQ9CUXgVAnCCRvFzl3zbGHhmvnrGMRoJnE+y+MJephr33t3GAQfDoJ mxgg== X-Gm-Message-State: APzg51Dqf1IyWmHERtlxqM7mk5u0VBjPk57sy5vqddQ7BqUiJPBXY4O8 9YfS7jl5ldu8CpDC0sB3MzRwR8I2Wujis+1Fn/53xg== X-Received: by 2002:a6b:7f0c:: with SMTP id l12-v6mr5224376ioq.16.1535551425405; Wed, 29 Aug 2018 07:03:45 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:c046:0:0:0:0:0 with HTTP; Wed, 29 Aug 2018 07:03:44 -0700 (PDT) In-Reply-To: <20180829063347.GB32392@infradead.org> References: <20180828142421.15335-1-semen.protsenko@linaro.org> <20180828142421.15335-2-semen.protsenko@linaro.org> <20180829063347.GB32392@infradead.org> From: Sam Protsenko Date: Wed, 29 Aug 2018 17:03:44 +0300 Message-ID: Subject: Re: [PATCH 1/2] codafs: Fix build using bare-metal toolchain To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, codalist@coda.cs.cmu.edu, coda@cs.cmu.edu, Jan Harkes , "James E.J. Bottomley" , "Martin K. Petersen" , Praneeth Bajjuri , Paul Sokolovsky , Miklos Szeredi , Sumit Semwal , Ruslan Bilovol , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 29, 2018 at 9:33 AM, Christoph Hellwig wrote: > Please just drop the ifdef entirely. The file is part of the kernel > tree and can't be used for anything non-Linux. I have better idea :) We can modify include/linux/coda.h instead, by checking for __KERNEL__ (along with existing check for __linux__). This way we can leave user-space API header alone. Don't know how come I didn't notice that in the first place... Anyway, will send v2 shortly. Thanks for the review.