Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp607104imm; Wed, 29 Aug 2018 07:48:30 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYF3/W5fBbkPyTeNZPDE8PbBomzJlQmIBPQJQWWATYUVBDBDSizHuOk2NI/kXgBjSbtI4pD X-Received: by 2002:a62:6948:: with SMTP id e69-v6mr6316782pfc.166.1535554110159; Wed, 29 Aug 2018 07:48:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535554110; cv=none; d=google.com; s=arc-20160816; b=lV2ErkQU/3+UNrfjiv3xJGwDPRh8u/dcIdd30jrdKctyKo6842cmu57xYhC5OOZqMi nOOVyGbOU25xZg1mqaeuY6P+9Mu2o2RQ0nbm347G13JHGDgtyrUN1Es4CB62XwNdlpWr mqvdFoPNyJ+r5JmYQS2Dq1FRf2KyO3eGOOGNj2BZ0/hgiW48xXPCQ1JE8mCiPKSZ+QMx t96RDRoJIIQyVO60PiCeW4ZoWFPvcmw/9F4RRPeQE47c2DR2tHBmzulFyZ1phvnum9Oc fN8yljefPYri5WvSV3gfNBRNoH33cw4seNF3AlkUrn/kmBb1uVXiskRolcfFqLMkCq6Z 0Mcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=l8l5x/t8v80b5Rfs/+vLVWm5KDBloyNx8/lAVgGDoSs=; b=ITIVzILSO5NeyJsuvJ0u0yd7Kxx9JWkEcJk/4USX4TnMCYmKOtVKN8/4LGhCCC1+0i DweFBHy9CgzAf0wk3Y7a09CLyPE9Qg140XH1qnRFKc7vjtnIJLrK85XXv4DxCiWYPIXO v1YlvT24EpzIzuco4dTT8FsfTva+aKahmmZSEERJg7ezro3DuA1Oxrc6O0/qTQlnA+IV M+HHDRqsdlwxqjQ/Al2tZSZgrQD4MXX1LujjqaVl05dQbdtaWc/6Qv+g0MCIL6oJxbb4 4KiD9Pj4E8ODMzHmU30XwM57gEeN9M8A2QUUM1ptmITXh2kAxz2rtAdZHGPd2FdmJS1m /U5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w65-v6si3909303pgb.476.2018.08.29.07.48.14; Wed, 29 Aug 2018 07:48:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728902AbeH2Snq (ORCPT + 99 others); Wed, 29 Aug 2018 14:43:46 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35659 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727204AbeH2Snp (ORCPT ); Wed, 29 Aug 2018 14:43:45 -0400 Received: by mail-wm0-f65.google.com with SMTP id o18-v6so5859796wmc.0 for ; Wed, 29 Aug 2018 07:46:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=l8l5x/t8v80b5Rfs/+vLVWm5KDBloyNx8/lAVgGDoSs=; b=PiWYDDml6qzPZrc0xYLKU4jOpLBZadX0ea6BXk1Ibf+WrwoCxo8UPbzABfS/U2GfJm JoFtTpABeNcZBB+zOQkOMTLE7gO6Yxhy/r4vWuz/O1qNlDjtt0B7oZNTWs3zBRJU70OP +18ztTo2k+0PUqqu5J7S7J7rcZ7T3ZqLsk9OSKqQRfWIl+gFc3Zh2WZHBpsYKP45ohl1 y32uoRA4+im6EFFx9S84Y7tw78WhkAO9wL287K43i2FvicYptCNdAjfvEWeUhkR/eSrk cyU7J9wTXfdVpDB4ITF8c5IViv4k7dmimNEhWkut2P54hHUVzDXQ+gwOm7GrB4ztQ3qk Awgw== X-Gm-Message-State: APzg51AJ13e8Dxr/Fulk1zf8zXenUKO8mBCxLbwycQrpBqKvzeqyz65K AnoWioI7+qHaHgK6Nzfuvtk= X-Received: by 2002:a1c:f60c:: with SMTP id w12-v6mr4341167wmc.80.1535553986952; Wed, 29 Aug 2018 07:46:26 -0700 (PDT) Received: from ?IPv6:2a01:4240:2e27:ad85:aaaa::70f? ([2a01:4240:2e27:ad85:aaaa::70f]) by smtp.gmail.com with ESMTPSA id z10-v6sm4079266wrv.22.2018.08.29.07.46.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 07:46:26 -0700 (PDT) Subject: Re: [PATCH 3/4] tty: Lock tty pair in tty_init_dev() To: Dmitry Safonov , linux-kernel@vger.kernel.org Cc: Daniel Axtens , Dmitry Safonov <0x7f454c46@gmail.com>, Sergey Senozhatsky , Dmitry Vyukov , Tan Xiaojun , Peter Hurley , =?UTF-8?B?UGFzaSBLw6Rya2vDpGluZW4=?= , Greg Kroah-Hartman , Michael Neuling , Mikulas Patocka References: <20180829022353.23568-1-dima@arista.com> <20180829022353.23568-4-dima@arista.com> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSBKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAZ21haWwuY29tPsLBewQTAQIAJQIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AFAk6S6P4CGQEACgkQvSWxBAa0cEl1Sg//UMXp//d4lP57onXMC2y8gafT1ap/xuss IvXR+3jSdJCHRaUFTPY2hN0ahCAyBQq8puUa6zaXco5jIzsVjLGVfO/s9qmvBTKw9aP6eTU7 77RLssLlQYhRzh7vapRRp4xDBLvBGBv9uvWORx6dtRjh+e0J0nKKce8VEY+jiXv1NipWf+RV vg1gVbAjBnT+5RbJYtIDhogyuBFg14ECKgvy1Do6tg9Hr/kU4ta6ZBEUTh18Io7f0vr1Mlh4 yl2ytuUNymUlkA/ExBNtOhOJq/B087SmGwSLmCRoo5VcRIYK29dLeX6BzDnmBG+mRE63IrKD kf/ZCIwZ7cSbZaGo+gqoEpIqu5spIe3n3JLZQGnF45MR+TfdAUxNQ4F1TrjWyg5Fo30blYYU z6+5tQbaDoBbcSEV9bDt6UOhCx033TrdToMLpee6bUAKehsUctBlfYXZP2huZ5gJxjINRnlI gKTATBAXF+7vMhgyZ9h7eARG6LOdVRwhIFUMGbRCCMXrLLnQf6oAHyVnsZU1+JWANGFBjsyy fRP2+d8TrlhzN9FoIGYiKjATR9CpJZoELFuKLfKOBsc7DfEBpsdusLT0vlzR6JaGae78Od5+ ljzt88OGNyjCRIb6Vso0IqEavtGOcYG8R5gPhMV9n9/bCIVqM5KWJf/4mRaySZp7kcHyJSb0 O6nOwU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02 XFTIt4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P +nJWYIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYV nZAKDiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNe LuS8f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+B avGQ8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUF Bqgk3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpo tgK4/57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPD GHo739Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBK HQxz1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkF Ak6S54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH /1ldwRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+ Kzdr90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj 9YLxjhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbc ezWIwZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+d yTKLwLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330m kR4gW6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/ tJ98f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCu jlYQDFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmf faK/S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= Message-ID: <22935dc9-a9fe-5fc8-4c97-3f5c7b07b8c3@suse.cz> Date: Wed, 29 Aug 2018 16:46:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180829022353.23568-4-dima@arista.com> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/29/2018, 04:23 AM, Dmitry Safonov wrote: > It's safe to not lock both here - done to silence attempt lockdep assert in > tty_ldisc_open(), which will be added with following patch. SOrry, could you elaborate here? I don't follow... thanks, -- js suse labs