Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp42095imm; Wed, 29 Aug 2018 13:25:05 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaMxkGy1XkSmFIdEnKH5gWiIx5Z5HsIzDMCK49V0SXuUnetmTKvKrd7Ce2FkJMRxivEbDfL X-Received: by 2002:a62:1bc2:: with SMTP id b185-v6mr7467583pfb.170.1535574305018; Wed, 29 Aug 2018 13:25:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535574304; cv=none; d=google.com; s=arc-20160816; b=YHTwl68cEl0D04VPo7JAmZ9s+1P+RUInUxYqYN0Bum21XVh81QU8LfQHe0318mrZ/n mdD8cXoqx4xFj2NUu8T98VsOgJ2yna/3NcBF5XXzI7hE0/GCaLpE2oSDmjzBUs7hErOu XoBBmUzx82E5svE9gganll3nMks0jPx4qVdLj95Auz/b46EUCTcdCojBS5GP7K/eEynJ NFo8Ae4g/EECn4Oyfd6OIyX9hIgdZIXuj/Ld/kJQF6a1L7G7Bhv2uRA639NTPgm3Jftj G7IR4MR32VS6G50OD8NoqwhhbEvAbSsi4AFWYp7Z3fL/lUiWbVIDyRqSQw86XU0w5nDF NMAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=laDqaM9wJs34Pr/0ik7GXtoQx0sblUxPifyxOlR3zcs=; b=qUXDyFYLWFUl9uYAz9NRiB6t6ijNOkk2j7E+LA7IW0kTnT+wKLLmJqp/AdoXwprjKD gyDWSFOJb1uHNpbA/N3h5CcGGbF3VvLGFaE4O5Cx8rBd1g929ZwdqYinAZggsMEjuIh4 p8xDUikP/hRyQ9c6gEYDvsmZSFoyjCIULYCfmOQyPgHd/b8HIUZCUcJ3pUvYChOFQwUx Ef7Rm6/x78TQx6J27y7SOWKnXpQH9f21oxoKYwOCeg5WZ531vmtCotU/IPplsOHS2/cx HBsYU97fMJtp1175X5An1omwO+vF0n2UqXyZYYkeYRi5bNZwluGdj3H5swVB3trGNJV3 dV/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=efficios.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d27-v6si4752150pgd.223.2018.08.29.13.24.47; Wed, 29 Aug 2018 13:25:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbeH3AV5 (ORCPT + 99 others); Wed, 29 Aug 2018 20:21:57 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:36765 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727444AbeH3AV5 (ORCPT ); Wed, 29 Aug 2018 20:21:57 -0400 Received: by mail-qk0-f194.google.com with SMTP id 93-v6so4288826qks.3 for ; Wed, 29 Aug 2018 13:23:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=laDqaM9wJs34Pr/0ik7GXtoQx0sblUxPifyxOlR3zcs=; b=RGXRdTPIXUsigceQpwppnHMy8HS/zUtwV0MHYuPObc4O90DccrRlyhz7pEqyybAbhP 1BNvtJCG0mxVAJO7YlPCROjGBQvqCqSye1B6vwkTE4CSllYHiRzGpahyYfortUjpVrrt bIhE58aP0ZvVx/evfhmYx7EBT/HoGJgGrB8sEJ9lHlz71LWhTj+QqySr2pUGrDyfwc8s DpUNryCTjc+gYEVn/jaXk29tsaWE1yuWIFE++KKOdm3vL6SxMr8G4oyrfXlFdvngwyRz tlhQ0tN7khLd+tEyt04MPr4Vd04EN66LyEof0Cpj1wdjquTqj5GxYPrCN1KpcneGOCbW H8bA== X-Gm-Message-State: APzg51CA3j9QJit4l+VcOJMUMCpScK6c/WJLMVxhtkXfRqlzZfsLxw/q s8jBi1K/9+U8Ml1wpVOzqH0QgL/L X-Received: by 2002:a37:944:: with SMTP id 65-v6mr8167233qkj.45.1535573821556; Wed, 29 Aug 2018 13:17:01 -0700 (PDT) Received: from localhost (192-222-171-48.qc.cable.ebox.net. [192.222.171.48]) by smtp.gmail.com with ESMTPSA id v10-v6sm3228609qtv.77.2018.08.29.13.17.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 13:17:00 -0700 (PDT) From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Galarneau?= To: linux-kernel@vger.kernel.org Cc: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Galarneau?= , Jiri Olsa , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Alexander Shishkin Subject: [PATCH] perf tools: Initialize perf_data_file fd field Date: Wed, 29 Aug 2018 16:16:48 -0400 Message-Id: <20180829201648.19588-1-jeremie.galarneau@efficios.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building the perf CTF converter fails with gcc 4.8.4 on Ubuntu 14.04 with the following error: error: missing initializer for field ‘fd’ of ‘struct perf_data_file’ [-Werror=missing-field-initializers] Per 4b838b0d and the ensuing discussion on the mailing list, it appears that this affects other distributions and gcc versions. Signed-off-by: Jérémie Galarneau Cc: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Alexander Shishkin --- tools/perf/util/data-convert-bt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c index abd38abf1d91..f75d4aa612c5 100644 --- a/tools/perf/util/data-convert-bt.c +++ b/tools/perf/util/data-convert-bt.c @@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path, { struct perf_session *session; struct perf_data data = { - .file.path = input, + .file = { .path = input, .fd = -1 }, .mode = PERF_DATA_MODE_READ, .force = opts->force, }; -- 2.18.0