Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp50331imm; Wed, 29 Aug 2018 13:39:19 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaXm93eNJ0dfWbZ6jeIz1VE2QFrEd/3CjRY0NcbLYf/BTcPDvZzFfX5UboAdfptPzCDaQWH X-Received: by 2002:a63:10c:: with SMTP id 12-v6mr6939811pgb.62.1535575159920; Wed, 29 Aug 2018 13:39:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535575159; cv=none; d=google.com; s=arc-20160816; b=VkAJRaUxK/qtBPWtfpSQofL/Z7/nTqgUdHiqud3R5pZy1aEdqiGpgYv+AVx2LQY3Ui RfWozKH7d4XcgLrE0xn6o9cAXq21i4cS6LDSF5sFtl33Ftf5wOe7LAzVKco77Q8mzycq 250mLtpgZ4djk2ehTAlmn+D3vwgfixyxqSxQIoqAaDrFsFUqdQnYwrt+GKeHkzZUEVtb qZtP+2QpvSuBEjR2dfxQ7cAM2/cyWGk2y8ww56wYseA7U6yy3OvW4PdgLhdbpQNZ0RQ7 3m0pkE7mETlmK/YVWT/Uk8DrhK+P2ivLsagLdDTQJrqdb5ENBthdAWdn6YDf2hHRv8ff j8pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=55YwVY90eBG5KFtaoLEWS3jaom0WReVRI//+l3Cts7M=; b=UVtf05kWxSoywgZyl10MyTO6AvOeFZlgmKPzA+UeWb3M0jvnz5CBrX9m0O8Itec4u7 R6KfMJN/VmAAv0Cp3eBSf4ERr5HUI6OMaeCCcC2EciyjYl3sS4jvshzNYI3pmh3IQbkK fNwPkambCD3JsDcxT3JCMvQRH2ZSlY/s+vu2BZvOTTafaEl3ywfY8NOiHqjzEtwvs544 yswLpmwlKJ3imPHzUwwcLb5x2VMUT+8Vrwkw1h9yOLOuCZ5Q9VK2iCu/l8bxZAKTUk7l khH+ICDkLptUadNMK/6IId/JivjRwDgP6EVNiQ1SM6GD9xx3/KkIvq1qFzOV8IRZnL6H 68xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=U2YrEoQs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t8-v6si4447571plz.126.2018.08.29.13.39.05; Wed, 29 Aug 2018 13:39:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=U2YrEoQs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729300AbeH3AgC (ORCPT + 99 others); Wed, 29 Aug 2018 20:36:02 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:56311 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728883AbeH3Aen (ORCPT ); Wed, 29 Aug 2018 20:34:43 -0400 Received: by mail-wm0-f67.google.com with SMTP id f21-v6so6535444wmc.5 for ; Wed, 29 Aug 2018 13:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=55YwVY90eBG5KFtaoLEWS3jaom0WReVRI//+l3Cts7M=; b=U2YrEoQsDaZo8PsDx7w56PTqJEMun36A1KZbtguksfAwzjwYByTjSSuzFVms6x6P4u 69BvNbrv1qvT/ZNHlqaARoOBmEcR9nobNyVYCr/jaq4ZqUA1JIUhGi/Niiewekxjs5Ad nrB4L4jkeNm/2b7I24RA+AhXxW7zmLkO9OG5rd+/cxRg5OD1zM1tOJD+l0hM3OOYQRpG MgcuoDYqXNOH8Qn1KA9kfXxLtL+dtkEz40Xz5jsM1pQ5efTCHZOov1lKdM0ZY02P5fEH NJKtPqN52DrqwlAXaqbsp6vgU5ne9W/TspuuDDznznIPT9UQBmgxdwRPLSvBlw9As0bx 3/1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=55YwVY90eBG5KFtaoLEWS3jaom0WReVRI//+l3Cts7M=; b=LgUZT9/WhJL4KQoc33fbaukPBRg8QodoFUnVn5E9HHcpSN1bqZKvPITb5Q8wlTQKZh mfgwspZab8xDNsDiWcQXClDlXhLHz5ohNSaaCGIrGVRl3M842kt1CNI6X0bD+7sqbYbR EyjEsO1yiwHymA0VR1Eu5RwRHoMh0AEeBmsfgIBuYtGk80YfXggMbVRfB0j2gy6lZk3g EOg9Xbnq0gVJuikcQTPClIh67jQM3QLGi/r/bHvyTFuYB/dpTFi8utMdBif3mymY8HhN FLkM1cWw+LLZcNLcDxmhDx1ivBar5A0MF3MoJkr2FJr66gcN/2Ea88rE4RKUtPuoUpZz KBCw== X-Gm-Message-State: APzg51B0/NzVM5zWM86yVo6qkrl6mTIN4fVX8puZ4JdBf2cXnbKXVSxt a1XS/YOb+Q/A5x4M72/tPzN5hNlxPGs= X-Received: by 2002:a1c:ca17:: with SMTP id a23-v6mr4881943wmg.122.1535574967929; Wed, 29 Aug 2018 13:36:07 -0700 (PDT) Received: from localhost.localdomain (host86-148-21-150.range86-148.btcentralplus.com. [86.148.21.150]) by smtp.gmail.com with ESMTPSA id e133-v6sm10625519wma.33.2018.08.29.13.36.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 13:36:07 -0700 (PDT) From: John Whitmore To: linux-kernel@vger.kernel.org Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, John Whitmore Subject: [PATCH 07/21] staging:rtl8192u: Rename TxSTBC - Style Date: Wed, 29 Aug 2018 21:35:33 +0100 Message-Id: <20180829203547.15650-8-johnfwhitmore@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180829203547.15650-1-johnfwhitmore@gmail.com> References: <20180829203547.15650-1-johnfwhitmore@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rename the bitfield member TxSTBC. As it stands the name causes a checkpatch issue due to its use of CamelCase naming style. Because the member is not actually used in the code the name has been changed to 'not_used_tx_stbc'. The two lines of code, one for initialisation and one for debug logging have been removed. This is a coding style change which should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h index 23f8ee39e32d..ab61c9e81c2c 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h @@ -45,7 +45,7 @@ struct ht_capability_ele { u8 not_used_green_field:1; u8 short_gi20_mhz:1; u8 short_gi40_mhz:1; - u8 TxSTBC:1; + u8 not_used_tx_stbc:1; u8 RxSTBC:2; u8 DelayBA:1; u8 MaxAMSDUSize:1; diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 54c56cec612f..65c377094278 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c @@ -145,7 +145,6 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString) IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupported Channel Width = %s\n", (pCapELE->chl_width) ? "20MHz" : "20/40MHz"); IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupport Short GI for 20M = %s\n", (pCapELE->short_gi20_mhz) ? "YES" : "NO"); IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupport Short GI for 40M = %s\n", (pCapELE->short_gi40_mhz) ? "YES" : "NO"); - IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupport TX STBC = %s\n", (pCapELE->TxSTBC) ? "YES" : "NO"); IEEE80211_DEBUG(IEEE80211_DL_HT, "\tMax AMSDU Size = %s\n", (pCapELE->MaxAMSDUSize) ? "3839" : "7935"); IEEE80211_DEBUG(IEEE80211_DL_HT, "\tSupport CCK in 20/40 mode = %s\n", (pCapELE->DssCCk) ? "YES" : "NO"); IEEE80211_DEBUG(IEEE80211_DL_HT, "\tMax AMPDU Factor = %d\n", pCapELE->MaxRxAMPDUFactor); @@ -561,7 +560,6 @@ void HTConstructCapabilityElement(struct ieee80211_device *ieee, u8 *posHTCap, u pCapELE->short_gi40_mhz = 1; // We can receive Short GI!! //DbgPrint("TX HT cap/info ele BW=%d SG20=%d SG40=%d\n\r", //pCapELE->chl_width, pCapELE->short_gi20_mhz, pCapELE->short_gi40_mhz); - pCapELE->TxSTBC = 1; pCapELE->RxSTBC = 0; pCapELE->DelayBA = 0; // Do not support now!! pCapELE->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0; -- 2.18.0