Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style
To:     Joe Perches <joe@perches.com>,
        John Whitmore <johnfwhitmore@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     devel@driverdev.osuosl.org, gregkh@linuxfoundation.org
References: <20180829203547.15650-1-johnfwhitmore@gmail.com>
 <20180829203547.15650-2-johnfwhitmore@gmail.com>
 <b621a12258c3f0d0a9fcb61ac454af4822814e67.camel@perches.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <e302edd8-4b00-8c28-8375-2a781877f019@lwfinger.net>
Date:   Wed, 29 Aug 2018 16:21:54 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <b621a12258c3f0d0a9fcb61ac454af4822814e67.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/29/2018 04:14 PM, Joe Perches wrote:
> On Wed, 2018-08-29 at 21:35 +0100, John Whitmore wrote:
>> Rename the bit field element AdvCoding, as it causes a checkpatch issue
>> with CamelCase naming. As the element is not actually used in code it
>> has been renamed to 'not_used_adv_coding'.
>>
>> The single line of code which initialises the bit has been removed,
>> as the  field is unused.
>>
>> This is a purely coding style change which should have no impact
>> on runtime code execution.
> 
> Hi John.
> 
> Other than the somewhat useful code style cleanups, is there
> a point at which you will feel comfortable doing actual code
> changes to this driver?
> 
> Perhaps support for the chipset could be converted to use
> mac80211 and moved into the directory with the other realtek
> drivers in drivers/net/wireless/realtek/rtl8xxxu/...
> 
> Larry?  What do you think?

First of all, if a variable is not used, then it should be removed, not merely 
renamed to satisfy checkpatch.

All the Realtek USB devices should be added to rtl8xxxu, not merely moved into 
that directory. Jes Sorensen created a well-designed driver the is structured to 
permit addition of different initialization routines, etc. That said, the 
conversion will not be easy. In addition, it will require having your hands on a 
real device - a requirement that I cannot meet for the RTL8192U.

Larry