Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp90199imm; Wed, 29 Aug 2018 14:51:20 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbfQQ64AFJ69grV77aKTIoSbG8DLjtVtEZGepNFPSIQVVgRJzz3JKOVpev4jdB/FfH+Jrrv X-Received: by 2002:a63:2d05:: with SMTP id t5-v6mr7160595pgt.403.1535579480523; Wed, 29 Aug 2018 14:51:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535579480; cv=none; d=google.com; s=arc-20160816; b=rrrPkOtUdsJe1D/k82CR8rWdb14+/rfH4nGVAGFFHkC/913wDQewY9IdkVOPS3AW6u tA3W6t6+ErDeBCEnoWAL5qMinpDQ+Zka3rcnE1fESqfw2HFiL1L1a9CW8SPq/6t5ap6I OTffbYngoC2r7qidBf14ANWctM8n1t37tLhC4kypyjUjuuxgPozh0Y52SQz/L6Efy0Iu 9GuHnffU6Ex0RfYLUaPXpAAJ0YhHMR97jvz4fMyfwSNtRkgQezYHOkBCExoJgVti8Mx3 smadeucwDFqvrBonGJXWhE4+tqsRPJgAfUTSbmXIzog42RZYoRWzZfc2uNC+KW3XVsuE 8cBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=gWcJ+qz1p7IVQJl5B9X61xQfPm8uYvpnvZpR7B/ICkQ=; b=PpPmVu6ECXJ5rl6p8iyl/Jzp2PCvyJmaOFENKG8oDZ51cbwrF+CV909S/5jXowFLoz dObrc7LeN3kya1sGxKcD+s24wp4+sfHF3K0NgUU+sPEmyCVhocYq20z7tKccYy5d+v4b XHh1P30r0N5pYsrG55d+RAR25XL0flXn0RYqbdEXoMru1awH7QmuXeSyk/pzyLDegDQL itQcdcNENNMRYglm3yrsqbHYgsp0aM7xyb7ZwRCodx57vfYj77M99gPcmuQ9e8q6/GdY kwL/G+aAzljM42Zb9F5ggM8C/Qg7ddxc0ILFjpwhH5GzDgK6Fg5UZ2hVtKjORlv6xpqJ H8NQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t191-v6si4492010pgc.481.2018.08.29.14.51.05; Wed, 29 Aug 2018 14:51:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727679AbeH3Br7 (ORCPT + 99 others); Wed, 29 Aug 2018 21:47:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44950 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727294AbeH3Bqu (ORCPT ); Wed, 29 Aug 2018 21:46:50 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7TLcr1v138121 for ; Wed, 29 Aug 2018 17:47:58 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0b-001b2d01.pphosted.com with ESMTP id 2m629dtykw-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 29 Aug 2018 17:47:58 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 29 Aug 2018 17:47:57 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 29 Aug 2018 17:47:52 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7TLlpKS14876754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Aug 2018 21:47:51 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D0D9B206C; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2A6BFB2065; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 90CAC16C91C3; Wed, 29 Aug 2018 14:47:51 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" Subject: [PATCH tip/core/rcu 02/17] rcutorture: Force occasional reader waits Date: Wed, 29 Aug 2018 14:47:35 -0700 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829214722.GA23411@linux.vnet.ibm.com> References: <20180829214722.GA23411@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18082921-0040-0000-0000-0000046753F7 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009636; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01080727; UDB=6.00557487; IPR=6.00860713; MB=3.00023001; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-29 21:47:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18082921-0041-0000-0000-0000086E6DC6 Message-Id: <20180829214750.26972-2-paulmck@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-29_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808290211 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Deferred quiescent states can interact with the scheduler, but rcu_torture_reader() does not force such interaction all that frequently. This commit therefore blocks for one jiffy after ten jiffies of read-side runtime. This has the beneficial effect of being most likely to block just after long-running readers, and it is exactly these readers that are most likely to have been preempted (in CONFIG_PREEMPT=y kernels). This in turn helps increase the probability that a deferred quiescent state will be seen by RCU's context-switch hooks. Signed-off-by: Paul E. McKenney --- kernel/rcu/rcutorture.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index c596c6f1e457..50a4f0ed4ebf 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -1387,6 +1387,7 @@ static void rcu_torture_timer(struct timer_list *unused) static int rcu_torture_reader(void *arg) { + unsigned long lastsleep = jiffies; DEFINE_TORTURE_RANDOM(rand); struct timer_list t; @@ -1402,6 +1403,10 @@ rcu_torture_reader(void *arg) } if (!rcu_torture_one_read(&rand)) schedule_timeout_interruptible(HZ); + if (time_after(jiffies, lastsleep)) { + schedule_timeout_interruptible(1); + lastsleep = jiffies + 10; + } stutter_wait("rcu_torture_reader"); } while (!torture_must_stop()); if (irqreader && cur_ops->irq_capable) { -- 2.17.1