Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp90297imm; Wed, 29 Aug 2018 14:51:34 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYy4FaFrqUmmZiae1On+BiaIj+YBO110J4rHMMChPYqfDZdUaZF2QBIZJo67i3c19+fd9sj X-Received: by 2002:a17:902:2904:: with SMTP id g4-v6mr7374353plb.70.1535579494140; Wed, 29 Aug 2018 14:51:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535579494; cv=none; d=google.com; s=arc-20160816; b=V2xcH+e3AYt3/6OkovfjENCvJz/FhCxv9AjMeum/l/dibb+XRUXtKGrcJ2BzFxnFJr ol4+EC7NQeDNt+BRJLOeW2TOZfiRDUECC+oNjwLo4koFAeddpIBce+GOoOfs5+5t99XH 1ntaKr/5ikLg/PqTRmTK8KH97EcLP2VFP2P9vM2mvwVO6hHvcQuAtJRPv3v2BFwE/OvN DvJh1DFuRabickKcP7MGpOUXiXHc5lwaiagLJK3+oNFEEWwmTUMXM2I9qlTLh6O1NJwb IZdNDXtQoOVXfXMj2srYigpPQb8jO2rp0E9n//sglOrUuhAVdPueVLyP2wWgdudFfAo3 DXeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=m70CQVcH+6GzUy2TkfkaimxilhKut21iP0xSCEI/Mlg=; b=MVXL2WWqCR2SuphjUa7o7WxMBg1+409LhQNAltTROJad1Iz6M+65YtxA0x1cy4WBOt VyHFQ4n8librkGgz2BqDqHqQkGOVOmYWsWOIHckSGZSz1oD5OiRmOHURMA09MVNqtS08 4BsgppEjwbVjQozVgIkOz5JtlYsq6JYKZJ8ZoMFIXEkZC/6QV3r21ayLrIuaUpQvpqwB zDLpqaHtjTXdN2H2LzPAY6LLPY0x0jhGxWwPO/2mlajin7UkMyIpTvQPQVqMqOWM6a/i TmA64E7riTHioRhk6ZRQzTsz8lYOtZeFNflF7dK4t0WxyRYgld5Azo/5HiQ8CgPL7j4U 5OuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n190-v6si4677064pfn.358.2018.08.29.14.51.19; Wed, 29 Aug 2018 14:51:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727325AbeH3Bqt (ORCPT + 99 others); Wed, 29 Aug 2018 21:46:49 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57658 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727086AbeH3Bqt (ORCPT ); Wed, 29 Aug 2018 21:46:49 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7TLd58s074420 for ; Wed, 29 Aug 2018 17:47:57 -0400 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2m61x8buyn-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 29 Aug 2018 17:47:57 -0400 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 29 Aug 2018 17:47:56 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 29 Aug 2018 17:47:52 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7TLlpR725428186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Aug 2018 21:47:51 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56E3DB2068; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 34D84B206A; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 9C1B516C91C7; Wed, 29 Aug 2018 14:47:51 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" Subject: [PATCH tip/core/rcu 04/17] rcuperf: Warn on bad perf type for built-in tests Date: Wed, 29 Aug 2018 14:47:37 -0700 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829214722.GA23411@linux.vnet.ibm.com> References: <20180829214722.GA23411@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18082921-2213-0000-0000-000002E504A8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009636; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01080727; UDB=6.00557487; IPR=6.00860712; MB=3.00023001; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-29 21:47:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18082921-2214-0000-0000-00005B60154E Message-Id: <20180829214750.26972-4-paulmck@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-29_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808290211 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When running a built-in rcuperf test, specifying an invalid perf type results in what looks like a hard hang, with the error messages hidden by other boot-time output. This commit therefore executes a WARN_ON() in this case so that the splat appears just following the error messages. Signed-off-by: Paul E. McKenney --- kernel/rcu/rcuperf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c index 34244523550e..832ce68fd45f 100644 --- a/kernel/rcu/rcuperf.c +++ b/kernel/rcu/rcuperf.c @@ -680,6 +680,7 @@ rcu_perf_init(void) for (i = 0; i < ARRAY_SIZE(perf_ops); i++) pr_cont(" %s", perf_ops[i]->name); pr_cont("\n"); + WARN_ON(!IS_MODULE(CONFIG_RCU_PERF_TEST)); firsterr = -EINVAL; goto unwind; } -- 2.17.1