Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp90339imm; Wed, 29 Aug 2018 14:51:38 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZzubIcthpLNH96bocKIAYfTydJWAxi12RwoqqSHJb+3KTkbkzoeq1KcjZ5SSRDbSjchcah X-Received: by 2002:a17:902:5a4e:: with SMTP id f14-v6mr2063038plm.311.1535579497967; Wed, 29 Aug 2018 14:51:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535579497; cv=none; d=google.com; s=arc-20160816; b=RGbYVjcH+0lHV9Ua+R7BnZIVeTn8ufrHRqmJVQJX4hQ6Xg9dvoL6tvHenvtymmE3QH biARIyd/dH/nTspYUd2Nyzpz35TLJJWLvZ5+/WNxJfCZSXWsI6GDkabAPRS0HjFYt3Kd FI5kOks0UppZXEgGOSqJI/tbaW+bJQ5eK6bJreq58Y59ALPIPpyHqsSoeO0CVyoCLCxC 9H3oJKi6ATCIravaVqMYxnz1e/9Oc5xkQ+ssmUlZ+LOQtTrKhUTUn2IpbdsBLEAfhDBH A3oxb9aKb/aNE1liGUwBKj1KAuvRG2FcSxEr5SYWDmyX78aifXZLN74Kt93+34qNUNNu EWyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=cVu8EGW1TiY014939rYpq3dWa9ZSXnWdLjG389akI6k=; b=OVE3IvLOADd+MWlF4ZXSCZH39ET9MgcfXpzJox5uzemPnN8WUpeSK+UhuQNbQwu49M m4BvsZdAGeJ1Cm+2gR55MgXWQ4x1haRyimXXrcYrpyUrhXuQc8QbGZwelip8UOLg7vrs 97hey8gyLHq3sYa1YUIOrciUN0EBcz2099aamEnwchXE2NYby4k7/4Ef/u3zMeL1S7Dr 8fNpFRbHIH5IjivyqWDBekF0Geg+kTiW4u36xN60eijvPSaSGgvVB/lmSvK8solspb4s k8ZmIRUSfNkX6u7fo2fNHBMPpXplE4maAIo9Nqvp2ME+2ydaNEw4hcWltK6EaNwjXZY6 uIsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d26-v6si4860239pge.49.2018.08.29.14.51.23; Wed, 29 Aug 2018 14:51:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727711AbeH3BsM (ORCPT + 99 others); Wed, 29 Aug 2018 21:48:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44910 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727282AbeH3Bqt (ORCPT ); Wed, 29 Aug 2018 21:46:49 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7TLcraY138152 for ; Wed, 29 Aug 2018 17:47:57 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0b-001b2d01.pphosted.com with ESMTP id 2m629dtyka-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 29 Aug 2018 17:47:57 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 29 Aug 2018 17:47:56 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 29 Aug 2018 17:47:52 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7TLlpRM16253120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Aug 2018 21:47:51 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55AECB206E; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 332BFB2066; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 29 Aug 2018 17:46:47 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 95A8F16C91C6; Wed, 29 Aug 2018 14:47:51 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" Subject: [PATCH tip/core/rcu 03/17] rcutorture: Warn on bad torture type for built-in tests Date: Wed, 29 Aug 2018 14:47:36 -0700 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180829214722.GA23411@linux.vnet.ibm.com> References: <20180829214722.GA23411@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18082921-0072-0000-0000-000003996473 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009636; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01080727; UDB=6.00557487; IPR=6.00860713; MB=3.00023001; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-29 21:47:55 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18082921-0073-0000-0000-0000493E9ABF Message-Id: <20180829214750.26972-3-paulmck@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-29_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808290211 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When running a built-in rcutorture test, specifying an invalid torture type results in what looks like a hard hang, with the error messages hidden by other boot-time output. This commit therefore executes a WARN_ON() in this case so that the splat appears just following the error messages. Signed-off-by: Paul E. McKenney --- kernel/rcu/rcutorture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 50a4f0ed4ebf..5df2411f7aee 100644 --- a/kernel/rcu/rcutorture.c +++ b/kernel/rcu/rcutorture.c @@ -1968,6 +1968,7 @@ rcu_torture_init(void) for (i = 0; i < ARRAY_SIZE(torture_ops); i++) pr_cont(" %s", torture_ops[i]->name); pr_cont("\n"); + WARN_ON(!IS_MODULE(CONFIG_RCU_TORTURE_TEST)); firsterr = -EINVAL; goto unwind; } -- 2.17.1