Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp182969imm; Wed, 29 Aug 2018 17:50:05 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbI6E6UzJCLhZUvYjS13OkEBrLQ5V6U3ompJmyXTRKVdi7BC12IiN3FPTvFEcmh90SaF7c7 X-Received: by 2002:a63:1125:: with SMTP id g37-v6mr7584694pgl.187.1535590205538; Wed, 29 Aug 2018 17:50:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535590205; cv=none; d=google.com; s=arc-20160816; b=CJbtyfVtbBlbC2TX7NbmFGIZAqgOQWXxic2PF+cjyzHLSliaFX9TYm2ZvMY5YQvH/x 4eD7ouVDleTkDFyXYR6jx8lvqIbIECEs3BLAr6O7QPlTt3s4uGXoD6MzyFFA+8Ik0kJv K0T/2n9fxtfQSzE4Sb2uPIR9OSzDr3eJbGJM0y77TidTEwQUefRTetjRu78xUElRE4Kh wMocgM23VMMDrhzgE77YEcPQ306S1xme47D7WhoH73DkzCMhh4URy+AZ5s9ELLbPGLR+ fobDONjnLpANzvp7XlZA884PAemuKkpCMz12iVN86SZwLyPNmF2K6Jeb1CFTLsWL5B2Z RN+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=hzurL3xE2HWGFlhXpaDyyGhh5VqWJGH2wQUn6lPczVQ=; b=Z2KescjrFbzDYrIqG++zpt+I9dn9q4JM8D0Qmiu/fHnhTxqKbtiTQ9wNb2LJ4mkC7b eGtg5oF2nwsjlep/hGA+EBNd2DUEHWWym1Kzx4G4zmpmRLCF9WX6xT3HnQMReV+ycPny Vf/7BVGna6cWDnmS/7amDLZdblp3uWFSHxqngFSnkOSIGEQzyTLtbjWmL4zQA5XUYmcJ Y3HimuVgnePRY+lqmGru000EbgSeWfrqnEDir/YIbmcp2m/9tnHvzWaIDw5yKAwtEZlV 9D/YN9L19svISjCoPIv3J+SBWUx2TQgEHiJCaz0ct8HK9uvNUJP9bzjwmzec4Z8R1r1x 7FQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y27-v6si5376110pgc.152.2018.08.29.17.49.50; Wed, 29 Aug 2018 17:50:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbeH3EsO (ORCPT + 99 others); Thu, 30 Aug 2018 00:48:14 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39022 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbeH3EsN (ORCPT ); Thu, 30 Aug 2018 00:48:13 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 70FCE108ED012; Wed, 29 Aug 2018 17:48:44 -0700 (PDT) Date: Wed, 29 Aug 2018 17:48:41 -0700 (PDT) Message-Id: <20180829.174841.833303774555397982.davem@davemloft.net> To: decui@microsoft.com Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, netdev@vger.kernel.org, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, vkuznets@redhat.com, marcelo.cerri@canonical.com, jopoulso@microsoft.com Subject: Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier in netvsc_probe() From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Aug 2018 17:48:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dexuan Cui Date: Wed, 22 Aug 2018 21:20:03 +0000 > --- > drivers/net/hyperv/netvsc_drv.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > > FYI: these are the related 3 paths which show the deadlock: This incredibly useful information belongs in the commit log message, and therefore before the --- and signoffs.