Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 29 Aug 2018 19:08:39 -0700 (PDT)
Message-Id: <20180829.190839.1082082323658260994.davem@davemloft.net>
To:     decui@microsoft.com
Cc:     kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        netdev@vger.kernel.org, devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org, olaf@aepfle.de, apw@canonical.com,
        jasowang@redhat.com, vkuznets@redhat.com,
        marcelo.cerri@canonical.com, jopoulso@microsoft.com
Subject: Re: [PATCH] hv_netvsc: Fix a deadlock by getting rtnl_lock earlier
 in netvsc_probe()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <PU1P153MB016903725D5E8EF56C07FF69BF080@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
References: <PU1P153MB01692432D92B3A726FBDDC68BF300@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
        <20180829.174841.833303774555397982.davem@davemloft.net>
        <PU1P153MB016903725D5E8EF56C07FF69BF080@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Dexuan Cui <decui@microsoft.com>
Date: Thu, 30 Aug 2018 00:58:48 +0000

>> From: David Miller <davem@davemloft.net>
>> Sent: Wednesday, August 29, 2018 17:49
>> 
>> From: Dexuan Cui <decui@microsoft.com>
>> Date: Wed, 22 Aug 2018 21:20:03 +0000
>> 
>> > ---
>> >  drivers/net/hyperv/netvsc_drv.c | 11 ++++++++++-
>> >  1 file changed, 10 insertions(+), 1 deletion(-)
>> >
>> >
>> > FYI: these are the related 3 paths which show the deadlock:
>> 
>> This incredibly useful information belongs in the commit log
>> message, and therefore before the --- and signoffs.
> 
> Hi David,
> I was afraid the call-traces are too detailed. :-)
> 
> Can you please move the info to before the --- line?
> 
> Or, should I resend the patch with the commit log updated?

Please resend.