Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Phil Edworthy <phil.edworthy@renesas.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Simon Horman <horms@verge.net.au>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 1/2] clk: Add of_clk_get_by_name_optional() function
Thread-Topic: [PATCH v4 1/2] clk: Add of_clk_get_by_name_optional() function
Thread-Index: AQHUKMec3KUQcPGA60W10ctOf+LYP6TXJNuAgAD/sTA=
Date:   Thu, 30 Aug 2018 08:30:59 +0000
Message-ID: <TY1PR01MB176960BEDC23EA64095EF6F2F5080@TY1PR01MB1769.jpnprd01.prod.outlook.com>
References: <1533039060-18779-1-git-send-email-phil.edworthy@renesas.com>
 <1533039060-18779-2-git-send-email-phil.edworthy@renesas.com>
 <20180829171039.GD11447@smile.fi.intel.com>
In-Reply-To: <20180829171039.GD11447@smile.fi.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4eaca412-80dc-4dc7-5dc2-08d60e52ea56
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2018 08:30:59.9078
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB0334
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

On 29 August 2018 18:11 Andy Shevchenko wrote:
> On Tue, Jul 31, 2018 at 01:10:59PM +0100, Phil Edworthy wrote:
> > Quite a few drivers get an optional clock, e.g. a clock required
> > to access peripheral's registers that is always enabled on some
> > devices.
> >
> > This function behaves the same as of_clk_get_by_name() except that
> > it will return NULL instead of -ENOENT.
>=20
> > +		if (optional && (index =3D=3D -EINVAL || index =3D=3D -ENODATA ||
> > +		    PTR_ERR(clk) =3D=3D -ENOENT)) {
>=20
> A nit: I would rather rearrange this to be
>=20
> if (optional &&
>     (... || ... || ...)) {
>=20
> (disregard 80 characters limit for second line)

Thanks for the review. I'm not particularly happy with the patch as is, it'=
s
pretty messy. I was in rush trying to get things done before holidays - alw=
ays
a mistake.
Would you mind if I sent a v5 that I feel is somewhat clearer?

Thanks
Phil