Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp473380imm; Thu, 30 Aug 2018 03:41:36 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYuQwS5uA3mZ69D9yC0HT7zroJuhQu43L7QBqhfqGTI7wcvPiZtD6oSo85C8d/VTUqAyqtR X-Received: by 2002:a65:4b88:: with SMTP id t8-v6mr9265629pgq.239.1535625696257; Thu, 30 Aug 2018 03:41:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535625696; cv=none; d=google.com; s=arc-20160816; b=MUo8JsQ6FUGZXB43YSwyV5cO4dXMYzz1X9sH36iOzSwDdvnODf/5foHDjFLyqXNJAu tiPJEHe+1ZF3ZGU3EzMjCnwfyUdEyRmANsZAUaumDGf3YsHUtStx/DkUIRtdYhn8MTy2 Rjiosg5sJEFkzdDMR/0zjnJGT0lT1+1lU54tjkuQiJrOahLfEdvwLUgbLj6RnkAfy9Yw kKLtHMcMnitTIMS1tT6P8G7toxFkTKCzVNnI1V9F7FWk1Rs5+7O0vc1XxFJzj9j8oCDD ArVgU4WUcZol2649hNL/96lTyL7+c29jM6gZFzczsdQu3Trr9TOCLmrFPr4TQc41b3fQ w/2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=G+TF3tAWpewKhwjkHGmnRImIMSpRNEMYD4FpDjjmHvA=; b=wW9eVF087/7Gn24tK/T1JcGlI3atQjz4VQ0utPN/Jyf8/ZrjOhfK7nPwmnDkV3f3qA 5HCwT3MZNBRFhgFdzmvMjSY4kSx32tREPWh1ei5h3uFXK3jFwXwl87lqQn70N0TJKvxc 3J1RqIiANoProvbAcKxcVluZIRIEsyie55NgUIRyxcoAznjogsA01JTXXHtJAEFn8er/ 8Xfws4zXppWOnupvmILAykCHEVp9ormHsTUGY2/c5VCXa2RHQ+iILQjQMXAB/eXfgekR Xa9st3JbK7Gb1W18ZyoLPSPc03MdtshT+HZg8jR1gK6UHEoSBKsBTNCumt5Q6E+4trNP Hc7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6-v6si6136127pge.100.2018.08.30.03.41.21; Thu, 30 Aug 2018 03:41:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728451AbeH3OlQ (ORCPT + 99 others); Thu, 30 Aug 2018 10:41:16 -0400 Received: from mga01.intel.com ([192.55.52.88]:8679 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728311AbeH3OlQ (ORCPT ); Thu, 30 Aug 2018 10:41:16 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2018 03:39:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,306,1531810800"; d="scan'208";a="69279972" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga008.jf.intel.com with ESMTP; 30 Aug 2018 03:39:34 -0700 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1fvKMP-0000b3-5X; Thu, 30 Aug 2018 13:39:33 +0300 Date: Thu, 30 Aug 2018 13:39:33 +0300 From: Andy Shevchenko To: Phil Edworthy Cc: Michael Turquette , Stephen Boyd , Russell King , Geert Uytterhoeven , Simon Horman , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 1/2] clk: Add of_clk_get_by_name_optional() function Message-ID: <20180830103933.GJ11447@smile.fi.intel.com> References: <1533039060-18779-1-git-send-email-phil.edworthy@renesas.com> <1533039060-18779-2-git-send-email-phil.edworthy@renesas.com> <20180829171039.GD11447@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 30, 2018 at 08:30:59AM +0000, Phil Edworthy wrote: > On 29 August 2018 18:11 Andy Shevchenko wrote: > > On Tue, Jul 31, 2018 at 01:10:59PM +0100, Phil Edworthy wrote: > Thanks for the review. I'm not particularly happy with the patch as is, it's > pretty messy. I was in rush trying to get things done before holidays - always > a mistake. > Would you mind if I sent a v5 that I feel is somewhat clearer? That's definitely preferable! -- With Best Regards, Andy Shevchenko