Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp518616imm; Thu, 30 Aug 2018 04:56:28 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYUroUWADsnCcIWbC4G4N2TX3y/auoRL2An7xe/3YRSYHCJ+6mOuVZ+3hn55t8qErXVijfp X-Received: by 2002:a17:902:6501:: with SMTP id b1-v6mr9969252plk.31.1535630188269; Thu, 30 Aug 2018 04:56:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535630188; cv=none; d=google.com; s=arc-20160816; b=LTnAA0gkhN17dz+qbo8Oja8Jp5KPFzL9dq1+kPQeKTf2yIwTTf/nwCJfmzP1v4MNfm +WjMRPt65NzvKjQ7y0j8tlYH1+w14TpbEdaQ3Ufx3glpQY/LshxsQ8vDF8FzgVHIWO6L UYjP5Nx7LPPyUXPKOm2PEDioSy+kvEnVMlu8JgKco4jklrCacfkl678vMhYusVsmap4f XCHVxIKe/onZv0nC3qqWyWlp4FKiwY7Z3nc3tMtZlhVsYlN5Gwq2VPpiiTvI57YjsI9B S1cVgeJR2IeQ4jrCNCaDt1qWJQqxV6DV2qWUpPbzAxZ3ebRom3ySDevEJw3n5tpmswwk +4MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:arc-authentication-results; bh=hMkJRfcvKnFcYB76xEo03K/fDVUWqwMLhV2vmNlOfU8=; b=SzKsMr8o82FAGMch7IIki3sLGU1zSpKXBnlaqgfHI6D/fswps8jrSfLSrKH3TRMv9Q 48/dIEXOXc93rqyJdV+Oqu2IH/CEwfkiotMYklIIAH9mKZh9B9ETDPooL0AL6dGzmmbk 40KTIGYbnVE4utJfCOyXWUkQ9U68rhDbGU5f2yuG/IiV3SA7CCE86K3edbU+AEde0FeE IuPzcevnhcV2oW1caJqteRWQRVmd+j/4+HDobDtLSHsdPYn5jE2fdwuvrBsiNxqYZ1+v 7M8DMu9FzAw8dWhEaH9nJ8PNWmYZT1bLuSCcrPmz60tkIy8xtdf7L0Ix3QjjimtGMj8v THRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u42-v6si6763587pgn.86.2018.08.30.04.56.13; Thu, 30 Aug 2018 04:56:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728632AbeH3P4w (ORCPT + 99 others); Thu, 30 Aug 2018 11:56:52 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:35594 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbeH3P4w (ORCPT ); Thu, 30 Aug 2018 11:56:52 -0400 Received: by mail-qk0-f196.google.com with SMTP id 89-v6so5511392qkp.2; Thu, 30 Aug 2018 04:55:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hMkJRfcvKnFcYB76xEo03K/fDVUWqwMLhV2vmNlOfU8=; b=ct9PweLNJk45TIg4RlPR/ic9vvnXvO2OBWlPAbMfBkwvi8OgBoV9QotVQH4MsG+Q0l fAvzdrbPC74ukVFaFq6lNIgwnn3mZCdmCnjBAsfARfH7CLJBpP2mjE0+5q3SDCVmELMg X7nmK+0ozdpkG1gZHv71MlEi7JAi7yLp304S6+DYknjjSQB+TxjOihbF1IUoKhQF8uNE jPqBOwK6CrW5GZuB4gkV/0mJzNbeE4QjbjNbdLjO19PBJn2qg6tOsWv3Srg27j934kX4 tOJ5wnlYN4nekUrreA0D0Hw1T5XSzzL657NKplrMquqSwviQ5HX3+UBVSwgQfF4OJfJF ACRA== X-Gm-Message-State: APzg51Acr5OSxJZNLX3WkVDelojxBgLDXqkmPCq3NqkjAoYg/m/2DwSz Lz7yQ5SFh+sjXksEtKQuzg/h1fAmYKpPVIMuxXI= X-Received: by 2002:a37:1b91:: with SMTP id m17-v6mr10932232qkh.173.1535630105117; Thu, 30 Aug 2018 04:55:05 -0700 (PDT) MIME-Version: 1.0 References: <20180829140409.833488-1-arnd@arndb.de> <20180830110453.GC1473@alphalink.fr> In-Reply-To: <20180830110453.GC1473@alphalink.fr> From: Arnd Bergmann Date: Thu, 30 Aug 2018 13:54:48 +0200 Message-ID: Subject: Re: [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling To: g.nault@alphalink.fr Cc: Paul Mackerras , linux-ppp@vger.kernel.org, Networking , mitch@sfgoth.com, mostrows@earthlink.net, jchapman@katalix.com, xeb@mail.ru, David Miller , Al Viro , y2038 Mailman List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 30, 2018 at 1:04 PM Guillaume Nault wrote: > > On Wed, Aug 29, 2018 at 04:03:26PM +0200, Arnd Bergmann wrote: > > Support for handling the PPPOEIOCSFWD ioctl in compat mode was added in > > linux-2.5.69 along with hundreds of other commands, but was always broken > > sincen only the structure is compatible, but the command number is not, > > due to the size being sizeof(size_t), or at first sizeof(sizeof((struct > > sockaddr_pppox)), which is different on 64-bit architectures. > > > And the implementation was broken until 2016 (see 29e73269aa4d ("pppoe: > fix reference counting in PPPoE proxy")), and nobody ever noticed. I > should probably have removed this ioctl entirely instead of fixing it. > Clearly, it has never been used. > > If you think it's worth fixing (as opposed to dropping this ioctl or > its compat mode), then, > Acked-by: Guillaume Nault I don't care much, but fixing it seems seems easier than coming up with a convincing rationale for dropping. I'll update the changelog text to include your additional background information though, unless someone else prefers to have it dropped. Arnd