Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp6419imm; Thu, 30 Aug 2018 05:47:09 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbAT8KqiP4X+RrBTds/OHPuAIIe0L63k2oaH4rR8132j6RDFnK37FLPT2Gz/Psbo7sJQsfM X-Received: by 2002:a62:e412:: with SMTP id r18-v6mr10415325pfh.25.1535633229778; Thu, 30 Aug 2018 05:47:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535633229; cv=none; d=google.com; s=arc-20160816; b=0JeSoRwJiMU3+Loeb+2l3wj0dSEEwWWkB5EauA1IXHpcs25/NFOydYPpTXMsqRJ5wr OndaR/Ufkq2DHFsFAHn27pDdA2gWngNxUhDjJYJKNCMf/UzGIUaDB2q+8tlugo4vSQnr WaCXR6gNVPlwlb3nNuk2iZPSqCRqfa2OeqPFmXN09B2NdfSAiESb8OC3v2sKYvvUjqOT yrO/cFcDbKYt09SArjipmDz4skdZjirGcacEMXAGwn1cfpOOA6XKlC4wG7zM9fFyrCD+ uUcxROFr79GsYbFBr9fHOqkhxNWBJOBBDTXhrFfQScD1euhrsP24DZ+DR99YzegedxT5 Et8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=602BNxW0qIqOwTMXBCjbi36sAFct8N2uXrJzotSLpnM=; b=Xl9krXTmS6N6wbejR9jMwoI6D+NKa6ZKnaxYLvPYZTzTYlwukMtx9ugNlR7geKank0 nvIBWNQT1lS5tH7XCXT+BkQvGR5d+vWQ1eCUvZnwzQmCjhYaH/mIL1LCKucgQG8E/Grs H8oYn5nq8MiF64lZVMiFfU3dRwox/yCiQd6aFTUPw8Eqk4zTMEOeTr/I1V31ZW55PJdo zQQmVm/eEgnfcpAwnshCEsna3bHauLLC7U2GigrPndETAORIHwxTU/XopHNiaARyvu1C pmWoIldCE8rl4A1XXIuC6liZE1uXabAiro/PZornIv+APhE+ILEuQ7Tg2je+eflUSyl0 ckig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a18-v6si6248698pfn.317.2018.08.30.05.46.54; Thu, 30 Aug 2018 05:47:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728841AbeH3Qrg (ORCPT + 99 others); Thu, 30 Aug 2018 12:47:36 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:50088 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728713AbeH3Qrg (ORCPT ); Thu, 30 Aug 2018 12:47:36 -0400 Received: from hsi-kbw-5-158-153-52.hsi19.kabel-badenwuerttemberg.de ([5.158.153.52] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fvMKE-0002vT-Hw; Thu, 30 Aug 2018 14:45:26 +0200 Date: Thu, 30 Aug 2018 14:45:26 +0200 (CEST) From: Thomas Gleixner To: Gu Zhimin cc: "Rafael J. Wysocki" , Len Brown , Ingo Molnar , "H. Peter Anvin" , Pavel Machek , Yu Chen , x86@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] x86, hibernate: Fix nosave_regions setup for hibernation In-Reply-To: <73b18a8b87a465fc442366cccf5542307c4f1ae9.1535361949.git.kookoo.gu@intel.com> Message-ID: References: <73b18a8b87a465fc442366cccf5542307c4f1ae9.1535361949.git.kookoo.gu@intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Aug 2018, Gu Zhimin wrote: > > Fix this problem by changing pfn limit from max_low_pfn to max_pfn. > This issue should also exist on 64bits systems, if there are reserved > regions above 4GB. Should? Can we please have facts and not some half baken assumptions? On 64bit max_low_pfn is the same as max_pfn. See init_mem_mapping(). Thanks, tglx