Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp24442imm; Thu, 30 Aug 2018 07:30:10 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb7Wbg9Bupx9GYeYF6g4fCnPw5aLD0XRbQzUYbW7ru/LzC+/j5XgmSG+QH3IE83V+uuNWpF X-Received: by 2002:a17:902:18a:: with SMTP id b10-v6mr10549470plb.62.1535639410260; Thu, 30 Aug 2018 07:30:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535639410; cv=none; d=google.com; s=arc-20160816; b=K2jnNDJePMARfYaU+EE3owW5gwyVneeoX5VWL4OtV+6uRGa27fLlzEl716z5joGSIJ xzndfeooHFGNjoCKRSk/nlqAliJv5LAVzVKp9te5QJeNRWg3NXbC451R0exF85zkImn6 Oec0BsUJZ7tcEsCO5TwxlD5B+TxYPtVwlrMV7lkp2ETF9cwoeHv97VtMbeEhdvn7FjrZ Lm2wS79TV7pq9riDuDQXLPuIbiD4YtCLyQBci+mUKg1+/gM22vLes8NSEJfgQOVMBf6W 0mDPekIqzK8x9cVAQ6groJuuDVB/+26zi2ladyrbARKJPO+P2wK3v85xczcuV5t8lhDr mvpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=GQYorMfp38jsFJvIOsRSR6RAKuzL958IrRCUBjB6VoU=; b=Ztlb2MB/V68CxccmHOkDFLxrbOuTPCTlBCe2YceIZYBSBU8wTtnYVTdaC1905yOVxA agBnaS3Ow26mqzmYPTYn6TFIxd2V6VgKGmg0QtARis+SljfF0huVg6uWiFp9/dQURpYD y+gAvxzdIT/DKz4ZQSjpY111y9MTS+vAgFfj9kKLwyvQ/vKrYGJMxsn4LeqYyoJCNXe0 IY0a3gHmno/xXWABZsFjXhUtBOF69s5OgVbhIGo165PHS3v8y/Pf1qjnf++UHHM018Ba jaaBB/vbJDQXCEjmbY5dVcwBtFjSkjhRqhpXaNYD/zb/oma9//joMHcYHM94tkf17vNO OGWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1-v6si6036683pgt.629.2018.08.30.07.29.39; Thu, 30 Aug 2018 07:30:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729236AbeH3S3t (ORCPT + 99 others); Thu, 30 Aug 2018 14:29:49 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39528 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729080AbeH3S3s (ORCPT ); Thu, 30 Aug 2018 14:29:48 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fvNup-0007vf-8h; Thu, 30 Aug 2018 14:27:19 +0000 From: Colin King To: "David S . Miller" , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Jesper Dangaard Brouer , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][net-next] xdp: remove redundant variable 'headroom' Date: Thu, 30 Aug 2018 15:27:18 +0100 Message-Id: <20180830142718.10850-1-colin.king@canonical.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Variable 'headroom' is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: variable ‘headroom’ set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King --- net/core/xdp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/core/xdp.c b/net/core/xdp.c index 654dbb19707e..4b2b194f4f1f 100644 --- a/net/core/xdp.c +++ b/net/core/xdp.c @@ -412,7 +412,7 @@ EXPORT_SYMBOL_GPL(xdp_attachment_setup); struct xdp_frame *xdp_convert_zc_to_xdp_frame(struct xdp_buff *xdp) { - unsigned int metasize, headroom, totsize; + unsigned int metasize, totsize; void *addr, *data_to_copy; struct xdp_frame *xdpf; struct page *page; @@ -420,7 +420,6 @@ struct xdp_frame *xdp_convert_zc_to_xdp_frame(struct xdp_buff *xdp) /* Clone into a MEM_TYPE_PAGE_ORDER0 xdp_frame. */ metasize = xdp_data_meta_unsupported(xdp) ? 0 : xdp->data - xdp->data_meta; - headroom = xdp->data - xdp->data_hard_start; totsize = xdp->data_end - xdp->data + metasize; if (sizeof(*xdpf) + totsize > PAGE_SIZE) -- 2.17.1