Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp55741imm; Thu, 30 Aug 2018 08:11:22 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbeGxL24+cUVq+eL0S6t0ButSif55jHXA6oBXV8c5bYMPmV5eK0YPakPEoE6N2kR1tIF6pw X-Received: by 2002:a63:a5c:: with SMTP id z28-v6mr9871654pgk.209.1535641882609; Thu, 30 Aug 2018 08:11:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535641882; cv=none; d=google.com; s=arc-20160816; b=eJzbC+cjwaxh1J8Q2z+Mwt2gZBwRxpGGKwge3hRQPystnrmK94FxCyz9OXrGik7PDD T8XHFFIOP6G16rVX92bnqBiJDUWIL4Q0ODlhxDBe7f8jzOAjDhY0dZGc9yp8E/DTaxvd Obxf+s1r7ZyZQ0qUxITO0JZzmS7N4aC4dV4+8l0NOv5+Im4vl8irJ87rO5ZO6pQ1ZdjK 4xIP/YNPtu1c8A38d2lr3qZ4irzDbAuB3Q0B51OxE89JBB9y0Tk1F6Uh+vNI1qAC43ES LZRA+Rj2DQ2xZPkPlX5qyx+itfJGK+TVHF1cIv8BxyAijQdh2pGhBcjXfXePJNjeLs7H N4mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=wpWeqNtSGPQkSX74Mps4iYJBnmRuf3i2gy1uTHglDd8=; b=QhExlWv+dZ/jDX7u/Lpypk0fMLm+eGFF2JyHZi0xi8aG3L4KJSPuAYGBy/w04VBytj sldpTieOCCjmEbhrY34T9/15vPqXLw+ZNeA8qlIuw4H6SaEXkhSOEiluZtVFMhcivXRq w2O5sQmY2Py3stKbG+rKG743QfurlobVNNl4MZoPND2ihKWX6YoxpzxIkZb3jiqGlIT7 R3GPUSwUOOEjQklOjkRUSn3DJX6UNmvnHUmmhd53Myqnm+2FUihr/DoE/tespTyJMQAK f0ZXzYG8tY3EXmqKh0q27IYFEimIEzGHgKCZzWQUpmwcVhpzjAnB0UY1lgHoazEHez3m Ovbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j15-v6si6379511pfn.366.2018.08.30.08.11.02; Thu, 30 Aug 2018 08:11:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729873AbeH3TKh (ORCPT + 99 others); Thu, 30 Aug 2018 15:10:37 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:13536 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729853AbeH3TKg (ORCPT ); Thu, 30 Aug 2018 15:10:36 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 30 Aug 2018 08:07:59 -0700 Received: from HQMAIL106.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 30 Aug 2018 08:08:01 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 30 Aug 2018 08:08:01 -0700 Received: from HQMAIL110.nvidia.com (172.18.146.15) by HQMAIL106.nvidia.com (172.18.146.12) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 Aug 2018 15:08:01 +0000 Received: from HQMAIL104.nvidia.com (172.18.146.11) by hqmail110.nvidia.com (172.18.146.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 Aug 2018 15:08:00 +0000 Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL104.nvidia.com (172.18.146.11) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 30 Aug 2018 15:08:00 +0000 Received: from dhcp-10-21-25-168.Nvidia.com (Not Verified[10.21.25.201]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Thu, 30 Aug 2018 08:08:00 -0700 From: Aapo Vienamo To: Rob Herring , Mark Rutland , Thierry Reding , Jonathan Hunter , Ulf Hansson , Adrian Hunter , Mikko Perttunen , "Stefan Agner" CC: , , , , Aapo Vienamo Subject: [PATCH v3 24/38] mmc: tegra: Remove tegra_sdhci_writew() from tegra210_sdhci_ops Date: Thu, 30 Aug 2018 18:06:25 +0300 Message-ID: <20180830150639.21048-25-avienamo@nvidia.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180830150639.21048-1-avienamo@nvidia.com> References: <20180830150639.21048-1-avienamo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tegra_sdhci_writew() defers the write to SDHCI_TRANSFER_MODE until SDHCI_COMMAND is written. This is not necessary on Tegra210 and Tegra186 and it breaks read-modify-write operations on SDHCI_TRANSFER_MODE because writes to SDHCI_TRANSFER_MODE aren't visible until SDHCI_COMMAND has been written to. This results in tuning failures on Tegra210. Signed-off-by: Aapo Vienamo --- drivers/mmc/host/sdhci-tegra.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index f68557a01d5d..0bdce437e752 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -834,7 +834,6 @@ static const struct sdhci_tegra_soc_data soc_data_tegra124 = { static const struct sdhci_ops tegra210_sdhci_ops = { .get_ro = tegra_sdhci_get_ro, .read_w = tegra_sdhci_readw, - .write_w = tegra_sdhci_writew, .write_l = tegra_sdhci_writel, .set_clock = tegra_sdhci_set_clock, .set_bus_width = sdhci_set_bus_width, -- 2.18.0