Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Aug 2018 11:42:18 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Josh Triplett <josh@joshtriplett.org>
Cc:     "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, mingo@kernel.org,
        jiangshanlai@gmail.com, dipankar@in.ibm.com,
        akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
        tglx@linutronix.de, peterz@infradead.org, dhowells@redhat.com,
        edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com,
        joel@joelfernandes.org
Subject: Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for
 v4.20/v5.0
Message-ID: <20180830114218.39743075@gandalf.local.home>
In-Reply-To: <20180830042006.GA23159@localhost>
References: <20180829223830.GA1800@linux.vnet.ibm.com>
        <20180829220026.3579e9a1@vmware.local.home>
        <20180830032216.GF4225@linux.vnet.ibm.com>
        <20180830041017.GA27378@linux.vnet.ibm.com>
        <20180830042006.GA23159@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 29 Aug 2018 21:20:07 -0700
Josh Triplett <josh@joshtriplett.org> wrote:


> > And please see below for what the resulting diff would look like.  Is
> > this an improvement?  
> 
> Honestly, as long as the result after each commit compiles, I prefer the
> split version for ease of review.

You and I have different preferences for reviewing changes like this ;-)

I prefer the one patch (I do think it is an improvement). It's all
basically the exact same change. Looking at 40 different patches is
much more work IMHO, then just looking at a single patch, and testing
it, then testing 40 different patches. That's a lot of compiling.

I usually stop reviewing after 10 patches of the same kind, as I run
out of time to review them.

-- Steve