Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   KY Srinivasan <kys@microsoft.com>
To:     Dexuan Cui <decui@microsoft.com>,
        "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>
CC:     "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
        "'driverdev-devel@linuxdriverproject.org'" 
        <driverdev-devel@linuxdriverproject.org>,
        "'olaf@aepfle.de'" <olaf@aepfle.de>,
        "'apw@canonical.com'" <apw@canonical.com>,
        "'jasowang@redhat.com'" <jasowang@redhat.com>,
        vkuznets <vkuznets@redhat.com>,
        "'marcelo.cerri@canonical.com'" <marcelo.cerri@canonical.com>
Subject: RE: [PATCH] Drivers: hv: vmbus: Use raw_smp_processor_id() in
 vmbus_connect()
Thread-Topic: [PATCH] Drivers: hv: vmbus: Use raw_smp_processor_id() in
 vmbus_connect()
Thread-Index: AdQ7H/34qAH7zeGBQLegJ1KnxB9zFAFWLlUA
Date:   Thu, 30 Aug 2018 16:28:22 +0000
Message-ID: <MW2PR2101MB11138A251E48BC8C6B859BF1A0080@MW2PR2101MB1113.namprd21.prod.outlook.com>
References: <PU1P153MB01694E53D6A6192A46EA3214BF370@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
In-Reply-To: <PU1P153MB01694E53D6A6192A46EA3214BF370@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ff38a5ba-804b-493b-eebd-08d60e959a66
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2018 16:28:22.1656
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1116
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Dexuan Cui
> Sent: Thursday, August 23, 2018 3:31 PM
> To: 'gregkh@linuxfoundation.org' <gregkh@linuxfoundation.org>; KY
> Srinivasan <kys@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>
> Cc: 'linux-kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
> 'driverdev-devel@linuxdriverproject.org' <driverdev-
> devel@linuxdriverproject.org>; 'olaf@aepfle.de' <olaf@aepfle.de>;
> 'apw@canonical.com' <apw@canonical.com>; 'jasowang@redhat.com'
> <jasowang@redhat.com>; vkuznets <vkuznets@redhat.com>;
> 'marcelo.cerri@canonical.com' <marcelo.cerri@canonical.com>
> Subject: [PATCH] Drivers: hv: vmbus: Use raw_smp_processor_id() in
> vmbus_connect()
>=20
>=20
> With CONFIG_DEBUG_PREEMPT=3Dy, I always see this warning:
> BUG: using smp_processor_id() in preemptible [00000000]
>=20
> Fix the false warning by using raw_smp_processor_id().
>=20
> Here vmbus_connect() sends a message to the host and waits for the
> host's response. The host will deliver the response message and an
> interrupt on CPU msg->target_vcpu, and later the interrupt handler
> will wake up vmbus_connect(). vmbus_connect() doesn't really have
> to run on the same cpu as CPU msg->target_vcpu, so it's safe to
> use raw_smp_processor_id() here.
>=20
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Cc: stable@vger.kernel.org
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  drivers/hv/connection.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
> index ced0418..c3b7040 100644
> --- a/drivers/hv/connection.c
> +++ b/drivers/hv/connection.c
> @@ -119,8 +119,8 @@ static int vmbus_negotiate_version(struct
> vmbus_channel_msginfo *msginfo,
>  	 */
>  	if (version >=3D VERSION_WIN8_1) {
>  		msg->target_vcpu =3D
> -
> 	hv_cpu_number_to_vp_number(smp_processor_id());
> -		vmbus_connection.connect_cpu =3D smp_processor_id();
> +
> 	hv_cpu_number_to_vp_number(raw_smp_processor_id());
> +		vmbus_connection.connect_cpu =3D raw_smp_processor_id();
Dexuan,

We want a consistent view of the CPU we are currently running on. How about=
 doing something
like this:

diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index ced041899456..4cc0877ba38a 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -119,8 +119,9 @@ static int vmbus_negotiate_version(struct vmbus_channel=
_msginfo *msginfo,
         */
        if (version >=3D VERSION_WIN8_1) {
                msg->target_vcpu =3D
-                       hv_cpu_number_to_vp_number(smp_processor_id());
-               vmbus_connection.connect_cpu =3D smp_processor_id();
+                       hv_cpu_number_to_vp_number(get_cpu());
+               vmbus_connection.connect_cpu =3D msg->target_vcpu;
+               put_cpu();
        } else {
                msg->target_vcpu =3D 0;
                vmbus_connection.connect_cpu =3D 0;

>  	} else {
>  		msg->target_vcpu =3D 0;
>  		vmbus_connection.connect_cpu =3D 0;
> --
> 2.7.4