Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp139730imm; Thu, 30 Aug 2018 10:11:35 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZt8l8GMmfJG4S1oeM3cx5xS4caM5FFpBpe08a/lruXDdq38QsBWSlKDaeu/dE5VDuAidZj X-Received: by 2002:a63:6ce:: with SMTP id 197-v6mr10372912pgg.338.1535649095648; Thu, 30 Aug 2018 10:11:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535649095; cv=none; d=google.com; s=arc-20160816; b=feyZmrX2KplFbOKg2lcwmuUhMh+E644yiA0yfVX8LGl6zLp2c4fcalfy2kJRrF3god A5NAhyWhkG3ZVg09ZC2bPV83hBWpFJAUxw7uNeF+J6Z4SDyHeeEMQX1Mfo6Ln0aX6fHo RpDGE0/LHo8HgjInUPniEzA0RbRmZVwtRq6+1OQ0WHXZoWJf6R0lVHU5z6hR1T55CyRt /1EncreQqVfGNlcO5n+UObSG61unku5L2+T7cUq7XSubg+MUZe5cy0/4+0CgYsh4uXiD Is9BSf6To6MVX3Ze0+yuD5YlP2ktxuYkN+tG+GhGdX/Njcb3yBijAVi5wGoa3cIWlvfd JhOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date:arc-authentication-results; bh=PSi1a9D3t+PIpeBraG9Rjff/R2Znbjx0KzDi++q83D0=; b=m9/Ba5VQyh6TO9iTNMSnzJibnaF2cGOHC28+3PTquPmTJ3ONRWjAPVJDLv84iolvUd rP8oupjePWCmwHILbuhprwJpE6t6vQmRDwA+L+e/MexpshdVWLF6+NF+g6Uo3eZzTzIW 5TjUluIUG9d5KPleRtqVqdoKnjWuB4HdCxHA6R5omqMwRbUGy46t+qmbgYW/xlOiX23a YSFtssTjH89bT/wrWIVx9D3QnbFRQezOnfJoWLVtMDHaIE9foMJsj9RfQHXhDDWkQdVU Tw9XtBDl5D+XRGjxguH3ubtYnRx94H2jq3hPhYTaCQFgnIQTCdTqhSn2EvI5/YetqvLa /TLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i26-v6si7293821pgn.589.2018.08.30.10.11.19; Thu, 30 Aug 2018 10:11:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727193AbeH3VNU (ORCPT + 99 others); Thu, 30 Aug 2018 17:13:20 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57286 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726235AbeH3VNT (ORCPT ); Thu, 30 Aug 2018 17:13:19 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7UH9Lus139023 for ; Thu, 30 Aug 2018 13:10:13 -0400 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0a-001b2d01.pphosted.com with ESMTP id 2m6mcw8x3q-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 30 Aug 2018 13:10:13 -0400 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Aug 2018 13:10:11 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 30 Aug 2018 13:10:06 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7UHA57F27328620 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 30 Aug 2018 17:10:05 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 090E4B2064; Thu, 30 Aug 2018 13:09:00 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DC14AB205F; Thu, 30 Aug 2018 13:08:59 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 30 Aug 2018 13:08:59 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id C8DFC16C3063; Thu, 30 Aug 2018 10:10:06 -0700 (PDT) Date: Thu, 30 Aug 2018 10:10:06 -0700 From: "Paul E. McKenney" To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org Subject: Re: [PATCH tip/core/rcu 0/52] Remove rcu_state pointers for v4.20/v5.0 Reply-To: paulmck@linux.vnet.ibm.com References: <20180829223830.GA1800@linux.vnet.ibm.com> <20180829220026.3579e9a1@vmware.local.home> <20180830032216.GF4225@linux.vnet.ibm.com> <20180830041017.GA27378@linux.vnet.ibm.com> <20180830114452.309e104f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180830114452.309e104f@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18083017-0060-0000-0000-000002A6F98E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009639; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01081113; UDB=6.00557719; IPR=6.00861098; MB=3.00023020; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-30 17:10:09 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18083017-0061-0000-0000-000046580EE3 Message-Id: <20180830171006.GK4225@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-30_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808300174 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 30, 2018 at 11:44:52AM -0400, Steven Rostedt wrote: > On Wed, 29 Aug 2018 21:10:17 -0700 > "Paul E. McKenney" wrote: > > > On Wed, Aug 29, 2018 at 08:22:16PM -0700, Paul E. McKenney wrote: > > > On Wed, Aug 29, 2018 at 10:00:26PM -0400, Steven Rostedt wrote: > > > > On Wed, 29 Aug 2018 15:38:30 -0700 > > > > "Paul E. McKenney" wrote: > > > > > > > > > Hello! > > > > > > > > > > This commit does RCU-consolidation cleanups that get rid of pointers to > > > > > the sole remaining rcu_state structure: > > > > > > > > > > 1-40: Remove the "rsp" parameter from numerous functions, given that > > > > > the corresponding argument will always be &rcu_state. > > > > > > > > Hmm, couldn't 1-40 have been made into a single patch? > > > > > > They could. I separated them to make finding the inevitable typos easier. > > > But at this point, it is easy enough to squash them together, though. > > > > And please see below for what the resulting diff would look like. Is > > this an improvement? > > Somewhat... > > > ------------------------------------------------------------------------ > > > > diff --git a/Documentation/RCU/Design/Data-Structures/Data-Structures.html b/Documentation/RCU/Design/Data-Structures/Data-Structures.html > > index f5120a00f511..772c26a3865a 100644 > > --- a/Documentation/RCU/Design/Data-Structures/Data-Structures.html > > +++ b/Documentation/RCU/Design/Data-Structures/Data-Structures.html > > I would just keep the documentation patches separate. Combining yours and Josh's feedback, I will split the documentation updates out of 4ca0508f7870 ("rcu: Remove rsp parameter from rcu_node tree accessor macros") and put them into the "doc" series. Possibly combining it with 2ea66b6fce61 ("doc: Update documentation for removal of RCU-bh update machinery") and/or 3f38a4626202 ("doc: Update documentation for removal of RCU-sched update machinery"). Left to myself, I would merge it in to the merger of those two documentation commits. Having them together is probably more convenient anyway, as it would provide a summary of the entire RCU-flavor-consolidation change. Fair enough? Thanx, Paul > -- Steve > > > > @@ -1372,8 +1372,7 @@ that is, if the CPU is currently idle. > > Accessor Functions > > > >

The following listing shows the > > -rcu_get_root(), rcu_for_each_node_breadth_first, > > -rcu_for_each_nonleaf_node_breadth_first(), and > > +rcu_get_root(), rcu_for_each_node_breadth_first and > > rcu_for_each_leaf_node() function and macros: > > > > >