Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp153965imm; Thu, 30 Aug 2018 10:33:38 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYR5V8s4GwrEfd6T4hQdRbviRPKuLEJR3R5HVjqGb9Jg9u4yB/Pn5vb7MTzfX8eem+ZLCYQ X-Received: by 2002:a63:db4f:: with SMTP id x15-v6mr10176179pgi.214.1535650418473; Thu, 30 Aug 2018 10:33:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535650418; cv=none; d=google.com; s=arc-20160816; b=uFv481T5E7LffKwbSsym1EXOOwkwXu/lLWMxMThUePerdJcOS5/dQfb2Sq6uoXw/4N L3s9gnosFIPbihFRvbuFKF1keFp7W8OReoi5abbtENLjOd/nD+8tVKNDAg5QFiAd8144 6ZedssC1CiMWsYGk5ywfu6I0WsPJFCJXzTVMWxK+kXZdenDnxLPa9tNZz5tmbk8hCU+s qj4w3AUD+9ZAss6sG1GPk8cQQhIHNG1EesiYUJURjNHSIvG5SLX8CEeW6V3ScX4MiA0n m4iAcyszoNtHL41Si7BTyJ/AOU/kAn0ZGwQplKfxDKEmpencjndD411DQpVRQdWwL9Wc txPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature:arc-authentication-results; bh=OXupEqQWUgBYsleXbnpoJLQQLT96XlnXIOZ83WdQfo4=; b=ObCjDK1a8fiCMjGEjd76imfem4NgwesZ4ViXgeOcEImaNfFghYnoyhwY+SYblElfk4 Cx7l91I3YKCL+EM/I3lTp5/yQxxnaQppDjeJ04sjEd72x2i0CDhEzz0m8hnNOdxoIPvZ 4Y+IJR70nKYKwbl5Gm64E4k+jKM70WUtvrUu7vbaJ9tPdcIHYrQEGD8I2e0mUzXE9GdK GQch/b3KjXurYPLOyDR/fn6Lb4H5coAKwtIpl10UXHdfQY47hviFFtMRN8RQ3nMyTp2j xuu0hVm3A/Cgdxn570HSwdVAHS8Wx/iwHLkvkR6YMdq2DVH2JbsbTaEzPUs6sjqW09zu rEwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wt8rp+8D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7-v6si7006211plz.353.2018.08.30.10.33.24; Thu, 30 Aug 2018 10:33:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wt8rp+8D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727289AbeH3Vf3 (ORCPT + 99 others); Thu, 30 Aug 2018 17:35:29 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33156 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbeH3Vf2 (ORCPT ); Thu, 30 Aug 2018 17:35:28 -0400 Received: by mail-oi0-f65.google.com with SMTP id 8-v6so16908813oip.0 for ; Thu, 30 Aug 2018 10:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=OXupEqQWUgBYsleXbnpoJLQQLT96XlnXIOZ83WdQfo4=; b=Wt8rp+8DRZebe0n4XaNKe9FKxT0vcYeKgwLiMzH/+tEbJ5noCYcA0aMfc5T0vt47iV +z0XRqj+71T7FNBbjsho96ZNHU87mDo6FTkKnRqgFvt3rpMWybycxfrmLGGyjP/JhsRy XoQIFaJmAx6Sj2HHv/97MYG7SwBtr7ThiBapqF6SpWnQcbnAog9xL83uwSttbjQtN7hZ NKy9Rex0Dp8NAmYxBXBLUD37zE76/ZsHNtkl1w3PZPHHWeZCKYe+qgltDSazu2S8G/k2 PYu980g6XcRmJ0gezsai2YJg7n527wrXx8FHIAytneaijhLipT30fITQytUdpjb3I+WU z3sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=OXupEqQWUgBYsleXbnpoJLQQLT96XlnXIOZ83WdQfo4=; b=DAsu2u6F3qTHRqzx6CfxVFihltrW/MbmyxeXfvi24OfBMT2dSrwHJ2ZIDMCSy66u8S GirYXDT0SpqYgV5JZzK1LKQZDnF9G+TT2RbVx/w2cxBPBajsmss8be4KX5pFKM5u4dqn lM1DeElFaSmIucnAOineJk61PJm4l+qQSCWfVbvl2zBJYr6aXUpZzwjKjtKkKUUr2+wJ kjJKT9OwEmfbnJ38Omh/+nTJ6ssQzWe1YbHRS+N8hlpKPoKonYgkqrlsEY4VmE+nkI7z mdba7Nxzr6yUeDgiBczAsm4CFbMrYvYkO46Voom7g9hia7W7Ah6wLEt6eNOLKEo5nBZv 01fQ== X-Gm-Message-State: APzg51B0O/sLuwI30BLXYjp0XLl2Crgeeuh7J2a2JLteEmYe2QTD2Wha AH72O76qzAeShwVt8VAsUsT8L7nbL4243d2ctaU= X-Received: by 2002:aca:f58f:: with SMTP id t137-v6mr3395813oih.244.1535650336606; Thu, 30 Aug 2018 10:32:16 -0700 (PDT) MIME-Version: 1.0 From: Ray Clinton Date: Thu, 30 Aug 2018 13:32:12 -0400 Message-ID: Subject: [PATCH 1/4] staging: comedi: Correct multiline dereference as per TODO To: greg@kroah.com Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using checkpatch.pl I was able to find a multiline dereference which goes again the coding style for the kernel. I'm still working on my email client so the indentation looks bad here (in gmail) but the arguments for comedi_check_trigger_arg_min should go just under the opening ( Signed-off-by: Ray Clinton --- drivers/staging/comedi/drivers/dt3000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c index 2edf3ee..6bc5c86 100644 --- a/drivers/staging/comedi/drivers/dt3000.c +++ b/drivers/staging/comedi/drivers/dt3000.c @@ -439,9 +439,9 @@ static int dt3k_ai_cmdtest(struct comedi_device *dev, if (cmd->scan_begin_src == TRIG_TIMER) { arg = cmd->convert_arg * cmd->scan_end_arg; - err |= comedi_check_trigger_arg_min(&cmd-> - scan_begin_arg, - arg); + err |= comedi_check_trigger_arg_min( + &cmd->scan_begin_arg, + arg); } } -- 2.7.4