Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp154024imm; Thu, 30 Aug 2018 10:33:44 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda8uaX1n9kOjdBl8v5UZ/Z7zKnjJ4FdVpIS+xzGV4B+RITYlrHN6E+96vnuWjeFmekoi6R3 X-Received: by 2002:a62:f0d:: with SMTP id x13-v6mr11459483pfi.221.1535650424796; Thu, 30 Aug 2018 10:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535650424; cv=none; d=google.com; s=arc-20160816; b=medjnbPDzUfhBnsNqfc4uiZD800nnJEMT4LZgR9Ab+tpIYcLBA/LSVEn1zx2yKjEwV CxFGAbfJHgCQHU220nQEUlKUm3pv/dPZ0BSTe8wUyORj1NK3qI6zBf0m52ykfWK1O1K6 j6uuqt6dj60t4qapsNlhK15c+DMIoXrVfjskMJxvLta32BKCYURwkjL+s1FmtnCaXnZa MnDrbPzlxtbxv6cHIW3ts57qcQFnw5L6rjdlN06J/3NmCsjNiOF6btQ6XMdoqjb/cs2z aDrAUDwWkpQc/RgXm6bUcC7K++R2wU3ZEeuPyJIq7BmRZ0LTLLJCdMlJHilbJLvJIaQ0 7QWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature:arc-authentication-results; bh=k+UszutxvUCwPJTXFQ34iRyWW1CYVNt3QJc2CwBhr3k=; b=QhxIjOpbdxlXJTtrS8tICkb8mOSWx7XkAQgNVEiIzah7XWUgFYEWnPWfRQQG6csNnq G5W14548cuZl7GkJa2SL+KEKXlELaNtLfSirnCZGFCTMut6PAaV3N0TJcYfRawoXiz1o 0S6vbl+2bCl4joxyhkvc4FyLTiAotWpDNyQ4uua/C4OshpqaDAHut/lQzkr71CTBwEwK TsAvh57/UF5u68FZPjOjYehG/bBpBTFUeRSn8WzSgEpSyCW+9RToo2QZG98wvuR05fqc OgynYV6b0ZXVz4NqWhgQrdkrmQHHFn1TQMCH78WlDXGs553wPc4voNSWdjfZOPG+HuZZ WNsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=alU9K9Pl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si6869854plk.379.2018.08.30.10.33.30; Thu, 30 Aug 2018 10:33:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=alU9K9Pl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727430AbeH3Vfd (ORCPT + 99 others); Thu, 30 Aug 2018 17:35:33 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34269 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726732AbeH3Vfc (ORCPT ); Thu, 30 Aug 2018 17:35:32 -0400 Received: by mail-oi0-f68.google.com with SMTP id 13-v6so16913369ois.1 for ; Thu, 30 Aug 2018 10:32:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=k+UszutxvUCwPJTXFQ34iRyWW1CYVNt3QJc2CwBhr3k=; b=alU9K9Ple46odKFkwG/b9KaEjQn5cTsxoWaVGukFIBuFl4b31nxOyB5PsnkRv0lSdI ed0g9MXorZP9JZ3bhWyBvASI8pEgAVX5Lep//gFflnMMyFn0ek4I4mowqqo3bBm+OKXo gi5bZ5GHJ4qADNihma25TVdD/L8ELIVcfv971us1nFgQnJy3lp5+kKIO+zJ8BOa3H9KA 5PONUWLoEYQqjOd/Tb3k/vCh7s/JJrrQs+MyNPjnooBw7zjDh406NXkXJPt/lONC3sBe atAbBYnnjETnoOkoGs57snKq7BrugmxN51OZt6K7xsrNlFovczXrypUZJqnU0EcRN493 sEug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=k+UszutxvUCwPJTXFQ34iRyWW1CYVNt3QJc2CwBhr3k=; b=WfHwx7fgg+ua8tD4g1FOxiwweUs13F4f/iOo/3KDTldN3+B0BqfnP1Aoy9JoFtqFNl SsRspcGu5xSQJ0EUzSPN/PRc04d1bg/jmFhKRwYFq7ujmLnDO4c1zvTF2YnRXAZAbyRg by0+NWz+0JpRoCxJQOzQ70qKmK6IwEeUo0A5nk7SGYyL3NrC4L6GRtTpEpbK9XELdRaj nqa2zxn2LvnW51Ry/br2KZBoDcL59+cJL0hYx08cjJDK199HLuip+X/I10Qfv4toQM6i 8fhlDP4Xr4u2XwS0lkZvT2Ybad6rwyAjNOnhEyUuKP+D2fXdBVRWCVyOd+WBw1Ljy055 5GeA== X-Gm-Message-State: APzg51ClSl0OP2gLAWNtVEaSiwhuKEak/0v0mVgDm/3uNNm9R5BT3d6g bwqr576wmf2uW8Pe4Lg30u+o/FIq6C+oDCimTdw= X-Received: by 2002:aca:d452:: with SMTP id l79-v6mr3287402oig.222.1535650340717; Thu, 30 Aug 2018 10:32:20 -0700 (PDT) MIME-Version: 1.0 From: Ray Clinton Date: Thu, 30 Aug 2018 13:32:17 -0400 Message-ID: Subject: [PATCH 2/4] staging: comedi: Correct multiline dereference as per TODO To: greg@kroah.com Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using checkpatch.pl I was able to find a multiline dereference which goes again the coding style for the kernel. I'm still working on my email client so the indentation looks bad here (in gmail) but the arguments for comedi_check_trigger_arg_min should go just under the opening ( Signed-off-by: Ray Clinton --- drivers/staging/comedi/drivers/ni_labpc_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_labpc_common.c b/drivers/staging/comedi/drivers/ni_labpc_common.c index 7fa2d39..0fad809 100644 --- a/drivers/staging/comedi/drivers/ni_labpc_common.c +++ b/drivers/staging/comedi/drivers/ni_labpc_common.c @@ -560,10 +560,10 @@ static int labpc_ai_cmdtest(struct comedi_device *dev, /* make sure scan timing is not too fast */ if (cmd->scan_begin_src == TRIG_TIMER) { if (cmd->convert_src == TRIG_TIMER) { - err |= comedi_check_trigger_arg_min(&cmd-> - scan_begin_arg, - cmd->convert_arg * - cmd->chanlist_len); + err |= comedi_check_trigger_arg_min( + &cmd->scan_begin_arg, + cmd->convert_arg * + cmd->chanlist_len); } err |= comedi_check_trigger_arg_min(&cmd->scan_begin_arg, board->ai_speed * -- 2.7.4