Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp154096imm; Thu, 30 Aug 2018 10:33:50 -0700 (PDT) X-Google-Smtp-Source: ANB0Vda3aZZTBYU8iWJb8iPrO2ITHOCiakaI4SGoec4AHC/Oty/iLq0m1qPvLxqaq/TgpKnOa7Pl X-Received: by 2002:a63:d443:: with SMTP id i3-v6mr10378756pgj.216.1535650430272; Thu, 30 Aug 2018 10:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535650430; cv=none; d=google.com; s=arc-20160816; b=ypWDV8Cnq8WgVOESs4YHFp+MmaqdozVUIjLI0A/zo6HcDmF3tMf7UV+qe4baAY+0ld mvtcyJL9FNgI57Pc0cKMSOdFzOLhI1pRzhKu031l5elWR10OePjEsWt0bOaNXQAY62cb xdqgydQtcTQ6SNvX9lQF4tIadtv79VgYNae1sUjAZ1SC/sGrNRGyR396+9/Tli8FYj8G pBoFyKxmc6etUd16T5ryVpJ8sQQzJMrx2CShHSAjOYdTWAs8z7Tc3iar3nEFZKhGUwSB JPwNkwgOyU7Z8AyXkCnOtMUXqs88e5f12pEqNRRE5vX1srWLr/m28UwTPzVP7GRllOyM spOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature:arc-authentication-results; bh=QOJVtfipmbwMYZzchxc1hpcdX6TtRx5mAqETOOVnPWE=; b=cI1ipsiTkAl0OBKkMPbu2qSVEVRCRXSFraojQBdn8xNXA/8O+Wpj4YRIQeK7KS5Nko 32qwaHFNAlweRYTgaOpYrBwC4IQc8XxjAvSEbkLgWqAonrXc48koAoTW7Ypc4XkLocEQ 7BpjELewNUsQ6W3e6DMVnshzMJvw9hRmQBo6ojDljr3dcVTEnSvsOpW7X4QPhmcniFqH +DNFN8BerOkhl35+5aSHei+q8xmsUMFTq1DU+Ku23oehtdU5g0ZlPnW5QawyegDX5Q0V IxOJB2UAQnfi+q8f0Ox1+rCyOvakFREeqrDxD6W8TscbNAh0qY/SNijxCQtOEymHk3a7 lQWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=paKy4Cgu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2-v6si6685147pgm.581.2018.08.30.10.33.35; Thu, 30 Aug 2018 10:33:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=paKy4Cgu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727494AbeH3Vfh (ORCPT + 99 others); Thu, 30 Aug 2018 17:35:37 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34285 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726732AbeH3Vfg (ORCPT ); Thu, 30 Aug 2018 17:35:36 -0400 Received: by mail-oi0-f67.google.com with SMTP id 13-v6so16913734ois.1 for ; Thu, 30 Aug 2018 10:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=QOJVtfipmbwMYZzchxc1hpcdX6TtRx5mAqETOOVnPWE=; b=paKy4CgurCN6s/btqs5/nPuD/e9r214OUNSD2m1AbnzYZUTOG9RxsVdm90OEc2D0ms NXTKRZ3r0EMtaU9+IQ1mLbz+NuCSNgIfxYH1Uua0Y4uwrZhuEywHaOt8er74S83Dn4Y8 L8KH2TLOcKSVZ3NX22OiHraialu1ZrXchbkOb/SaNJQ5F4LT4TvMHUUUw5Hh6JFnomWh c88ufVj0tmOUKd+KhBGN7MONz+rtlVZ+4G1Al6FmSDOvxHagd7cbNBxFMXKRby8qcTjw xlBTMlptzNtIaArH9KvoW8/5gawWEOoGyAKd67WxVU+MCKi5OrIdcOy6bKdaVhc5iWid sA5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=QOJVtfipmbwMYZzchxc1hpcdX6TtRx5mAqETOOVnPWE=; b=UjIPboHHLd55bfX9anBEMk/CoUK9Q0T9BL9XAAj1kXUqvmi+myOGjT+GSsgKhPT/Tv AdUQmw4MEgRKRBT8dvLwK1Yy+D8S6cRtCmP6EnbhZLvYgb6I/Q4lJ0y4hxUJ04I9+8Gx zZb3sbKFr/7mIVNYA8z3uo4l/eDX0CDmZwDFP+KPgtUWUitP/prRx2puzRAL3qhpngV/ Kx9+dvYYcfIahJPQz8h8HEKumifIOZSA0CYHDDtm+X/OkFQWtY9seE+ANn4NG079atDI a3sHVR6KxPvZvRfF6lBZE3Aek/FllONm37itfXr5hItp1yzbzckm6LGyKWzLdf3sKlal z0Tg== X-Gm-Message-State: APzg51CTEO1/cbrS8l64++qNFul7I8rwycgtIZt6nViINiuUYme4ufQq 2Uy4ZP7oU/qVduLUAAprFCtiTSwpwOixCV0WceVPVQ== X-Received: by 2002:aca:e80c:: with SMTP id f12-v6mr3209449oih.38.1535650344145; Thu, 30 Aug 2018 10:32:24 -0700 (PDT) MIME-Version: 1.0 From: Ray Clinton Date: Thu, 30 Aug 2018 13:32:20 -0400 Message-ID: Subject: [PATCH 3/4] staging: comedi: Correct multiline dereference as per TODO To: greg@kroah.com Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using checkpatch.pl I was able to find a multiline dereference which goes again the coding style for the kernel. I'm still working on my email client so the indentation looks bad here (in gmail) but the arguments for ni_tio_set_mite_channel should go just under the opening ( Signed-off-by: Ray Clinton --- drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c index 4dee2fc..5de3a20 100644 --- a/drivers/staging/comedi/drivers/ni_mio_common.c +++ b/drivers/staging/comedi/drivers/ni_mio_common.c @@ -723,9 +723,9 @@ static void ni_release_gpct_mite_channel(struct comedi_device *dev, ni_set_bitfield(dev, NI_E_DMA_G0_G1_SEL_REG, NI_E_DMA_G0_G1_SEL_MASK(gpct_index), 0); - ni_tio_set_mite_channel(&devpriv-> - counter_dev->counters[gpct_index], - NULL); + ni_tio_set_mite_channel( + &devpriv->counter_dev->counters[gpct_index], + NULL); mite_release_channel(mite_chan); } spin_unlock_irqrestore(&devpriv->mite_channel_lock, flags); -- 2.7.4