Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Aug 2018 14:36:17 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc:     linux-kernel@vger.kernel.org, mingo@kernel.org,
        jiangshanlai@gmail.com, dipankar@in.ibm.com,
        akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
        josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
        dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com,
        oleg@redhat.com, joel@joelfernandes.org, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH tip/core/rcu 3/3] srcu: Make early-boot call_srcu()
 reuse workqueue lists
Message-ID: <20180830143617.2fb85e23@gandalf.local.home>
In-Reply-To: <20180830173742.GA17677@linux.vnet.ibm.com>
References: <20180829212036.GA22033@linux.vnet.ibm.com>
        <20180829212313.22903-3-paulmck@linux.vnet.ibm.com>
        <20180829215616.1c10e476@vmware.local.home>
        <20180830020701.GE4225@linux.vnet.ibm.com>
        <20180829224609.5ffdc9ec@vmware.local.home>
        <20180830032315.GG4225@linux.vnet.ibm.com>
        <20180830124444.6bb9faac@gandalf.local.home>
        <20180830173509.GL4225@linux.vnet.ibm.com>
        <20180830173742.GA17677@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 30 Aug 2018 10:37:42 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:


> > > But still triggered the following:
> > > 
> > >  WARNING: CPU: 0 PID: 0 at /work/git/linux-trace.git/kernel/rcu/srcutree.c:242 check_init_srcu_struct+0x85/0x90  
> > 
> > Gah!!!  I needed to have removed that WARN_ON_ONCE(), didn't I?
> > In fact, I should have removed that once I started using workqueues,
> > quite some time back.  
> 
> As in the below patch.
> 
> 							Thanx, Paul
> 
> ------------------------------------------------------------------------
> 
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index 75571ff09c62..a8846ed7f352 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -239,7 +239,6 @@ static void check_init_srcu_struct(struct srcu_struct *sp)
>  {
>  	unsigned long flags;
>  
> -	WARN_ON_ONCE(rcu_scheduler_active == RCU_SCHEDULER_INIT);

Well it boots without warning ;-)

Tested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

>  	/* The smp_load_acquire() pairs with the smp_store_release(). */
>  	if (!rcu_seq_state(smp_load_acquire(&sp->srcu_gp_seq_needed))) /*^^^*/
>  		return; /* Already initialized. */