Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 88C866037C
From:   "wufan" <wufan@codeaurora.org>
To:     "'Tyler Baicar'" <baicar.tyler@gmail.com>
Cc:     <mchehab@kernel.org>, "'Borislav Petkov'" <bp@alien8.de>,
        "'James Morse'" <james.morse@arm.com>,
        <linux-edac@vger.kernel.org>,
        "'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>,
        "'arm-mail-list'" <linux-arm-kernel@lists.infradead.org>,
        <john.garry@huawei.com>, <toshi.kani@hpe.com>
References: <1535654266-40053-1-git-send-email-wufan@codeaurora.org> <CABo9ajCui0y9HMBzgKWeNtrbu4de+mLh=d9Qdkyo4zhU9az6hw@mail.gmail.com>
In-Reply-To: <CABo9ajCui0y9HMBzgKWeNtrbu4de+mLh=d9Qdkyo4zhU9az6hw@mail.gmail.com>
Subject: RE: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs
Date:   Thu, 30 Aug 2018 13:45:19 -0600
Message-ID: <001901d44099$fc8d7550$f5a85ff0$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: 7bit
Thread-Index: AQIwN43o3rGm5KlibLHCDVEy4C+DsgF7LWjApBTrNgA=
Content-Language: en-us
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tyler, 

> > +static int get_dimm_smbios_index(u16 handle) {
> > +       struct mem_ctl_info *mci;
> > +       int i;
> > +
> > +       mci = ghes_pvt->mci;
> > +
> 
> Minor nit: you could define and set mci in the same line to save some space
> here.
> 
> Otherwise this patch looks good to me.

Good catch Tyler! I'll fix it.

Thanks,
Fan

> Reviewed-by: Tyler Baicar <baicar.tyler@gmail.com>