Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp14601imm; Thu, 30 Aug 2018 13:03:57 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY3yhOVQ6drMAIO8WK71JGdkqIVuKh9qtjZB0SNRNtJs2h82GWlHbqbloP2X8XbMGaSGf51 X-Received: by 2002:a62:3306:: with SMTP id z6-v6mr11930820pfz.85.1535659437571; Thu, 30 Aug 2018 13:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535659437; cv=none; d=google.com; s=arc-20160816; b=Uvh1RHiAgxrTK7uaB+1SgO5No3gweK1cpW3DQi1y1GXMSM+Ma/5W+g5u0zWR5XIqJx Q/nTUKU1dpCbCjqe6/QjmwUuVQ12D9hC7nYhxmORBhV7sFtWNdtHFsPpz9pnArT3UbYp UW3PJl2por8UpfLga4AkBF6DuMEJChZ3Y62sWqOST6yuW43I9/YALf8VALeqL1M7IXxd A/LUkiOTiJYaiviihQOieTwQuWI27lMzbpWzfIlyWOkgfXnkTfrCiTuAjJM3troJXVOn xwgP8Mxb3cwJVN4SQQb2aftKOG9tBNZq+rMfgv8M5rKHN9g6oAywEnLs/8mP3J0rGGWh /pfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature :arc-authentication-results; bh=j2ACXejv66YglOf8tR8lqUUYybuE/S70Ob9McmdUki4=; b=wTl92hkLMq5wcvmg79kGDttlHsH3mEdf79hcxnIxyDzUJW075Asy1q5Aa/rbFSWlcX B8FJnIGYTKa0juUTrqa/tYp7pxEllmSIsa2yDkneRulgmY1nslcrYEOOEw2jbtayDy61 yzpYZ9Ck1mybs1offIcsIyVv5VW0quQw2q4jehBruDoeQl+jGjbTDe75LNm3mguV9yUD pwn2YXcy1U3xEec0Q4t+3cF9f7mh5wQqFH4rkRNjr0r76yfhErDZ+7ck0DGuiVx4rGq8 Cv6sAFrWGfLRAqJPk/oguETVGIKeK19B9dnWLBGvh/m0kNyHGho/T559Gb5aeMlFfjni ea0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lnoHmrS7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k17-v6si7820444pfj.321.2018.08.30.13.03.40; Thu, 30 Aug 2018 13:03:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lnoHmrS7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727516AbeHaAEb (ORCPT + 99 others); Thu, 30 Aug 2018 20:04:31 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39312 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727344AbeHaAEa (ORCPT ); Thu, 30 Aug 2018 20:04:30 -0400 Received: by mail-wm0-f67.google.com with SMTP id q8-v6so3216378wmq.4; Thu, 30 Aug 2018 13:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=j2ACXejv66YglOf8tR8lqUUYybuE/S70Ob9McmdUki4=; b=lnoHmrS7MUCtnPBJphiba75fXgzUn+nMEj8FSAX4KRJWS3F/WxDqq8SJ8dYR8JTaTN lfqUvov3iAeRPacdzY3a9HQZCO3YrNQeyIL0Grvuj2bPgUB0uieRKKHO0ewmSFXhsThw D+GUJ7TOG5BemdQcFIeDtUjZa9LDEMVQgKEXKUgmyLvaC8oJDNeUxS9jkjGiytInKv/M A7gAXQugZykG65DLwaE/cL+4/VGh6kVye4CuZLJ30VDAmXETfkuoHdwFdWH5GV/Ye0Qw 5weZs25aH3wKzMGWDY6xOWOBMeLonG2JODRwVwMfXYC/nEr4UDlqE61TUF4eHvPBI8Qh gMRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j2ACXejv66YglOf8tR8lqUUYybuE/S70Ob9McmdUki4=; b=P9F9apAY09G8m7b0G4xv3YgHXQBtn9FJl2IYEXohAde8REtpNFpxqzv5YH7g6O/oP8 Q73I5J9wkQWSVMTq3500bGgjlPIvzCzSK381fgI/NKzzSESk/WQuR5Nvgvtbhupow5Z/ waM9avls+lvuxJD3Dlx66DWq//hUlePjL4Aotp/vvmRWXLwRKBIl1z9mbB4X+TjiIoGp a0v2XHtKjJT6mK+GA5ptqiuVy9vlZoHXQuoK8Ewjl/IDB0ZEWIFs7p0eX6/uN4MVOqFt uadVWjlWkbNHrqFitBcYijJNXSNv5yuvCuRimt6gS7dyK1YhqL/x48ba9utEUFQE0Pax G4CA== X-Gm-Message-State: APzg51CkMY5hi1jZQ06duz6V3ZWphvvg9Wq4lqQrt/dgX5qOhgrp7p6a q0tTJP2aiQtJzvbwfR9AfB4= X-Received: by 2002:a1c:6486:: with SMTP id y128-v6mr2653925wmb.12.1535659239763; Thu, 30 Aug 2018 13:00:39 -0700 (PDT) Received: from [192.168.2.67] (p578F0EE7.dip0.t-ipconnect.de. [87.143.14.231]) by smtp.gmail.com with ESMTPSA id h184-v6sm1873579wmf.28.2018.08.30.13.00.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 13:00:39 -0700 (PDT) Subject: Re: [linux-sunxi] [PATCH v3 21/30] iio: adc: sun4i-gpadc-iio: add support for H3 thermal sensor To: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@bootlin.com, wens@csie.org, linux@armlinux.org.uk, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, eugen.hristev@microchip.com, rdunlap@infradead.org, vilhelm.gray@gmail.com, clabbe.montjoie@gmail.com, quentin.schulz@bootlin.com, geert+renesas@glider.be, lukas@wunner.de, icenowy@aosc.io, arnd@arndb.de, broonie@kernel.org, arnaud.pouliquen@st.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <20180830154518.29507-1-embed3d@gmail.com> <20180830154518.29507-22-embed3d@gmail.com> <20180830162734.uq65l6ox6uwrmulo@core> From: Philipp Rossak Message-ID: Date: Thu, 30 Aug 2018 22:00:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180830162734.uq65l6ox6uwrmulo@core> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.08.2018 18:27, Ondřej Jirman wrote: >> +static int sun8i_h3_calibrate(struct sun4i_gpadc_iio *info) >> +{ >> +// regmap_write(info->regmap, SUNXI_THS_CDATA_0_1, >> +// info->calibration_data[0]); >> +// regmap_write(info->regmap, SUNXI_THS_CDATA_2_3, >> +// info->calibration_data[1]); > This should probably be implemented, or left out completely. > > regards, > o. > Thanks you are right! This should be implemented! I will fix this in the next version! Thanks, Philipp