Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Aug 2018 23:27:10 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, yuanjiang.yu@unisoc.com,
        Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/2] power: supply: Add Spreadtrum SC2731 charger support
Message-ID: <20180830212710.jhpxjdyuifjxr6t6@earth.universe>
References: <5fcd93bbbcd55a5c23f1c75effdc3670ce7a811b.1535446321.git.baolin.wang@linaro.org>
 <e8a3aba289cd2505db4a8891256bf731f32072cd.1535446321.git.baolin.wang@linaro.org>
 <CAJKOXPd48mSp5srOzr4FkEgb2aS-nqkt+egxbuMi6qodtO1JYw@mail.gmail.com>
 <CAMz4kuJGbvKKVvXmGKaEMbu87bY1nQqB+Zvo5UTpv1gwCG41mQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="257puiedckvm2awp"
Content-Disposition: inline
In-Reply-To: <CAMz4kuJGbvKKVvXmGKaEMbu87bY1nQqB+Zvo5UTpv1gwCG41mQ@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--257puiedckvm2awp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Aug 30, 2018 at 11:08:59AM +0800, Baolin Wang wrote:
> >> +static int sc2731_charger_hw_init(struct sc2731_charger_info *info)
> >> +{
> >> +       int ret;
> >> +
> >> +       /* Enable charger module */
> >> +       ret =3D regmap_update_bits(info->regmap, SC2731_MODULE_EN1,
> >> +                                SC2731_CHARGE_EN, SC2731_CHARGE_EN);
> >> +       if (ret)
> >> +               return ret;
> >> +
> >> +       /* Set default charge termination current to 120 mA */
> >> +       ret =3D regmap_update_bits(info->regmap, info->base + SC2731_C=
HG_CFG2,
> >> +                                SC2731_TERMINATION_CUR_MASK, 0x2);
> >
> > Looks like DeviceTree property.
>=20
> OK.
>=20
> >
> >> +       if (ret)
> >> +               goto error;
> >> +
> >> +       /* Set default charge termination voltage to 4.35V */
> >
> > Looks like DeviceTree property.
>=20
> OK. Thanks for your comments.

I did not review this in detail, but had quick look at this.
Please make sure to derive battery specific DT values using
this:

Documentation/devicetree/bindings/power/supply/battery.txt

-- Sebastian

--257puiedckvm2awp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAluIYSsACgkQ2O7X88g7
+prmbw//VIFs3zlPNH/DpBgYUcd+so+q2u6CvWTnNflbK85M3ywIFczku1VaM6+s
M2Tm2+tl7FXKU+gVA+F+OT+TNnsHfa11VAwLTZhDdRX+MMq9rBb2Gk+cCMOF2h9E
V+63QURkEnT7tOoTXZtAic51F0nRfxH6igVz7WKccfMzXNf8sDGST3ZCvr6bgH6d
VykPh5+TTtVfKnzS3YGbujr34q2VpCjoeZ6J5aK4rY2E40YG4c5cFsnyyEsd54Qa
CliCkkTHU3h56sH68/LSmwMdCcIFU5i7GRBqIOrJV0wtnPos+9obPn5C2bxlNho5
5D8c1WI5u1dVWc5VNOLCuS4d/WJdGu4bm46yHuG+nGiVbKXwwPhgzdjdo8mBw+3V
PvX5eWyX1HODZ7CIrdU96khzW6HEKNfctD6utNfh1tqK4iMoj9hSU76iyGUVQwrQ
YcTdE5cEwsBY+dDylE0ws47s3MqWYMnuK+zcra016W5I6x8dTvIk2JgIdfTXj96H
nMiVqa2TSFDJiQQrttlif7ILc56odKsKlC4qmx48FZd6Q37kSgULNF2mA20JU9Tk
TlMY8f5vJWxAqHfhEZo7YiqHcaipCCpbADob0iqMgBw+3QAl1wjZWEh/hqwxNtSh
BLK0l61DZb1O5zaEdEorF/i7iQoOJm8Q+6s3dEleLJ5eg3TFI4Y=
=dCm9
-----END PGP SIGNATURE-----

--257puiedckvm2awp--