Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp55806imm; Thu, 30 Aug 2018 15:37:26 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZkzPCdotHZSZbVA1RIN7l5srVHUKqER4Mqyit6n+tqvA0OzNHnCNZhOsRc1kOSREaPf0Iv X-Received: by 2002:a63:3642:: with SMTP id d63-v6mr11340105pga.231.1535668646894; Thu, 30 Aug 2018 15:37:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535668646; cv=none; d=google.com; s=arc-20160816; b=qvFHqcWapA67LfEWEezPRJUV76yTO/40Db5KaBuXhYyk1ygTz4nF2PyZhXOFYa6NXs dX/goQXjEHNMwxNtHFXGVAn4VSnzhSFn3qrg9eBcLbG9ZH+tiNCqJ6eLgF6cTHV8ICLF PjAx/aCIkWM2y/gIVkU61Bf9iPuEvVwTGJYURdbfmCYPpIsW/4ieoGQDrqHDhEOjz6J9 7b1vmGyKVBT3rIFX4eBb59g6lYX9e5bGwBrHywWLYQeXpXqT+XahbXxDdzj3TI1n+rx0 nZ1Peox/kP7ng5o6XugIDyZ+uWrf0PHYd/fZgtdhe23WN1EXvtDZAF1fVe0Hl6qsOyUG aMcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=pqtQEQgcmYws4XEfyflPCbTN6X5fe+IYsjDz9oA2yZI=; b=s0GrhkGpDKELoV2S2njo8exy/wOQ1acJSOMpEmt/te8Vo/b5I9RpdboJGTXroQ0W/a NXhjNDFu99nHlJpo0oueDnrh8IlohLyx6ZB3DurOCOOe6iLd+O3jkuZvYfhQoFc1qxtP 5dttkdkMCfghxucUAPHlz72FZKnEEMIY2FjBQCHSfNNFEsOAXW2eYCrmf0blvszvlBDx LqMHAkwcjapv++zLC0KlGBhm9diIKvREsqvkEwVEVsa9k/5qezIS8Eg4urJmL231JhLv +FHnfRtnd7D4cs+R7ln1wGV7P48ZHmJ6zXw+GQWYtf0CI+N8ZThCVr8hpiyym5kkqMmD Ggxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tO2tIkKC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si7345798plz.220.2018.08.30.15.37.12; Thu, 30 Aug 2018 15:37:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tO2tIkKC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727808AbeHaCkV (ORCPT + 99 others); Thu, 30 Aug 2018 22:40:21 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:33582 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727239AbeHaCkU (ORCPT ); Thu, 30 Aug 2018 22:40:20 -0400 Received: by mail-lf1-f68.google.com with SMTP id m26-v6so8481763lfb.0 for ; Thu, 30 Aug 2018 15:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pqtQEQgcmYws4XEfyflPCbTN6X5fe+IYsjDz9oA2yZI=; b=tO2tIkKCHTTqDX+ImB+86TWcltQLZ4UwSYVAP6DnTgClwu7a+F+Q6XoGLw6fzgfxnt N1tzvF/PH/J6lO+zzyuaA3OxvrXv++8+ibdSA0TcYMs1pY2gR5bmjIkDjU831MkWva2x +iLxA0h1akmwoaOI/JURnnhykjgRSpTR7q04A9mRTPJf8gUv33Wnx/noR30a+Q8g57UA FSwvHXzvkcpE84vkosQqMZ6uO6uM8ZDCmrx39HJFB6dM6t160kuieYAHDKHGeoLvbTyw 7LD0K2MxJTVV3uZfq6edijJAEWDsjuIxEDOTaV9Pk0nNxVK+VGDqQn3h1zXqKadI0BZ8 Ebmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pqtQEQgcmYws4XEfyflPCbTN6X5fe+IYsjDz9oA2yZI=; b=Jyd5eE1ZACiH7eHU0B7BJGBi3vFrH3qJp5kfAN3QG36uxZGmEEjwe3RLp8tlsA7M3S 8jF/38fw6+nj/3J9EqvHaorMn/ZZAM3s3zkeuJVc0cd+HGhFF8zqxYF8AeIwa7nbC+Vh ZNgmsKEdtytq/eNPhZ74cBGPQCypMyQM9PQkOBBZf9qYLEJZUwg+FmdCAoyVHbQeClom iS37fXXi4VX09V3oiX6f5Foz+oFwSKYG7/LBFLMio3O9c1GW8yseOdTVUAtZfoDnotPZ SRlsMTUZQA4wyojK0cCdRT74DSDuG6ZNw2rGHwiYsnXHgK46jEC54uSJvHg2eRygt34g 6W+Q== X-Gm-Message-State: APzg51BbGDM68tcp3cCLSmtKUYgJFUmzWylDVMz34UVmZumIb5VD8vY5 8qqJAIPdDo16ACQ5ChgYjNEN6wOJ3sE= X-Received: by 2002:a19:5517:: with SMTP id n23-v6mr8953802lfe.101.1535668554195; Thu, 30 Aug 2018 15:35:54 -0700 (PDT) Received: from Mort.jumbo.freeair (91-159-62-202.elisa-laajakaista.fi. [91.159.62.202]) by smtp.gmail.com with ESMTPSA id u28-v6sm1455376ljd.61.2018.08.30.15.35.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 15:35:53 -0700 (PDT) From: Igor Stoppa X-Google-Original-From: Igor Stoppa To: linux-kernel@vger.kernel.org Cc: igor.stoppa@gmail.com, Igor Stoppa , Alexander Viro Subject: [PATCH 21/23] filesystems: remove unnecessary unlikely() Date: Fri, 31 Aug 2018 01:34:27 +0300 Message-Id: <20180830223429.30051-22-igor.stoppa@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180830223429.30051-1-igor.stoppa@huawei.com> References: <20180830223429.30051-1-igor.stoppa@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Alexander Viro --- fs/open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/open.c b/fs/open.c index 0285ce7dbd51..19a9e4b378d3 100644 --- a/fs/open.c +++ b/fs/open.c @@ -750,7 +750,7 @@ static int do_dentry_open(struct file *f, f->f_mode |= FMODE_ATOMIC_POS; f->f_op = fops_get(inode->i_fop); - if (unlikely(WARN_ON(!f->f_op))) { + if (WARN_ON(!f->f_op)) { error = -ENODEV; goto cleanup_all; } -- 2.17.1