Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp86373imm; Thu, 30 Aug 2018 16:36:38 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYztGnalJY5BI1GpOlw5I19ORA1R6M5Cqu8PzyMdkOa9VvgFhJRDD9zZ8Zwf52lUGXlM5Gv X-Received: by 2002:a17:902:b60e:: with SMTP id b14-v6mr12332878pls.111.1535672198779; Thu, 30 Aug 2018 16:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535672198; cv=none; d=google.com; s=arc-20160816; b=oYd7HI3S5Fv4FBBMEz91JM/Nx3amVCkgEyXjE2Lo0Nv3DEIHmoFWQ7V3FRxMXfCl5v A9q5emGVMna1xg0fs/q1Spdc8M4FhVG7rLi+OFKenYXIDsIfj3uqBbaVegEZ0hHcZcd+ cEKwYWl7wS+KZ6M1Od/1ffz01QVs/8aRYmR4oLd6tbvX9lnVlEEDRdIxu2qBC8piBZ+s CKJP1FRzvB0jTCTNlkFGHVL3TKPNzqqTh6lLlyLraAG+iTu7UCxm4yEM9uWDK4jtJVoB 0jGGlX8a9YBJRHQBGjOg4J7tuxS/Kj5iwzFazriEtWOQ5Od8r6e3pacNRq0lad6zl0rq iDVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=o8SrRTumiSi+xHsiIA9VRyEDtJl3jf8afEfvT83OgnA=; b=o7VtC8cCP4Z1031iNuv7z6OPit6vSf4zd5KJ6VhLgprdDsh3jxJevfJz44bXz2zt34 BpYcGymB/s0KHBXluWV0Fyt/aIFYLhymqlXvuv4ydmrz1TIV8vfsyotVhp9TEFFFBNDi Pdk3z9nNIHShtF8noVuERUia2S1SDTdBFTSf9tHiFEaPLlrMJzmN2F1H6XdBmlJmiA7C YsuzRFDfP1AWxyjYJFSk9fDtgXb7pcI4ZzjTzL2PUKXBJlSYy4z52dce3Kp9Is1xO8UO QPzIXeOCThnkjh+bGOFJFHHBEnI1lhoJ7Ns4r1s57HeUAaa6F/eBAnH35e15whVJSCI9 017g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 35-v6si7708095pgz.453.2018.08.30.16.36.24; Thu, 30 Aug 2018 16:36:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727230AbeHaDi3 (ORCPT + 99 others); Thu, 30 Aug 2018 23:38:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42252 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbeHaDi3 (ORCPT ); Thu, 30 Aug 2018 23:38:29 -0400 Received: from localhost.localdomain (c-24-4-154-175.hsd1.ca.comcast.net [24.4.154.175]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5FDA7E29; Thu, 30 Aug 2018 23:33:53 +0000 (UTC) Date: Thu, 30 Aug 2018 16:33:52 -0700 From: Andrew Morton To: Souptick Joarder Cc: konishi.ryusuke@lab.ntt.co.jp, viro@zeniv.linux.org.uk, tytso@mit.edu, adilger.kernel@dilger.ca, axboe@kernel.dk, darrick.wong@oracle.com, ebiggers@google.com, pombredanne@nexb.com, agruenba@redhat.com, gregkh@linuxfoundation.org, kemi.wang@intel.com, willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH v2] fs: Convert return type int to vm_fault_t Message-Id: <20180830163352.5a96cc721ce069bed95fdbe8@linux-foundation.org> In-Reply-To: <20180830172547.GA4408@jordon-HP-15-Notebook-PC> References: <20180830172547.GA4408@jordon-HP-15-Notebook-PC> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Aug 2018 22:55:47 +0530 Souptick Joarder wrote: > Return type for fault handlers in ext4 and nilfs are > changed to use vm_fault_t. > > Return type of block_page_mkwrite() is changed from > int to vm_fault_t. The function signature of > block_page_mkwrite() is changed to add one new parameter > int *err. This will provide a way for caller functions > to get error value along with return value and use it > further. > > Return type of block_page_mkwrite_return() is also changed > to use new vm_fault_t type. > --- a/fs/nilfs2/file.c > +++ b/fs/nilfs2/file.c > @@ -51,13 +51,14 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync) > return err; > } > > -static int nilfs_page_mkwrite(struct vm_fault *vmf) > +static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf) nilfs_page_mkwrite() already has return type vm_fault_t in Linus's kernel, due to the now-merged fs-nilfs2-adding-new-return-type-vm_fault_t.patch. Looks like a simple fix. I'm beginning to feel vm_fault_t exhaustion. Please remind me what benefit we're going to get out of all this churn? > > ... >