Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp112974imm; Thu, 30 Aug 2018 17:32:41 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZ/lHipVJ6r/sto1Gp7NmUdJHfN7f8CqupisKk5GLY2I3gTe/feHatmeBAdrwCvHkqOdRjZ X-Received: by 2002:a62:5f82:: with SMTP id t124-v6mr12881664pfb.223.1535675561049; Thu, 30 Aug 2018 17:32:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535675561; cv=none; d=google.com; s=arc-20160816; b=vRcnLKLQP5H7PNXjpjedu7yVq7ye1NPYVxdnxZGr/pnuQTq4iLCmafD6t70M2xugKf 8lZ1Rg2lCGdwbkUsbgFsAPxi6iAG/RO4VJpRndzRaltH20fNJ0AC9ySnuQYp4we+GIUh zYxLWDoEfINw3a/5p+im9FBg7BljQiE5CuhLfdwyiUD/jduC+qJaJFUwLElEe4G5/sP7 V74whvUXMGo/4WY5VpMEYdrlVarl9jZLj04UH3WsM0tHI3ar4E6sQCSe4HLmYrw6CMIb 75U5SYqoUC+2Wl3eWehiOH9E9oAqn0cMDVNSxbCoMf25U/jvR2griOh3q+6zy6/pLBQE 9IIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=X1t+NgmZcwZyxrPSWolMRySn9k6lt3z1i/z9X9jOAHs=; b=KDA0JnL+PoKffP1PH4nLLKrW4dRmMjR9nEwdEXvBwVESdfLgsl60slvReDEPr9CC/h dGLoYXHlmRzUYXax2KcsLjTxZWdeV6vbnEdC7k9YcX4pt1gTckfup9z4Clu27gjBRBYh UTku/NXD1BOPZlNsM/sox/HQodl6bJ7Q9UcnIvv6VLoicA7MCnDVz9hkCdsW1CQsWMTR dlhPpwIuOKOyu1GNRmOGA4GS9+c0YlObvn7EeJQ0hpYPE6mfgIolNC4Gzul9J+8e7A3R rr3hZ15yVCQPnaIhafW2DP9WfyKRdreS45v8dzMkDJc3E7dUb8IQzRy7xZ2mzMfi2a7b 9puw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="Vhg/ULI+"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j13-v6si8519639pfd.319.2018.08.30.17.32.25; Thu, 30 Aug 2018 17:32:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="Vhg/ULI+"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727233AbeHaEfh (ORCPT + 99 others); Fri, 31 Aug 2018 00:35:37 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:52876 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725761AbeHaEfh (ORCPT ); Fri, 31 Aug 2018 00:35:37 -0400 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id B548210C08CB; Thu, 30 Aug 2018 17:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1535675452; bh=X1t+NgmZcwZyxrPSWolMRySn9k6lt3z1i/z9X9jOAHs=; h=From:To:CC:Subject:Date:References:From; b=Vhg/ULI+zqeKQpBw59xURT2+7D7Nt/l2XzC18dHW1OVdyiajAiBqrCHWllx9QkNgN z4Bk3BM7Q4JYV3PXjC464dQHy/zTsFIMZ+1VBko1IsGQda4lC/+X1io78sKZqlvxaV 8DcJEPq6A/+haGZg9Tu4+80bS4vIF3dEyTFUCG/q8knM+39j+MAnVy0ET8ZgB3S1a0 I+82rSJBbPD8Fw6WAF+MLRowi/A7BGVJ2TJTywAuimL1qprTcT3UnMnGuyHp1ScigF 6OHKCBOmYJlsKj0Simcv4b6u+UuwBt5egRvB8YwZwzKrU/HMxcpcdor3zTmiOcnPtY bFOW+s9EtqoYA== Received: from US01WEHTC3.internal.synopsys.com (us01wehtc3.internal.synopsys.com [10.15.84.232]) by mailhost.synopsys.com (Postfix) with ESMTP id 95EE25580; Thu, 30 Aug 2018 17:30:51 -0700 (PDT) Received: from us01wembx1.internal.synopsys.com ([169.254.1.253]) by US01WEHTC3.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Thu, 30 Aug 2018 17:30:51 -0700 From: Vineet Gupta To: Peter Zijlstra CC: Will Deacon , Eugeniy Paltsev , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , "tglx@linutronix.de" , "linux-snps-arc@lists.infradead.org" , "yamada.masahiro@socionext.com" , "linux-arm-kernel@lists.infradead.org" , "linux-arch@vger.kernel.org" Subject: Re: Patch "asm-generic/bitops/lock.h: Rewrite using atomic_fetch_" causes kernel crash Thread-Topic: Patch "asm-generic/bitops/lock.h: Rewrite using atomic_fetch_" causes kernel crash Thread-Index: AQHUP8bWpY6ZRO7qfEeDcvF8FJVDUg== Date: Fri, 31 Aug 2018 00:30:50 +0000 Message-ID: References: <1535567633.4465.23.camel@synopsys.com> <20180830094411.GX24124@hirez.programming.kicks-ass.net> <20180830095148.GB5942@arm.com> <1535629996.4465.44.camel@synopsys.com> <20180830141713.GN24082@hirez.programming.kicks-ass.net> <20180830142354.GB13005@arm.com> <20180830142920.GO24082@hirez.programming.kicks-ass.net> <20180830204515.GC24124@hirez.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.104] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/30/2018 01:45 PM, Peter Zijlstra wrote:=0A= >>=0A= >> Indeed this is the mother of all issues, I tried and system is clearly h= osed with=0A= >> and works after.=0A= >> What's amazing is the commit 4aef66c8ae9 which introduced it is from 201= 6 ;-)=0A= >> Back then we had a retry branch with backoff stuff which I'd reverted fo= r new=0A= >> cores and the merge conflict somehow missed it.=0A= >>=0A= >> @PeterZ I'll create a patch with you as author ? do I need any formal si= gn offs,=0A= >> acks etc ?=0A= > Well, Will spotted it, give authorship to him, you have my ack per the=0A= > above.=0A= =0A= Oops, sorry for the mixup. I have him as author now and pushed to ARC for-c= urr=0A= (will trickle into linux-next eventually).=0A= =0A= > FWIW, also ACK on Will's patch to switch you over to asm-generic bitops= =0A= > entirely.=0A= =0A= Yeah I'll get it to that and your's after the clear_bit_lock stuff - sorry = for=0A= hijacking this thread to that topic now=0A= =0A= -Vineet=0A=