Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180830212710.jhpxjdyuifjxr6t6@earth.universe>
References: <5fcd93bbbcd55a5c23f1c75effdc3670ce7a811b.1535446321.git.baolin.wang@linaro.org>
 <e8a3aba289cd2505db4a8891256bf731f32072cd.1535446321.git.baolin.wang@linaro.org>
 <CAJKOXPd48mSp5srOzr4FkEgb2aS-nqkt+egxbuMi6qodtO1JYw@mail.gmail.com>
 <CAMz4kuJGbvKKVvXmGKaEMbu87bY1nQqB+Zvo5UTpv1gwCG41mQ@mail.gmail.com> <20180830212710.jhpxjdyuifjxr6t6@earth.universe>
From:   Baolin Wang <baolin.wang@linaro.org>
Date:   Fri, 31 Aug 2018 13:59:11 +0800
Message-ID: <CAMz4ku+nPOtr_hWLswB=iwC8iCJ_cTCn1EjX8DwzVR97G_mGzQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] power: supply: Add Spreadtrum SC2731 charger support
To:     Sebastian Reichel <sre@kernel.org>
Cc:     Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, yuanjiang.yu@unisoc.com,
        Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sebastian,

On 31 August 2018 at 05:27, Sebastian Reichel <sre@kernel.org> wrote:
> Hi,
>
> On Thu, Aug 30, 2018 at 11:08:59AM +0800, Baolin Wang wrote:
>> >> +static int sc2731_charger_hw_init(struct sc2731_charger_info *info)
>> >> +{
>> >> +       int ret;
>> >> +
>> >> +       /* Enable charger module */
>> >> +       ret = regmap_update_bits(info->regmap, SC2731_MODULE_EN1,
>> >> +                                SC2731_CHARGE_EN, SC2731_CHARGE_EN);
>> >> +       if (ret)
>> >> +               return ret;
>> >> +
>> >> +       /* Set default charge termination current to 120 mA */
>> >> +       ret = regmap_update_bits(info->regmap, info->base + SC2731_CHG_CFG2,
>> >> +                                SC2731_TERMINATION_CUR_MASK, 0x2);
>> >
>> > Looks like DeviceTree property.
>>
>> OK.
>>
>> >
>> >> +       if (ret)
>> >> +               goto error;
>> >> +
>> >> +       /* Set default charge termination voltage to 4.35V */
>> >
>> > Looks like DeviceTree property.
>>
>> OK. Thanks for your comments.
>
> I did not review this in detail, but had quick look at this.
> Please make sure to derive battery specific DT values using
> this:
>
> Documentation/devicetree/bindings/power/supply/battery.txt

Sure. Will look at this file. Thanks.

-- 
Baolin Wang
Best Regards