Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp282783imm; Thu, 30 Aug 2018 23:50:22 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdby0VRqu9i3PG/o8ztysqK61x0TMP1OI2t1rXWjVKCIorkQrG0J0MFMOUoVu7QKSxNWD7Yj X-Received: by 2002:a17:902:7009:: with SMTP id y9-v6mr13736054plk.249.1535698221989; Thu, 30 Aug 2018 23:50:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535698221; cv=none; d=google.com; s=arc-20160816; b=uiqaxDQPlo3SkJADITKzWMxL6a/4N6VtxphfbLyWaCyvcdOxYOhinSgXEeCXr3wV9C C6fHruCTggEDWrZnOf/50wAjRwvMMcuBgLAVdcjAnQ9h4j7i6WJ/HKC2BniaO1+MHps3 ApmlJ4GXh1zTMqL1XL0nB1sPEauLzCD8C+Iez4wIh+3G7wRW2OLp7smRn4hZVGIUqztu ew29t89UJ2Ruo6C83LT8a8Yns6LUmaKdzIQg+4RlIjgs6AWsxVnMrc6Y31xDYR13iZ+d oeGUxCpcLx/lpDlEi33xSAFNqYqhHkMU5scNelReiXQwhzKtJ1yL7EWSsstOIwm0CU94 xF6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=nQLw9HFqHtWJL/XuWG3/S0c3iWAj1GHLA7jYnPLgSX8=; b=yvvu1sUJlM3b/xbT06p50N7Sp1wGxKnUBXS40+8/QtIGClf/O6YN0tGQYSIWab7kI3 VBqxlF1PQ350Qk1zFv+WBr70tfE0eJkB9CVpi5AiXv8DF+uk9aS2h61Y4afmvgIWDnr8 kW43s5M7Cl1ZEfWAuYsnNj9XRIWUf2mUEZWSgbAw34JYaOcNwCOS5l9StscA4FKCdq3O ZtQTTxVxQcbwtKgJtHL6wnsdh22TKl/W4IQBwTyfmttB00hhkQd6LihItGdINgHV4oSO BTywnalr6/dulBVmigNL54/siS5AeUDZ2y0bwQ2jJpr8KTe9+I70TbXtQCOjU8hg3ZdB cH6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w68-v6si9176210pfw.308.2018.08.30.23.49.52; Thu, 30 Aug 2018 23:50:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727328AbeHaKx3 (ORCPT + 99 others); Fri, 31 Aug 2018 06:53:29 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35209 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727178AbeHaKx3 (ORCPT ); Fri, 31 Aug 2018 06:53:29 -0400 Received: by mail-wm0-f67.google.com with SMTP id o18-v6so4237817wmc.0; Thu, 30 Aug 2018 23:47:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nQLw9HFqHtWJL/XuWG3/S0c3iWAj1GHLA7jYnPLgSX8=; b=N2Vtg4HYFa3+nZPDlRIQLk8Fg26/dnNm7KKZuOseG/j5vus6tFqxobrFGpeo3m+vbI RRL61xW1cCZGcnGZqk/y2tI9uHJCvU8Csrls8whXIVRCAM3nqlKHKyiS/YCyxChNFkLH A2vcfyWEem0usSH9nNPN8G0lNl4YAhXhfdF4h0VabqdbUJZlRD6uScTkTVAOLvXRFZyj 1ZzB8DOtAzKE1SkYq3UQzUCDVNrWFai6OavrVCr5zf/AjVTywCp34IogAuU+shcZjOEw PQGcxNPGW6TTyxzdLLJM5apvwR9lpWdyO6ypolNbtYDNzYybZv4NQfYlsnRLE/4711U3 vEpA== X-Gm-Message-State: APzg51CEy62tLqoP5YzhvQeK+HklScNoDGmXCGnDUQFtXcb+6QRSHoud eJtsaJF9gqE2ifUB7D4xImVDDqvh X-Received: by 2002:a7b:c017:: with SMTP id c23-v6mr3869607wmb.136.1535698049827; Thu, 30 Aug 2018 23:47:29 -0700 (PDT) Received: from ?IPv6:2a01:4240:2e27:ad85:aaaa::70f? ([2a01:4240:2e27:ad85:aaaa::70f]) by smtp.gmail.com with ESMTPSA id e5-v6sm2741231wmh.29.2018.08.30.23.47.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Aug 2018 23:47:28 -0700 (PDT) Subject: Re: [PATCH 1/4] tty: Drop tty->count on tty_reopen() failure To: Dmitry Safonov , linux-kernel@vger.kernel.org Cc: Daniel Axtens , Dmitry Safonov <0x7f454c46@gmail.com>, Sergey Senozhatsky , Dmitry Vyukov , Tan Xiaojun , Peter Hurley , =?UTF-8?B?UGFzaSBLw6Rya2vDpGluZW4=?= , Greg Kroah-Hartman , Michael Neuling , Mikulas Patocka , stable@vger.kernel.org References: <20180829022353.23568-1-dima@arista.com> <20180829022353.23568-2-dima@arista.com> <1535559207.23560.55.camel@arista.com> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSBKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAZ21haWwuY29tPsLBewQTAQIAJQIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AFAk6S6P4CGQEACgkQvSWxBAa0cEl1Sg//UMXp//d4lP57onXMC2y8gafT1ap/xuss IvXR+3jSdJCHRaUFTPY2hN0ahCAyBQq8puUa6zaXco5jIzsVjLGVfO/s9qmvBTKw9aP6eTU7 77RLssLlQYhRzh7vapRRp4xDBLvBGBv9uvWORx6dtRjh+e0J0nKKce8VEY+jiXv1NipWf+RV vg1gVbAjBnT+5RbJYtIDhogyuBFg14ECKgvy1Do6tg9Hr/kU4ta6ZBEUTh18Io7f0vr1Mlh4 yl2ytuUNymUlkA/ExBNtOhOJq/B087SmGwSLmCRoo5VcRIYK29dLeX6BzDnmBG+mRE63IrKD kf/ZCIwZ7cSbZaGo+gqoEpIqu5spIe3n3JLZQGnF45MR+TfdAUxNQ4F1TrjWyg5Fo30blYYU z6+5tQbaDoBbcSEV9bDt6UOhCx033TrdToMLpee6bUAKehsUctBlfYXZP2huZ5gJxjINRnlI gKTATBAXF+7vMhgyZ9h7eARG6LOdVRwhIFUMGbRCCMXrLLnQf6oAHyVnsZU1+JWANGFBjsyy fRP2+d8TrlhzN9FoIGYiKjATR9CpJZoELFuKLfKOBsc7DfEBpsdusLT0vlzR6JaGae78Od5+ ljzt88OGNyjCRIb6Vso0IqEavtGOcYG8R5gPhMV9n9/bCIVqM5KWJf/4mRaySZp7kcHyJSb0 O6nOwU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02 XFTIt4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P +nJWYIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYV nZAKDiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNe LuS8f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+B avGQ8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUF Bqgk3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpo tgK4/57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPD GHo739Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBK HQxz1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkF Ak6S54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH /1ldwRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+ Kzdr90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj 9YLxjhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbc ezWIwZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+d yTKLwLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330m kR4gW6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/ tJ98f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCu jlYQDFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmf faK/S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= Message-ID: Date: Fri, 31 Aug 2018 08:47:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535559207.23560.55.camel@arista.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/29/2018, 06:13 PM, Dmitry Safonov wrote: >> I would just do: >> if (!retval) >> tty->count++; >> here. Nobody from ldiscs should rely on tty->count. > > I thought about that and probably should have described in commit > message why I haven't done that: I prefer to keep it as was as I did Cc > stable tree - to keep the chance of regression to minimum. > > I agree that your way is cleaner, but probably it may be done as > cleanup on top for linux-next.. Agreed, so care to cook it up as 5/4 in this series :)? thanks, -- js suse labs