Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <177f25ad-de40-ce3f-987f-ac34c2559be4@infradead.org>
References: <alpine.LRH.2.21.1808191406030.12334@math.ut.ee> <177f25ad-de40-ce3f-987f-ac34c2559be4@infradead.org>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Fri, 31 Aug 2018 18:42:01 +0900
Message-ID: <CAK7LNATOTW2mSHB_D3BcgtXPuiLGpLz_rbjgPQzCq4hCLhTfYw@mail.gmail.com>
Subject: Re: make *config regression: pkg-build
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Meelis Roos <mroos@linux.ee>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi.

2018-08-20 0:37 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> On 08/19/2018 04:15 AM, Meelis Roos wrote:
>> Just tried to run 'make menuconfig' on v4.18-10568-g08b5fa819970 and
>> found a bad surprise:
>>
>> 'make *config' requires 'pkg-config'. Please install it.
>> make[1]: *** [scripts/kconfig/Makefile:219: scripts/kconfig/.mconf-cfg] Error 1
>>
>> This is clearly a regression - I have libncurses devele pakcage
>> installed in the default system location (as do 99%+ on actuall
>> develeopers proobably) and in this case, pkg-config is useless.
>> pkg-config is needed only when libraries and headers are installed in
>> non-default locations but it is bad to require installation of
>> pkg-config on all the machines where make menuconfig would be possibly
>> run (for example, I have a aboult 100 machine kernel testbed with
>> self-hosted kernel compilation and machine-specific kernel
>> configurations that ocassionally need tweaking).
>>
>> I notice 4.18 complained it can not find pkg-config but still worked.
>> This is clearly better than now.
>>
>> If we want to support developers with libraries in non-default
>> locations, why not - but the common case of system include path should
>> work without any trouble or warnings. For exaple, test if compilation
>> against ncurses works, and if not retry it with pkg-config (and error
>> out if it does not give working result).
>>
>
> Hi,
> This is due to my patch: 4ab3b80159d4db63b902ef635d4b5e882911b2da.
>
> Yamada-san, any ideas?  Feel free to just revert it.
>

Sorry for delay, I chose a partial revert
because I want to keep checking pkg-config for {g,x}config.

I posted a patch.


-- 
Best Regards
Masahiro Yamada