Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp402850imm; Fri, 31 Aug 2018 03:41:11 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbLpORlVQO8a0gNAgkuPknrPxR4gUvjIwLJU9zGI8Mr9EsZSd6kj22bVyBIJsIJ2XF4nNLZ X-Received: by 2002:a62:9cd7:: with SMTP id u84-v6mr15207620pfk.90.1535712071656; Fri, 31 Aug 2018 03:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535712071; cv=none; d=google.com; s=arc-20160816; b=fYOufgFjhSSwqvWXDKiC+kfqjomfLzC1Ppcn7KjKQFAuM2fyeVW6pA8JrP9Ta9/upg 2hDrwQHX0gthPEYn07A4nY5SYLBFMVk7pPQo1nqj0ZrkCrWhW2Lea+A7ZiZQIoTtDVCA KO2v2/TwJ8wwYjxAlHEn8LHxeTNzTMcmSziU7QiyTnTsULc+FR3v/mxL0p/eI4Q6V9hx W9sIq2qXipwVD7HC2q58eBl7mt9Y8+T1ikhLywQG74U80N93xHuIourVxJcEFF90CsVR rukhcnou3OT0lkKNOPwVBSjPEcG7xpwoY2h+i/SMfmEq8xPYfxK63FRjThWhy71ENoR4 olMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=OO16tPwljJBf3L2+GJjbBRkA/tZTmCRBRnPRqJN3F0Y=; b=J1uC1rhfU1EQ16occFxlSe3MbyP6JFKUXrEGnvjUNqiuh2toh37jgiQXXiRimbaOMV PG0GVZoKnBB9+FgjEqeekqeDT8vvt7b34Z3px55VgMsN6OJ+ysSBdhrP1Xns13I/dzbc KyOFo1RJJsoQlKfiM43ysaHGxZiMA0lolSA/Jjw7fMcFCgKIgv9ZiG8zJ1WVhqvVyeqR +ekEjlGhZIPw55QNJ+Yb8bj3mp+JeKcjPokBl6Z2Quz72JT/x8FxYDlpuFOteKt7P5/m +kh4mVlORAbNXXYPF+OFA72ErRPEwzwNmnl9k0ONotP+I5APGwcevikhn3DmJY2cJfDi mfeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="j/w5aGzG"; dkim=pass header.i=@codeaurora.org header.s=default header.b="Kgp/62qV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20-v6si7394922pgl.249.2018.08.31.03.40.57; Fri, 31 Aug 2018 03:41:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="j/w5aGzG"; dkim=pass header.i=@codeaurora.org header.s=default header.b="Kgp/62qV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727856AbeHaN7U (ORCPT + 99 others); Fri, 31 Aug 2018 09:59:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46906 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbeHaN7U (ORCPT ); Fri, 31 Aug 2018 09:59:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 01475606FC; Fri, 31 Aug 2018 09:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1535709159; bh=yFm+eKN4XMCF/AChukJnyrNHWfw4YnFeA0bZNbnSKbU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=j/w5aGzGsZm4mJMcOqKQDML2lubkFUZKJaCq6gJzW392OH9jcmcuWECZhbXPVSwEV Dh8GWqT16vB6vygE+DSaKbwMC7JZBWWWWgVU6TGgkQBNEyaGhH58i4ZDFpvKOg13C1 dyqzQRsOEsB4j1NqKuoWAmGrk9EnDP0e5Pq1PL/0= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C1032606FC; Fri, 31 Aug 2018 09:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1535709158; bh=yFm+eKN4XMCF/AChukJnyrNHWfw4YnFeA0bZNbnSKbU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Kgp/62qVXRkMihlHdULECxUMmYZiuNhA2H1C5jiRiQiAhkc2vTnP/FKXgElqV8IZy zPxnZVAXll4J9kic6bbIyXfdZxaVdllFme9e0BPsGDLqwblFc54TnKdG86MqKCN5Wg 73X8GdzNNOn0LBQEwea6l0FIFSKD4vzZ7sQj2nlI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C1032606FC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Igor Stoppa Cc: linux-kernel@vger.kernel.org, Igor Stoppa , Christian Lamparter , linux-wireless@vger.kernel.org Subject: Re: [PATCH 10/23] wireless: remove unnecessary unlikely() References: <20180830223429.30051-1-igor.stoppa@huawei.com> <20180830223429.30051-11-igor.stoppa@huawei.com> Date: Fri, 31 Aug 2018 12:52:33 +0300 In-Reply-To: <20180830223429.30051-11-igor.stoppa@huawei.com> (Igor Stoppa's message of "Fri, 31 Aug 2018 01:34:16 +0300") Message-ID: <87va7qdfry.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + linux-wireless Igor Stoppa writes: > WARN_ON_ONCE() already contains an unlikely(), and the logical or of two of > them is still unlikely(), so it's not necessary to wrap them into another. > > Signed-off-by: Igor Stoppa > Cc: Christian Lamparter > Cc: Kalle Valo IMHO you could fold patches 10, 11 and 12 into one to avoid having three patches with duplicate titles. Or alternatively use proper driver prefixes like "ath10k:", "b43:" and so on. But how do you want these to be applied? For the wireless patches you didn't Cc linux-wireless so our patchwork won't see them and hence I can't take them. So if you want me to take these, please resend and include linux-wireless. -- Kalle Valo