Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 31 Aug 2018 14:14:27 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Peter Zijlstra <peterz@infradead.org>
cc:     mojha@codeaurora.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
        mingo@kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:smp/urgent] cpu/hotplug: Remove skip_onerr field from
 cpuhp_step structure
In-Reply-To: <20180831083316.GR24082@hirez.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.21.1808311413280.4105@nanos.tec.linutronix.de>
References: <1535439294-31426-1-git-send-email-mojha@codeaurora.org> <tip-935aad3015fb4afc0b7ef6e6c18175b95461de47@git.kernel.org> <20180831083316.GR24082@hirez.programming.kicks-ass.net>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-557380923-1535717667=:4105"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-557380923-1535717667=:4105
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT

On Fri, 31 Aug 2018, Peter Zijlstra wrote:

> On Thu, Aug 30, 2018 at 04:03:58AM -0700, tip-bot for Mukesh Ojha wrote:
> > Commit-ID:  935aad3015fb4afc0b7ef6e6c18175b95461de47
> > Gitweb:     https://git.kernel.org/tip/935aad3015fb4afc0b7ef6e6c18175b95461de47
> > Author:     Mukesh Ojha <mojha@codeaurora.org>
> > AuthorDate: Tue, 28 Aug 2018 12:24:54 +0530
> > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Thu, 30 Aug 2018 12:59:30 +0200
> 
> > @@ -644,12 +637,6 @@ static void cpuhp_thread_fun(unsigned int cpu)
> >  
> >  	WARN_ON_ONCE(!cpuhp_is_ap_state(state));
> >  
> > -	if (st->rollback) {
> > -		struct cpuhp_step *step = cpuhp_get_step(state);
> > -		if (step->skip_onerr)
> > -			goto next;
> > -	}
> > -
> >  	if (cpuhp_is_atomic_state(state)) {
> >  		local_irq_disable();
> >  		st->result = cpuhp_invoke_callback(cpu, state, bringup, st->node, &st->last);
> 
> 
> Can you fold this in?
> 
> ../kernel/cpu.c: In function ‘cpuhp_thread_fun’:
> ../kernel/cpu.c:663:1: warning: label ‘next’ defined but not used [-Wunused-label]

Bah. I even saw the warning and wanted to fix it before pushing it
out. That's what you get for doing 20 things at once....

Folded in and force pushed. Thanks Peter!
--8323329-557380923-1535717667=:4105--