Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262925AbTKEOhV (ORCPT ); Wed, 5 Nov 2003 09:37:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262927AbTKEOhV (ORCPT ); Wed, 5 Nov 2003 09:37:21 -0500 Received: from ns.suse.de ([195.135.220.2]:27273 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S262925AbTKEOhN (ORCPT ); Wed, 5 Nov 2003 09:37:13 -0500 Date: Wed, 5 Nov 2003 13:36:26 +0100 From: Jens Axboe To: Bartlomiej Zolnierkiewicz Cc: Linus Torvalds , Linux Kernel Mailing List Subject: Re: [PATCH] fix rq->flags use in ide-tape.c Message-ID: <20031105123625.GM1477@suse.de> References: <200311041718.hA4HIBmv027100@hera.kernel.org> <20031105084004.GY1477@suse.de> <200311051300.47039.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200311051300.47039.bzolnier@elka.pw.edu.pl> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 38 On Wed, Nov 05 2003, Bartlomiej Zolnierkiewicz wrote: > On Wednesday 05 of November 2003 09:40, Jens Axboe wrote: > > On Tue, Nov 04 2003, Linux Kernel Mailing List wrote: > > > ChangeSet 1.1413, 2003/11/04 08:01:30-08:00, > > > B.Zolnierkiewicz@elka.pw.edu.pl > > > > > > [PATCH] fix rq->flags use in ide-tape.c > > > > > > Noticed by Stuart_Hayes@Dell.com: > > > > Guys, this is _way_ ugly. We definitely dont need more crap in ->flags > > for private driver use, stuff them somewhere else in the rq. rq->cmd[0] > > usage would be a whole lot better. This patch should never have been > > merged. If each and every driver needs 5 private bits in ->flags, > > well... > > Yeah, it is ugly. Using rq->cmd is also ugly as it hides the problem in > ide-tape.c, but if you prefer this way I can clean it up. I just wanted > minimal changes to ide-tape.c to make it working. Well using ->cmd is acceptable. Adding these 5 bits for ide-tape is, on the other hand, completely and utterly unacceptable. So I'd greatly prefer it that way :) > > Was this even posted on linux-kernel for review? > > Yes. Ok missed it then. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/