Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <ffe6f38e96c0d84326e2d853e2aa8e9b87b8b9f1.camel@redhat.com>
Subject: Re: [PATCH 01/23] infiniband: nes: add unlikely() to assert()
From:   Doug Ledford <dledford@redhat.com>
To:     Igor Stoppa <igor.stoppa@gmail.com>, linux-kernel@vger.kernel.org
Cc:     Igor Stoppa <igor.stoppa@huawei.com>,
        Chien Tung <chien.tin.tung@intel.com>,
        Roland Dreier <rolandd@cisco.com>,
        Faisal Latif <faisal.latif@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>
Date:   Fri, 31 Aug 2018 10:06:59 -0400
In-Reply-To: <20180830223429.30051-2-igor.stoppa@huawei.com>
References: <20180830223429.30051-1-igor.stoppa@huawei.com>
         <20180830223429.30051-2-igor.stoppa@huawei.com>
Organization: Red Hat, Inc.
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-sNj0nZP7Yn9nvKTZ70C4"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-sNj0nZP7Yn9nvKTZ70C4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2018-08-31 at 01:34 +0300, Igor Stoppa wrote:
> Typically the assert is expected to not fail.
>=20
> Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
> Cc: Chien Tung <chien.tin.tung@intel.com>
> Cc: Roland Dreier <rolandd@cisco.com>
> Cc: Faisal Latif <faisal.latif@intel.com>
> Cc: Doug Ledford <dledford@redhat.com>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>

Acked-by: Doug Ledford <dledford@redhat.com>

> ---
>  drivers/infiniband/hw/nes/nes.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/=
nes.h
> index bedaa02749fb..d2d0098f38e0 100644
> --- a/drivers/infiniband/hw/nes/nes.h
> +++ b/drivers/infiniband/hw/nes/nes.h
> @@ -151,7 +151,7 @@ do { \
> =20
>  #define assert(expr) \
>  do { \
> -	if (!(expr)) { \
> +	if (unlikely(!(expr))) { \
>  		printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n", \
>  			   #expr, __FILE__, __func__, __LINE__); \
>  	} \

--=20
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint =3D AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
--=-sNj0nZP7Yn9nvKTZ70C4
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAluJS4MACgkQuCajMw5X
L92kzw/+PDl/ZO4p4UlfkrucSQmmmR7Ebw1fH3Co5pj9DYlN2IvTSAd8wL/usPdD
Wfukj5+lhpos2GyA8uIt6pxvNlGgmA+3Utrj67LKCGHZxAEz+JtEWGjSLi2iXtEg
ouxf/QYVbsqdveMBPn5b5bkALkxVpde5OFsL6SbKl7daMDkoR9xmRL51GmpnB+Ro
HXaK16A1zhRcuSVlYshV/oN0fdyqhhyDFZTMuFQSAUn+/fc6RutQhxXcfnks30Cv
mT4pqt1CfksDsDdYVByrWLk3GiorScznb9X09leEBOwN53eSJGRbEaTZ5OXC85Vh
WIoNlJFqpK7nNAfAXX0VqU0Zq0xron9VGX02OCiNMsRF/EeA4gyj6MRG2Jh3mdcq
MsjvbqqT5bfWqnumMBpcBQi2pWhqKc99PRkoP6ksjOVErP8QqjOfN2vz3Y9Ici8P
e5dFqxdX2xohE7CoVESK+ZWfDWx7sVxgw6mqDBUNa3hAmqi2jvpqrayiBfNLS6q1
tCj2Qy8ceyGubWzsJXBzerCK3biZ2/PhBUbCV1y7U2uo4W/D2nbg9sSxi21bpxx0
qyzZict0fQGr5C3zBzkAXnSRtCS1ricpFuV5yNDpdHmp5QqzXFq8T6APsCYPbirA
+g7Lna4hfZuzpuC1/bMPuZYh5RYBA136Tqbu5VSIc4uKe8qV7R8=
=K5AT
-----END PGP SIGNATURE-----

--=-sNj0nZP7Yn9nvKTZ70C4--