Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp619417imm; Fri, 31 Aug 2018 08:51:19 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYt3gGK+37eHqSL9UpHcoFjgrKHr+gC01/om+b+5wMwGfoL4zXx42NiGwjrkKN+2xM1Lp0V X-Received: by 2002:a17:902:bd86:: with SMTP id q6-v6mr9211701pls.35.1535730679855; Fri, 31 Aug 2018 08:51:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535730679; cv=none; d=google.com; s=arc-20160816; b=IxS8vR5kqDUx6bK06bZh+GRjEDoc0RxesisMfIIaCR3RuYh9ca5QSlMfCYlj9Ea6AL YP8QMiTnmaLnP/g7UiKdRODzbHRSIokIUKo4oFVjDwFtWxcQUSOj6GQrBtUDKdtP7CUR uI/i6zpi/+k1fRcWwgnZQ/aS7KMcUpiCeTPkbo4C3mbdErghWZvloNHfGAOvuLjCZ6Rv bv0XedIBoVlYDFpIYpGEtDILK3xHxGzFeoG40i61qkkzflWhf9aMLvXeU+UOHVmmg8Dm wB9pF+0aIi7wjeb88pMsKrGxb9oDoIriAZoH5pXFC27qKMpKKgVIgBXfo0YVBIxsbKwL ZUCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=sC8N1acRi2T0wcB2hYaIbejNJ4iMdgdw+m2NKObxBm0=; b=dF86wcoeyCUGzlZ54mF0tmH6HyiZyGKbeRcHD9QXsvTNg5AusHNuUfMk5iz6vZWJSs k3ZmewZECFoN/f7R5h1w5CydCdmuDan+baCMMs1OGuFIESCCzvU60R6Y79QvbL9oJwaR 1PD0AheeIujwEw08BW9XCTT+1uGvrYlgsS+0OLjXVESErva4x1IGD1yq8AbN6gdGzKz+ bV7daLMwF7PYVPQfkYVhoGcGVi+N3pQVKyKkkdp23wCcIfe1Hs1p6cZ1qCtCSEl7Nyka TBJfPkXHdQmOTMfBcz+DUn0+DlytATBDjUtK0irUbCV+E5iHxIclAcvSpJY4h4yYkRwa n5sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=hmVVNNHX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k190-v6si9877692pgd.80.2018.08.31.08.51.05; Fri, 31 Aug 2018 08:51:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=hmVVNNHX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729187AbeHaT5u (ORCPT + 99 others); Fri, 31 Aug 2018 15:57:50 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:33002 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728375AbeHaT5u (ORCPT ); Fri, 31 Aug 2018 15:57:50 -0400 Received: by mail-qt0-f193.google.com with SMTP id r37-v6so15061648qtc.0 for ; Fri, 31 Aug 2018 08:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sC8N1acRi2T0wcB2hYaIbejNJ4iMdgdw+m2NKObxBm0=; b=hmVVNNHXcUy+YLY9OhZzCIWW2RBnPcBYnVfh7t9lwJxo+qJTxhzzHiCaq8vucWlFMj eYDo9R8u03JOZzxZ/kn3K3iNvUzShDcY2rjNyuYDPRai58GJGFCVPkQgZO9Y39iklpR7 N/RyVM/CoTMEJNbg7Vv7FzvJwismPWcOstByUEvGX5xSsh9bR+BT8Agvyrw/7kQ8gqw6 gNG/9PTQPRw7LMpm4zb5rhkzURuJY9NjNRPRyH5QpwAdUKIHcMsOnZYt4qt3iJhnpKlX aoZp4j0xUqo7wpst3j89S8D7PCAXmHD2GUF+Hx/puogsSJwBMTZAl1vDsmVp9ijC3JCX R0eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sC8N1acRi2T0wcB2hYaIbejNJ4iMdgdw+m2NKObxBm0=; b=Kn6DOsyNdT97GDRaQS952Y9ZN+rYXVE9QAHMhIN95V+IoqvcJx8R/FORuqiUUyeAQ1 cXPywfeRZxb4YJs+bzVI1Wj6cm2Nfg5y4Go6vFN5BK8rfz4KDEH1yfeL0f+QxdxSXSYc Mkpt0fg/+MSeP7Wt63/Ms5gbMNgvhpv2rNerRMtvT1pqN0/CloGEp3P8pH2paG4oH6/y 9aqR/262jz9ytsBxvTrsmWsetMSm7IKjERHxDaBgvZF3WO9CoeaebInt3/Yrs7XhcQ3z zkSXHIuDUKdo2Z3La2TbOwpkrjtdywshXvuP3r9JeENS4TIuhUu1CajikjY98IDzEj3z ztFw== X-Gm-Message-State: APzg51C06pUneAFULSFAGyePT4XrHjolUcg+sgLla1yegdh1g7FWh0ad L8IBR4z1j6a7yUO9KUtfPewu8A== X-Received: by 2002:ac8:2d2e:: with SMTP id n43-v6mr16741565qta.38.1535730583504; Fri, 31 Aug 2018 08:49:43 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id 80-v6sm8083068qka.6.2018.08.31.08.49.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 08:49:42 -0700 (PDT) Date: Fri, 31 Aug 2018 11:49:41 -0400 From: Josef Bacik To: Dennis Zhou Cc: Jens Axboe , Tejun Heo , Johannes Weiner , Josef Bacik , kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/15] blkcg: change blkg reference counting to use percpu_ref Message-ID: <20180831154939.sb24oz7ekxcwkkfd@destiny> References: <20180831015356.69796-1-dennisszhou@gmail.com> <20180831015356.69796-14-dennisszhou@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180831015356.69796-14-dennisszhou@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 30, 2018 at 09:53:54PM -0400, Dennis Zhou wrote: > From: "Dennis Zhou (Facebook)" > > Now that every bio is associated with a blkg, this puts the use of > blkg_get, blkg_try_get, and blkg_put on the hot path. This switches over > the refcnt in blkg to use percpu_ref. > > Signed-off-by: Dennis Zhou Reviewed-by: Josef Bacik Thanks, Josef