Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp664485imm; Fri, 31 Aug 2018 09:55:06 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZatgM084ekZZ7LjNzXHp/pTPsH2vf+TmEl3mLrC74IQg7lq+/TM2iq6cFXmree8BzVKh78 X-Received: by 2002:a63:5358:: with SMTP id t24-v6mr14795253pgl.208.1535734506139; Fri, 31 Aug 2018 09:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535734506; cv=none; d=google.com; s=arc-20160816; b=ujw0l6ZO8X3MdHUy9drxIrg59egb4H+bX7uLhYA9OkI8UH3SuFLUdIwAhfcOmdp7LU vE5IVtXx6U4kzWbLUtGEZms058ljV57LYr5I30J/QA9pj2vrrEKUGvDvHHqd40kiq0jt srd9vUcDl6606tRvOt6WDa69F37ijJbBOn8zmMTYZi4lXS6UmLwfmUlqhBdpVsez+Shx g6Xepe6XxxVzk/ph99/sdDH9n+jj6AqA37wkI+j07pmkpcoOqP+uqgkKq7hthM1lrPYF Ll4ZqcZqHR6HcXitjK63tWaNFYQTd/HipP3oqkH3HtyaNlOZFTBAWDcPNXsrVcmTSY++ uTjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=oTTi4LomNEA+eyylY9J25z7L5EQgvbGUWvU0vaiUg9k=; b=ymroDnwyjNwH6RwFVy7FmIJBnTPNtFL0Pu8ImD1dZEKD2f69FDgd/0aBhVCIyRPYAc jGkrE/xobELua1l6CDM6yEwOJpuWDeJUS8JHOvRysDFLMWTatpk70AxNqdGbhONcOYvc th1ViB0Qvg5zoGNIdwPnZZ0ksMU5P66xBMlJDT2PxaOlSCWsg3OgnW+0ZeckhnE3oHsq qd/ZjP91fepeo2EE4RvS87kvCmlzzJhaSaPcXAXz66LY9akVnY8FahZzGXsWkigeJJVA Yq6ug4MSueBs8EGKj29RkQn+WfdhLQDRNJ8pIm5+hgfRpA+fK+6BKBXOkJlLTe31qc+U k6MA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1-v6si10125510plq.352.2018.08.31.09.54.51; Fri, 31 Aug 2018 09:55:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728815AbeHaTTw (ORCPT + 99 others); Fri, 31 Aug 2018 15:19:52 -0400 Received: from mail.bootlin.com ([62.4.15.54]:47013 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728553AbeHaTTw (ORCPT ); Fri, 31 Aug 2018 15:19:52 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 6FFBF2071E; Fri, 31 Aug 2018 17:11:55 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (242.171.71.37.rev.sfr.net [37.71.171.242]) by mail.bootlin.com (Postfix) with ESMTPSA id E6CAA22A3C; Fri, 31 Aug 2018 17:11:28 +0200 (CEST) From: Alexandre Belloni To: Wolfram Sang , Jarkko Nikula , James Hogan , Paul Burton Cc: Andy Shevchenko , Mika Westerberg , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Thomas Petazzoni , Allan Nielsen , Alexandre Belloni Subject: [PATCH v5 5/7] i2c: designware: add MSCC Ocelot support Date: Fri, 31 Aug 2018 17:11:12 +0200 Message-Id: <20180831151114.25739-6-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.19.0.rc1 In-Reply-To: <20180831151114.25739-1-alexandre.belloni@bootlin.com> References: <20180831151114.25739-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Microsemi Ocelot I2C controller is a designware IP. It also has a second set of registers to allow tweaking SDA hold time and spike filtering. Reviewed-by: Andy Shevchenko Tested-by: Jarkko Nikula Acked-by: Jarkko Nikula Signed-off-by: Alexandre Belloni --- drivers/i2c/busses/i2c-designware-core.h | 3 ++ drivers/i2c/busses/i2c-designware-platdrv.c | 40 +++++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index f6cad20a86ff..5b550ab9a009 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -225,6 +225,7 @@ struct dw_i2c_dev { struct device *dev; void __iomem *base; + void __iomem *ext; struct completion cmd_complete; struct clk *clk; struct reset_control *rst; @@ -279,6 +280,8 @@ struct dw_i2c_dev { #define ACCESS_INTR_MASK 0x00000004 #define MODEL_CHERRYTRAIL 0x00000100 +#define MODEL_MSCC_OCELOT 0x00000200 +#define MODEL_MASK 0x00000f00 u32 dw_readl(struct dw_i2c_dev *dev, int offset); void dw_writel(struct dw_i2c_dev *dev, u32 b, int offset); diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index e88090a62cb5..0d8cf805e9d4 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -157,11 +157,48 @@ static inline int dw_i2c_acpi_configure(struct platform_device *pdev) #endif #ifdef CONFIG_OF +#define MSCC_ICPU_CFG_TWI_DELAY 0x0 +#define MSCC_ICPU_CFG_TWI_DELAY_ENABLE BIT(0) +#define MSCC_ICPU_CFG_TWI_SPIKE_FILTER 0x4 + +static int mscc_twi_set_sda_hold_time(struct dw_i2c_dev *dev) +{ + writel((dev->sda_hold_time << 1) | MSCC_ICPU_CFG_TWI_DELAY_ENABLE, + dev->ext + MSCC_ICPU_CFG_TWI_DELAY); + + return 0; +} + +int dw_i2c_of_configure(struct platform_device *pdev) +{ + struct dw_i2c_dev *dev = platform_get_drvdata(pdev); + struct resource *mem; + + switch (dev->flags & MODEL_MASK) { + case MODEL_MSCC_OCELOT: + mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); + dev->ext = devm_ioremap_resource(&pdev->dev, mem); + if (!IS_ERR(dev->ext)) + dev->set_sda_hold_time = mscc_twi_set_sda_hold_time; + break; + default: + break; + } + + return 0; +} + static const struct of_device_id dw_i2c_of_match[] = { { .compatible = "snps,designware-i2c", }, + { .compatible = "mscc,ocelot-i2c", .data = (void *)MODEL_MSCC_OCELOT }, {}, }; MODULE_DEVICE_TABLE(of, dw_i2c_of_match); +#else +static inline int dw_i2c_of_configure(struct platform_device *pdev) +{ + return -ENODEV; +} #endif static void i2c_dw_configure_master(struct dw_i2c_dev *dev) @@ -296,6 +333,9 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) dev->flags |= (uintptr_t)device_get_match_data(&pdev->dev); + if (pdev->dev.of_node) + dw_i2c_of_configure(pdev); + if (has_acpi_companion(&pdev->dev)) dw_i2c_acpi_configure(pdev); -- 2.19.0.rc1