Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp704662imm; Fri, 31 Aug 2018 10:57:52 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdbt1s8/HkeKZn9dFAU2N8w5aeY0aSpFqvXtMeyWrMRcgrziIiMxd7lDEkPMMTEwkT3nYJqb X-Received: by 2002:a17:902:261:: with SMTP id 88-v6mr16447249plc.331.1535738272160; Fri, 31 Aug 2018 10:57:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535738272; cv=none; d=google.com; s=arc-20160816; b=wrydbv7QefVkEdhCDa5ZcUxgnBkJyTDIjU1vO3LO5BvyWYhjMOJKEw/x9Jx6XWVO0s hRQkSkGncOgcoIKEmjnA/9SZev6DrkJwB6pZchh8GG0lzE2W4vphl8PD1Krmz+HYpcBX UvgLL/WOUG80gWoOGikLFwJrvY4BmjDbFBpJf9kAmRonQO/zFwBpcoOGRq52Jzf9pvyD LH6DcHX8k74ktATywQ0P5CU3uDq3lgoHG2N+xMTvWzDll5iDvu4jHaU8iYpf8zFO6PZA K1frFLeMtaEwEanC6uDICcp1s/hIZ3r7u9BqigJ8D+f5u+PTuqfMICR+oucS6PFYTqUN nrtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature:arc-authentication-results; bh=KG/3ythGtcjo33PlyAHYtmrvADEPn7PWnFoiFtJ0yLA=; b=nB1B3e7PQyx58tETcXMUCYVDLu93jz8SsGIeqPydPIlQBvquomyKyuztUFWhPc/GzO dZ+iRqvMZPmVJGuXNvM5n4AdG/AaCi8WGhP/XqvHCcqHmXlhcCDKbUoa3mAt260pxlDR a1rpWyXw37CFUZLx5Gm6zUWt9OLKuFfdUyGCqmAe76QMOwQjQ6Wu0f6Lx9k/HsX/b+4p EfNh1f45bZ4rs6smFPKd1usZ3UankPLIsYTkqi/3zR0Gc26OhZI2iNylrM8NQ+1n54Pq PDcYjwgZ/6CL89yj7p7/7Jj6+JhrjN0ibfwfzBnjbK9R5XlxVMqwXrnMTCeAL90kuS8O jAqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="o/fx3Dzu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b34-v6si9968694pld.394.2018.08.31.10.57.37; Fri, 31 Aug 2018 10:57:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="o/fx3Dzu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727373AbeHaWFI (ORCPT + 99 others); Fri, 31 Aug 2018 18:05:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:35020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727069AbeHaWFI (ORCPT ); Fri, 31 Aug 2018 18:05:08 -0400 Received: from localhost (unknown [104.132.0.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6E5C2083A; Fri, 31 Aug 2018 17:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535738192; bh=KG/3ythGtcjo33PlyAHYtmrvADEPn7PWnFoiFtJ0yLA=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=o/fx3Dzu3V4NriwOyhgAY9l7+jOHQgqky0YgQ5sBNYZHlQMqjv/wOQzZvima31JfR +d15FqGaL5yTzV4kesIgHkgXXuUkfsK7rmeJurIRGoV8kWWmO6EcCGGkf2HdLt4YzG LbPLVkKEKT2whareylqNSdZEM88/NmLt26JVx0dk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Eddie James , linux-kernel@vger.kernel.org From: Stephen Boyd In-Reply-To: <1535576973-8067-1-git-send-email-eajames@linux.vnet.ibm.com> Cc: linux-media@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, andrew@aj.id.au, mchehab@kernel.org, joel@jms.id.au, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, mturquette@baylibre.com, linux-arm-kernel@lists.infradead.org, Eddie James References: <1535576973-8067-1-git-send-email-eajames@linux.vnet.ibm.com> Message-ID: <153573819126.93865.1884182656081956202@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH 0/4] media: platform: Add Aspeed Video Engine driver Date: Fri, 31 Aug 2018 10:56:31 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Eddie James (2018-08-29 14:09:29) > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting as a service processor, the Video Engine can > capture the host processor graphics output. > = > This series adds a V4L2 driver for the VE, providing a read() interface > only. The driver triggers the hardware to capture the host graphics output > and compress it to JPEG format. > = > Testing on an AST2500 determined that the videobuf/streaming/mmap interfa= ce > was significantly slower than the simple read() interface, so I have not > included the streaming part. > = > It's also possible to use an automatic mode for the VE such that > re-triggering the HW every frame isn't necessary. However this wasn't > reliable on the AST2400, and probably used more CPU anyway due to excessi= ve > interrupts. It was approximately 15% faster. > = > The series also adds the necessary parent clock definitions to the Aspeed > clock driver, with both a mux and clock divider. Please let me know your merge strategy here. I can ack the clk patches because they look fine from high-level clk driver perspective (maybe Joel can take a closer look) or I can merge the patches into clk-next and get them into next release while the video driver gets reviewed.