Received: by 2002:ac0:a5a6:0:0:0:0:0 with SMTP id m35-v6csp719939imm; Fri, 31 Aug 2018 11:21:31 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZr786zJLyvXDLDsEdhYJ6JbhJtqUdsL4vxw1VomfSy8PdbKyy19vecZLs+qJHeFUXHWx06 X-Received: by 2002:a17:902:a504:: with SMTP id s4-v6mr9877880plq.101.1535739691016; Fri, 31 Aug 2018 11:21:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535739690; cv=none; d=google.com; s=arc-20160816; b=YpgVtUpyzZbVik4Itx+I+OFfmhFi584LFl1YT/oioeZcNMThgUp/qr2Loik89gQG1Y 7DYoaMD+d4FoqfJv5tuKmPjgDaD2nv9eG9Xq8F6ubf4guB2ms5a2np1Zqm12YD7jvRW/ uj6T5/hFPc4pOjOJXG9Aqdqfm3kScK2b8PvKs68eQu26P6/FnN16v8YwFFulGoAeuPdf WGyKmlTVRttUuVWi2HaXKnje78ybBc+SM3SiAlUcHBIkn2q1MgPnPWeDhjnyNjHN0nB3 9vHisdDmPeQowQ9wYG31ooIGOakJxrBq6Xaq2c+eLlRZoDem5IKZTx4zQMt4a+Ki8wTl zElg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :arc-authentication-results; bh=2JKf/6yiN3N1IrFNRZmF3GiQf1CQ5ACIlOaxywgy/dk=; b=EUTLQLO4UJ6jYtcxVY4gb/c2FODKXzOSK0E0tgDVKteKd6u9OrIDgvoiU8G7CriP11 m5QQJsa2R3bP6S8q/oson+krE8NtEE+/1NQ3CGdeW7LWUQA86Tf7gVS3f3PDLvGf/bjP cPsss/vTwb9yavJMLpqcIghsuHeOPvL+QECVbK94EvpvEPSHMc8WI4WJp+MBMzHZ7oa1 /eDo9cL4ST3OtGwo5vBobZrHRZGnUuTzwKrg9GbWMU92/Bjc4x6U8CUqrimKBS/lIlJk lzSHr3hF8HK27dfd/Z49yIIHbMkhrmebjqHDOfQLw80qp43DSRp2VqxaXFlvNBaJz8bi KntQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5-v6si10323155pgd.54.2018.08.31.11.21.16; Fri, 31 Aug 2018 11:21:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727425AbeHaW2w (ORCPT + 99 others); Fri, 31 Aug 2018 18:28:52 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36005 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727239AbeHaW2v (ORCPT ); Fri, 31 Aug 2018 18:28:51 -0400 Received: from [114.245.33.124] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fvo1g-0001o1-Kt; Fri, 31 Aug 2018 18:20:09 +0000 From: Aaron Ma To: aaron.ma@canonical.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gustavo@padovan.org Subject: [PATCH 1/2] vgaarb: Add support for 64-bit frame buffer address Date: Sat, 1 Sep 2018 02:19:59 +0800 Message-Id: <1535739600-8842-1-git-send-email-aaron.ma@canonical.com> X-Mailer: git-send-email 1.8.5.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org EFI GOP uses 64-bit frame buffer address when some BIOS disabled CSM support. vgaarb only stores lfb_base, this will lead boot framebuffer to wrong device. Add ext_lfb_base support to use 64-bit fb address. Signed-off-by: Aaron Ma --- drivers/gpu/vga/vgaarb.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c index c61b04555779..8d90e66994b0 100644 --- a/drivers/gpu/vga/vgaarb.c +++ b/drivers/gpu/vga/vgaarb.c @@ -1408,6 +1408,18 @@ static void __init vga_arb_select_default_device(void) struct vga_device *vgadev; #if defined(CONFIG_X86) || defined(CONFIG_IA64) + u64 base = screen_info.lfb_base; + u64 size = screen_info.lfb_size; + u64 limit; + resource_size_t start, end; + unsigned long flags; + int i; + + if (screen_info.capabilities & VIDEO_CAPABILITY_64BIT_BASE) + base |= (u64)screen_info.ext_lfb_base << 32; + + limit = base + size; + list_for_each_entry(vgadev, &vga_list, list) { struct device *dev = &vgadev->pdev->dev; /* @@ -1418,11 +1430,6 @@ static void __init vga_arb_select_default_device(void) * Select the device owning the boot framebuffer if there is * one. */ - resource_size_t start, end, limit; - unsigned long flags; - int i; - - limit = screen_info.lfb_base + screen_info.lfb_size; /* Does firmware framebuffer belong to us? */ for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { @@ -1437,7 +1444,7 @@ static void __init vga_arb_select_default_device(void) if (!start || !end) continue; - if (screen_info.lfb_base < start || limit >= end) + if (base < start || limit >= end) continue; if (!vga_default_device()) -- 2.17.1