Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: android: ion: fix ION_IOC_{MAP,SHARE}
 use-after-free
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Greg Hackmann <ghackmann@android.com>
Cc:     linux-kernel@vger.kernel.org, Laura Abbott <labbott@redhat.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        devel@driverdev.osuosl.org, kernel-team@android.com,
        stable@vger.kernel.org
References: <20180831200627.59712-1-ghackmann@google.com>
 <20180831201232.GA23559@kroah.com>
From:   Greg Hackmann <ghackmann@google.com>
Message-ID: <c41f1a53-7aa1-e0e3-58eb-8c1f3d34e14d@google.com>
Date:   Fri, 31 Aug 2018 13:17:20 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180831201232.GA23559@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/31/2018 01:12 PM, Greg Kroah-Hartman wrote:
> On Fri, Aug 31, 2018 at 01:06:27PM -0700, Greg Hackmann wrote:
>> The ION_IOC_{MAP,SHARE} ioctls drop and reacquire client->lock several
>> times while operating on one of the client's ion_handles.  This creates
>> windows where userspace can call ION_IOC_FREE on the same client with
>> the same handle, and effectively make the kernel drop its own reference.
>> For example:
>>
>> - thread A: ION_IOC_ALLOC creates an ion_handle with refcount 1
>> - thread A: starts ION_IOC_MAP and increments the refcount to 2
>> - thread B: ION_IOC_FREE decrements the refcount to 1
>> - thread B: ION_IOC_FREE decrements the refcount to 0 and frees the
>>             handle
>> - thread A: continues ION_IOC_MAP with a dangling ion_handle * to
>>             freed memory
>>
>> Fix this by holding client->lock for the duration of
>> ION_IOC_{MAP,SHARE}, preventing the concurrent ION_IOC_FREE.  Also
>> remove ion_handle_get_by_id(), since there's literally no way to use it
>> safely.
>>
>> This patch is applied on top of 4.9.y.  Kernels 4.12 and later are
>> unaffected, since all the underlying ion_handle infrastructure has been
>> ripped out.
> 
> Does 4.4.y or older also need this?  If so, can you send backports, as
> this one does not apply there.
> 
> thanks,
> 
> greg k-h
> 

Yes, 4.4.y and older will need this.  If there are no objections to this
patch, I'll send backports ASAP.