Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAK8P3a2N0pPvLvmERpHPZ5pmYQpNpd4Yqfq2d2cJZ96UHLd8VA@mail.gmail.com>
References: <20180831170514.24665-1-miguel.ojeda.sandonis@gmail.com>
 <20180831170514.24665-5-miguel.ojeda.sandonis@gmail.com> <CAK8P3a2N0pPvLvmERpHPZ5pmYQpNpd4Yqfq2d2cJZ96UHLd8VA@mail.gmail.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Fri, 31 Aug 2018 22:26:02 +0200
Message-ID: <CANiq72nOOcumNJeZ7w=UXW5p9w82+FZGXGuwJ_SA-gPuFfctow@mail.gmail.com>
Subject: Re: [PATCH 5/7] Compiler Attributes: naked was fixed in gcc 4.6
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Eli Friedman <efriedma@codeaurora.org>,
        Christopher Li <sparse@chrisli.org>,
        Kees Cook <keescook@chromium.org>,
        Ingo Molnar <mingo@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        gregkh <gregkh@linuxfoundation.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Joe Perches <joe@perches.com>,
        Dominique Martinet <asmadeus@codewreck.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Arnd,

On Fri, Aug 31, 2018 at 9:48 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, Aug 31, 2018 at 7:05 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
>>
>> Commit 9c695203a7dd ("compiler-gcc.h: gcc-4.5 needs noclone
>> and noinline on __naked functions") added noinline and noclone
>> as a workaround for a gcc 4.5 bug, which was resolved in 4.6.0.
>>
>> Since now the minimum gcc supported version is 4.6,
>> we can clean it up.
>>
>> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44290
>> and https://godbolt.org/z/h6NMIL
>>
>
>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
>> index 66e1eb8822d9..fdf2fbe6d544 100644
>> --- a/include/linux/compiler-gcc.h
>> +++ b/include/linux/compiler-gcc.h
>> @@ -77,14 +77,8 @@
>>   * to trace naked functions because then mcount is called without
>>   * stack and frame pointer being set up and there is no chance to
>>   * restore the lr register to the value before mcount was called.
>> - *
>> - * The asm() bodies of naked functions often depend on standard calling
>> - * conventions, therefore they must be noinline and noclone.
>> - *
>> - * GCC 4.[56] currently fail to enforce this, so we must do so ourselves.
>> - * See GCC PR44290.
>>   */
>> -#define __naked                __attribute__((naked)) noinline __noclone notrace
>> +#define __naked                __attribute__((naked)) notrace
>>
>
> Good catch. Can this be moved into linux/compiler.h now so we
> don't need separate definitions for clang and gcc?

Yes, it can! :-) Actually I was writing that to Nick in the other
thread about clang, but you beat me to it. Good catch too!

Cheers,
Miguel