Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 00/23] Make use of unlikely() more consistently.
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        igor.stoppa@huawei.com, Aaro Koskinen <aaro.koskinen@iki.fi>,
        Alasdair Kergon <agk@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Andrew Jeffery <andrew@aj.id.au>,
        Archit Taneja <architt@codeaurora.org>, asolokha@kb.kras.ru,
        bvanassche@acm.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        chien.tin.tung@intel.com, chunkeey@googlemail.com,
        Christoph Lameter <cl@linux.com>,
        David Airlie <airlied@linux.ie>,
        David Daney <ddaney@caviumnetworks.com>,
        Dennis Zhou <dennisszhou@gmail.com>, dima@arista.com,
        Doug Ledford <dledford@redhat.com>,
        "Latif, Faisal" <faisal.latif@intel.com>,
        gregkh <gregkh@linuxfoundation.org>,
        Daode Huang <huangdaode@hisilicon.com>,
        Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        James Hogan <jhogan@kernel.org>,
        Jason Gunthorpe <jgg@ziepe.ca>, ejt@redhat.com,
        Kalle Valo <kvalo@codeaurora.org>,
        Kees Cook <keescook@chromium.org>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Linus Walleij <linus.walleij@linaro.org>,
        Madalin-Cristian Bucur <madalin.bucur@nxp.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        "Michael S. Tsirkin" <mst@redhat.com>, michal.kazior@tieto.com,
        Mike Snitzer <snitzer@redhat.com>,
        Paul Burton <paul.burton@mips.com>,
        Paul Mackerras <paulus@samba.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Ralf Baechle <ralf@linux-mips.org>,
        Rob Clark <robdclark@gmail.com>, rolandd@cisco.com,
        Salil Mehta <salil.mehta@huawei.com>,
        Shuah Khan <shuah@kernel.org>,
        srivatsa.bhat@linux.vnet.ibm.com, sviau@codeaurora.org,
        Tejun Heo <tj@kernel.org>, yisen.zhuang@huawei.com,
        zijun_hu@htc.com
References: <20180830223429.30051-1-igor.stoppa@huawei.com>
 <CAK8P3a2JasKXtXYoV7KsSZt4TwkffsBjrf=LK1HZJx0KFKCcow@mail.gmail.com>
From:   Igor Stoppa <igor.stoppa@gmail.com>
Message-ID: <46369585-4d67-5235-d57d-a5162cc85e56@gmail.com>
Date:   Fri, 31 Aug 2018 23:35:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAK8P3a2JasKXtXYoV7KsSZt4TwkffsBjrf=LK1HZJx0KFKCcow@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 31/08/18 17:09, Arnd Bergmann wrote:

[...]

>> #define assert(condition)
>> ...
>>          if (unlikely(!(condition)))
>>                  error_action()
>> ...
> 
> There is a potential that this introduces false-postive -Wmaybe-uninitialized
> warnings when CONFIG_PROFILE_ANNOTATED_BRANCHES is
> set, since that turns unlikely() into a complex operation that in turn
> confuses the compiler so it no longer keeps track of which variables
> are initialized or not.
> 
> It's possible that none of your patches do that, but one needs to be aware
> of the problem, and possibly revert some of your patches if it does cause
> warning regressions in drivers that don't actually benefit from the
> micro-optimization.

I see.
But if such case might arise, it might be possible, instead of reverting 
these patches, to locally - and conditionally - turn unlikely() into an 
identity macro.

For example:

#ifdef CONFIG_PROFILE_ANNOTATOED_BRANCHES
#define unlikely(x) (x)
#endif

Without giving up the hint for the case of normal compilation.

--
igor